Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
On Fri, Apr 27, 2007 at 07:01:43PM -0700, Andrew Morton wrote:
> This one-liner is turning into a fiasco.
> diff -puN
> drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend
> drivers/ide/legacy/ide-cs.c
> ---
> a/drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend
> +++ a/drivers/ide/legacy/ide-cs.c
> @@ -401,6 +401,8 @@ static struct pcmcia_device_id ide_ids[]
> PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a, 0x3489e003),
> PCMCIA_DEVICE_PROD_ID1("TRANSCEND512M ", 0xd0909443),
> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1,
> 0x2a54d4b1),
> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
> 0xf54a91c8),
> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
> 0x969aa4f2),
> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1,
> 0xf54a91c8),
> PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
> PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c, 0x212bb918),
> _
>
>
> Is this really supposed to add a TS2GCF120 entry with the same IDs
> as TS4GCF120?
That's probably a copy and paste error. 0x969aa4f2 is the correct ID.
> And pata_pcmcia-recognize-2gb-compactflash-from-transcend.patch:
This one is all right so for what it's worth, it gets:
Acked-by: Peter Stuge <[EMAIL PROTECTED]>
//Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
On Thu, 26 Apr 2007 11:21:01 +0200
"Aeschbacher, Fabrice" <[EMAIL PROTECTED]> wrote:
> As pointed to by Peter, and also as indicated by a judicious output in
> dmesg, the 4th parameter should be 0x969aa4f2. Please find below the
> corrected patch:
>
> Signed-off-by: Fabrice Aeschbacher <[EMAIL PROTECTED]>
>
> ===
> --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15
> 21:08:02.0 +0200
> +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c2007-04-26
> 11:13:13.0 +0200
> @@ -399,6 +399,7 @@
> PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a,
> 0x3489e003),
> PCMCIA_DEVICE_PROD_ID1("TRANSCEND512M ", 0xd0909443),
> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1,
> 0x2a54d4b1),
> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
> 0x969aa4f2),
> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1,
> 0xf54a91c8),
> PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
> PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c,
> 0x212bb918),
> ===
This one-liner is turning into a fiasco. All the top-posting and
word-wrapped patches aren't helping :(
I presently have two patches. Please check them.
ide-cs-recognize-2gb-compactflash-from-transcend.patch:
From: "Aeschbacher, Fabrice" <[EMAIL PROTECTED]>
Without the following patch, the kernel does not automatically detect
2GB CompactFlash cards from Transcend.
Signed-off-by: Fabrice Aeschbacher <[EMAIL PROTECTED]>
Cc: Dominik Brodowski <[EMAIL PROTECTED]>
Cc: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/ide/legacy/ide-cs.c |2 ++
1 files changed, 2 insertions(+)
diff -puN
drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend
drivers/ide/legacy/ide-cs.c
---
a/drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend
+++ a/drivers/ide/legacy/ide-cs.c
@@ -401,6 +401,8 @@ static struct pcmcia_device_id ide_ids[]
PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a, 0x3489e003),
PCMCIA_DEVICE_PROD_ID1("TRANSCEND512M ", 0xd0909443),
PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1,
0x2a54d4b1),
+ PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
0xf54a91c8),
+ PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
0x969aa4f2),
PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1,
0xf54a91c8),
PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c, 0x212bb918),
_
Is this really supposed to add a TS2GCF120 entry with the same IDs as
TS4GCF120?
And pata_pcmcia-recognize-2gb-compactflash-from-transcend.patch:
From: "Aeschbacher, Fabrice" <[EMAIL PROTECTED]>
Allow the pata_pcmcia driver to automatically detect 2GB CompactFlash cards
from Transcend.
Signed-off-by: Fabrice Aeschbacher <[EMAIL PROTECTED]>
Cc: "Peter Stuge" <[EMAIL PROTECTED]>
Acked-by: Alan Cox <[EMAIL PROTECTED]>
Cc: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/ata/pata_pcmcia.c |1 +
1 files changed, 1 insertion(+)
diff -puN
drivers/ata/pata_pcmcia.c~pata_pcmcia-recognize-2gb-compactflash-from-transcend
drivers/ata/pata_pcmcia.c
---
a/drivers/ata/pata_pcmcia.c~pata_pcmcia-recognize-2gb-compactflash-from-transcend
+++ a/drivers/ata/pata_pcmcia.c
@@ -396,6 +396,7 @@ static struct pcmcia_device_id pcmcia_de
PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a, 0x3489e003),
PCMCIA_DEVICE_PROD_ID1("TRANSCEND512M ", 0xd0909443),
PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1,
0x2a54d4b1),
+ PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
0x969aa4f2),
PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1,
0xf54a91c8),
PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c, 0x212bb918),
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
On Thu, 26 Apr 2007 11:21:01 +0200 Aeschbacher, Fabrice [EMAIL PROTECTED] wrote: As pointed to by Peter, and also as indicated by a judicious output in dmesg, the 4th parameter should be 0x969aa4f2. Please find below the corrected patch: Signed-off-by: Fabrice Aeschbacher [EMAIL PROTECTED] === --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15 21:08:02.0 +0200 +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c2007-04-26 11:13:13.0 +0200 @@ -399,6 +399,7 @@ PCMCIA_DEVICE_PROD_ID12(TOSHIBA, MK2001MPL, 0xb4585a1a, 0x3489e003), PCMCIA_DEVICE_PROD_ID1(TRANSCEND512M , 0xd0909443), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS1GCF80, 0x709b1bf1, 0x2a54d4b1), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0x969aa4f2), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS4GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(WIT, IDE16, 0x244e5994, 0x3e232852), PCMCIA_DEVICE_PROD_ID12(WEIDA, TWTTI, 0xcc7cf69c, 0x212bb918), === This one-liner is turning into a fiasco. All the top-posting and word-wrapped patches aren't helping :( I presently have two patches. Please check them. ide-cs-recognize-2gb-compactflash-from-transcend.patch: From: Aeschbacher, Fabrice [EMAIL PROTECTED] Without the following patch, the kernel does not automatically detect 2GB CompactFlash cards from Transcend. Signed-off-by: Fabrice Aeschbacher [EMAIL PROTECTED] Cc: Dominik Brodowski [EMAIL PROTECTED] Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/ide/legacy/ide-cs.c |2 ++ 1 files changed, 2 insertions(+) diff -puN drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend drivers/ide/legacy/ide-cs.c --- a/drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend +++ a/drivers/ide/legacy/ide-cs.c @@ -401,6 +401,8 @@ static struct pcmcia_device_id ide_ids[] PCMCIA_DEVICE_PROD_ID12(TOSHIBA, MK2001MPL, 0xb4585a1a, 0x3489e003), PCMCIA_DEVICE_PROD_ID1(TRANSCEND512M , 0xd0909443), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS1GCF80, 0x709b1bf1, 0x2a54d4b1), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0xf54a91c8), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0x969aa4f2), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS4GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(WIT, IDE16, 0x244e5994, 0x3e232852), PCMCIA_DEVICE_PROD_ID12(WEIDA, TWTTI, 0xcc7cf69c, 0x212bb918), _ Is this really supposed to add a TS2GCF120 entry with the same IDs as TS4GCF120? And pata_pcmcia-recognize-2gb-compactflash-from-transcend.patch: From: Aeschbacher, Fabrice [EMAIL PROTECTED] Allow the pata_pcmcia driver to automatically detect 2GB CompactFlash cards from Transcend. Signed-off-by: Fabrice Aeschbacher [EMAIL PROTECTED] Cc: Peter Stuge [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/ata/pata_pcmcia.c |1 + 1 files changed, 1 insertion(+) diff -puN drivers/ata/pata_pcmcia.c~pata_pcmcia-recognize-2gb-compactflash-from-transcend drivers/ata/pata_pcmcia.c --- a/drivers/ata/pata_pcmcia.c~pata_pcmcia-recognize-2gb-compactflash-from-transcend +++ a/drivers/ata/pata_pcmcia.c @@ -396,6 +396,7 @@ static struct pcmcia_device_id pcmcia_de PCMCIA_DEVICE_PROD_ID12(TOSHIBA, MK2001MPL, 0xb4585a1a, 0x3489e003), PCMCIA_DEVICE_PROD_ID1(TRANSCEND512M , 0xd0909443), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS1GCF80, 0x709b1bf1, 0x2a54d4b1), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0x969aa4f2), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS4GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(WIT, IDE16, 0x244e5994, 0x3e232852), PCMCIA_DEVICE_PROD_ID12(WEIDA, TWTTI, 0xcc7cf69c, 0x212bb918), _ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
On Fri, Apr 27, 2007 at 07:01:43PM -0700, Andrew Morton wrote: This one-liner is turning into a fiasco. diff -puN drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend drivers/ide/legacy/ide-cs.c --- a/drivers/ide/legacy/ide-cs.c~ide-cs-recognize-2gb-compactflash-from-transcend +++ a/drivers/ide/legacy/ide-cs.c @@ -401,6 +401,8 @@ static struct pcmcia_device_id ide_ids[] PCMCIA_DEVICE_PROD_ID12(TOSHIBA, MK2001MPL, 0xb4585a1a, 0x3489e003), PCMCIA_DEVICE_PROD_ID1(TRANSCEND512M , 0xd0909443), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS1GCF80, 0x709b1bf1, 0x2a54d4b1), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0xf54a91c8), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0x969aa4f2), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS4GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(WIT, IDE16, 0x244e5994, 0x3e232852), PCMCIA_DEVICE_PROD_ID12(WEIDA, TWTTI, 0xcc7cf69c, 0x212bb918), _ Is this really supposed to add a TS2GCF120 entry with the same IDs as TS4GCF120? That's probably a copy and paste error. 0x969aa4f2 is the correct ID. And pata_pcmcia-recognize-2gb-compactflash-from-transcend.patch: This one is all right so for what it's worth, it gets: Acked-by: Peter Stuge [EMAIL PROTECTED] //Peter - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
As pointed to by Peter, and also as indicated by a judicious output in
dmesg, the 4th parameter should be 0x969aa4f2. Please find below the
corrected patch:
Signed-off-by: Fabrice Aeschbacher <[EMAIL PROTECTED]>
===
--- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15
21:08:02.0 +0200
+++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-26
11:13:13.0 +0200
@@ -399,6 +399,7 @@
PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a,
0x3489e003),
PCMCIA_DEVICE_PROD_ID1("TRANSCEND512M ", 0xd0909443),
PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1,
0x2a54d4b1),
+ PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
0x969aa4f2),
PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1,
0xf54a91c8),
PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c,
0x212bb918),
===
> -Original Message-
> From: Andrew Morton [mailto:[EMAIL PROTECTED]
> Sent: Donnerstag, 26. April 2007 02:16
> To: Aeschbacher, Fabrice
> Cc: [EMAIL PROTECTED]; lkml; Dominik
> Brodowski; Bartlomiej Zolnierkiewicz
> Subject: Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
>
> On Wed, 25 Apr 2007 11:27:09 +0200 "Aeschbacher, Fabrice"
> <[EMAIL PROTECTED]> wrote:
>
> > Without the following patch, the kernel does not
> automatically detect
> > 2GB CompactFlash cards from Transcend.
> >
> > I'm not sure which correct values must be assigned to the
> 3th and 4th
> > parameters (here: 0x709b1bf1, 0xf54a91c8). Anyway, the patch is
> > working with these values. Tested on arch=mips.
> >
>
> Thanks. Your patch was wordwrapped and had tabs replaced by
> spaces, btw.
>
> >
> > ===
> > --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15
> > 21:08:02.0 +0200
> > +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-25
> > 10:53:53.0 +0200
> > @@ -64,6 +64,7 @@
> >
> > #define INT_MODULE_PARM(n, v) static int n = v;
> module_param(n, int,
> > 0)
> >
> > +#define PCMCIA_DEBUG 1
> > #ifdef PCMCIA_DEBUG
> > INT_MODULE_PARM(pc_debug, PCMCIA_DEBUG); #define DEBUG(n,
> args...)
> > if (pc_debug>(n)) printk(KERN_DEBUG args)
>
> I removed the above change
>
> > @@ -399,6 +400,7 @@
> > PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a,
> > 0x3489e003),
> > PCMCIA_DEVICE_PROD_ID1("TRANSCEND512M ", 0xd0909443),
> > PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80",
> 0x709b1bf1,
> > 0x2a54d4b1),
> > + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120",
> 0x709b1bf1,
> > 0xf54a91c8),
> > PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120",
> 0x709b1bf1,
> > 0xf54a91c8),
> > PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994,
> 0x3e232852),
> > PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c,
> > 0x212bb918),
>
> I'm never sure whether it's Bart or Dominik who handles
> pcmcia-cs patches.
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
As pointed to by Peter, and also as indicated by a judicious output in dmesg, the 4th parameter should be 0x969aa4f2. Please find below the corrected patch: Signed-off-by: Fabrice Aeschbacher [EMAIL PROTECTED] === --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15 21:08:02.0 +0200 +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-26 11:13:13.0 +0200 @@ -399,6 +399,7 @@ PCMCIA_DEVICE_PROD_ID12(TOSHIBA, MK2001MPL, 0xb4585a1a, 0x3489e003), PCMCIA_DEVICE_PROD_ID1(TRANSCEND512M , 0xd0909443), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS1GCF80, 0x709b1bf1, 0x2a54d4b1), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0x969aa4f2), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS4GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(WIT, IDE16, 0x244e5994, 0x3e232852), PCMCIA_DEVICE_PROD_ID12(WEIDA, TWTTI, 0xcc7cf69c, 0x212bb918), === -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Donnerstag, 26. April 2007 02:16 To: Aeschbacher, Fabrice Cc: [EMAIL PROTECTED]; lkml; Dominik Brodowski; Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend On Wed, 25 Apr 2007 11:27:09 +0200 Aeschbacher, Fabrice [EMAIL PROTECTED] wrote: Without the following patch, the kernel does not automatically detect 2GB CompactFlash cards from Transcend. I'm not sure which correct values must be assigned to the 3th and 4th parameters (here: 0x709b1bf1, 0xf54a91c8). Anyway, the patch is working with these values. Tested on arch=mips. Thanks. Your patch was wordwrapped and had tabs replaced by spaces, btw. === --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15 21:08:02.0 +0200 +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-25 10:53:53.0 +0200 @@ -64,6 +64,7 @@ #define INT_MODULE_PARM(n, v) static int n = v; module_param(n, int, 0) +#define PCMCIA_DEBUG 1 #ifdef PCMCIA_DEBUG INT_MODULE_PARM(pc_debug, PCMCIA_DEBUG); #define DEBUG(n, args...) if (pc_debug(n)) printk(KERN_DEBUG args) I removed the above change @@ -399,6 +400,7 @@ PCMCIA_DEVICE_PROD_ID12(TOSHIBA, MK2001MPL, 0xb4585a1a, 0x3489e003), PCMCIA_DEVICE_PROD_ID1(TRANSCEND512M , 0xd0909443), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS1GCF80, 0x709b1bf1, 0x2a54d4b1), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS4GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(WIT, IDE16, 0x244e5994, 0x3e232852), PCMCIA_DEVICE_PROD_ID12(WEIDA, TWTTI, 0xcc7cf69c, 0x212bb918), I'm never sure whether it's Bart or Dominik who handles pcmcia-cs patches. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
On Wed, 25 Apr 2007 11:27:09 +0200 "Aeschbacher, Fabrice" <[EMAIL PROTECTED]>
wrote:
> Without the following patch, the kernel does not automatically detect
> 2GB CompactFlash cards from Transcend.
>
> I'm not sure which correct values must be assigned to the 3th and 4th
> parameters (here: 0x709b1bf1, 0xf54a91c8). Anyway, the patch is working
> with these values. Tested on arch=mips.
>
Thanks. Your patch was wordwrapped and had tabs replaced by spaces, btw.
>
> ===
> --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15
> 21:08:02.0 +0200
> +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-25
> 10:53:53.0 +0200
> @@ -64,6 +64,7 @@
>
> #define INT_MODULE_PARM(n, v) static int n = v; module_param(n, int, 0)
>
> +#define PCMCIA_DEBUG 1
> #ifdef PCMCIA_DEBUG
> INT_MODULE_PARM(pc_debug, PCMCIA_DEBUG);
> #define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args)
I removed the above change
> @@ -399,6 +400,7 @@
> PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a,
> 0x3489e003),
> PCMCIA_DEVICE_PROD_ID1("TRANSCEND512M ", 0xd0909443),
> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1,
> 0x2a54d4b1),
> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
> 0xf54a91c8),
> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1,
> 0xf54a91c8),
> PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
> PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c,
> 0x212bb918),
I'm never sure whether it's Bart or Dominik who handles pcmcia-cs patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
On Wed, Apr 25, 2007 at 11:27:09AM +0200, Aeschbacher, Fabrice wrote:
> I'm not sure which correct values must be assigned to the 3th and
> 4th parameters (here: 0x709b1bf1, 0xf54a91c8). Anyway, the patch is
> working with these values. Tested on arch=mips.
>
> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
> 0xf54a91c8),
According to /usr/src/linux/Documentation/pcmcia/devicetable.txt and
crc32hash.c the 4th parameter should be 0x969aa4f2.
//Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
Without the following patch, the kernel does not automatically detect
2GB CompactFlash cards from Transcend.
I'm not sure which correct values must be assigned to the 3th and 4th
parameters (here: 0x709b1bf1, 0xf54a91c8). Anyway, the patch is working
with these values. Tested on arch=mips.
Signed-off-by: Fabrice Aeschbacher <[EMAIL PROTECTED]>
===
--- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15
21:08:02.0 +0200
+++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-25
10:53:53.0 +0200
@@ -64,6 +64,7 @@
#define INT_MODULE_PARM(n, v) static int n = v; module_param(n, int, 0)
+#define PCMCIA_DEBUG 1
#ifdef PCMCIA_DEBUG
INT_MODULE_PARM(pc_debug, PCMCIA_DEBUG);
#define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args)
@@ -399,6 +400,7 @@
PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a,
0x3489e003),
PCMCIA_DEVICE_PROD_ID1("TRANSCEND512M ", 0xd0909443),
PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1,
0x2a54d4b1),
+ PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
0xf54a91c8),
PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1,
0xf54a91c8),
PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c,
0x212bb918),
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
Without the following patch, the kernel does not automatically detect 2GB CompactFlash cards from Transcend. I'm not sure which correct values must be assigned to the 3th and 4th parameters (here: 0x709b1bf1, 0xf54a91c8). Anyway, the patch is working with these values. Tested on arch=mips. Signed-off-by: Fabrice Aeschbacher [EMAIL PROTECTED] === --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15 21:08:02.0 +0200 +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-25 10:53:53.0 +0200 @@ -64,6 +64,7 @@ #define INT_MODULE_PARM(n, v) static int n = v; module_param(n, int, 0) +#define PCMCIA_DEBUG 1 #ifdef PCMCIA_DEBUG INT_MODULE_PARM(pc_debug, PCMCIA_DEBUG); #define DEBUG(n, args...) if (pc_debug(n)) printk(KERN_DEBUG args) @@ -399,6 +400,7 @@ PCMCIA_DEVICE_PROD_ID12(TOSHIBA, MK2001MPL, 0xb4585a1a, 0x3489e003), PCMCIA_DEVICE_PROD_ID1(TRANSCEND512M , 0xd0909443), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS1GCF80, 0x709b1bf1, 0x2a54d4b1), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS4GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(WIT, IDE16, 0x244e5994, 0x3e232852), PCMCIA_DEVICE_PROD_ID12(WEIDA, TWTTI, 0xcc7cf69c, 0x212bb918), - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
On Wed, Apr 25, 2007 at 11:27:09AM +0200, Aeschbacher, Fabrice wrote: I'm not sure which correct values must be assigned to the 3th and 4th parameters (here: 0x709b1bf1, 0xf54a91c8). Anyway, the patch is working with these values. Tested on arch=mips. + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0xf54a91c8), According to /usr/src/linux/Documentation/pcmcia/devicetable.txt and crc32hash.c the 4th parameter should be 0x969aa4f2. //Peter - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
On Wed, 25 Apr 2007 11:27:09 +0200 Aeschbacher, Fabrice [EMAIL PROTECTED] wrote: Without the following patch, the kernel does not automatically detect 2GB CompactFlash cards from Transcend. I'm not sure which correct values must be assigned to the 3th and 4th parameters (here: 0x709b1bf1, 0xf54a91c8). Anyway, the patch is working with these values. Tested on arch=mips. Thanks. Your patch was wordwrapped and had tabs replaced by spaces, btw. === --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15 21:08:02.0 +0200 +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-25 10:53:53.0 +0200 @@ -64,6 +64,7 @@ #define INT_MODULE_PARM(n, v) static int n = v; module_param(n, int, 0) +#define PCMCIA_DEBUG 1 #ifdef PCMCIA_DEBUG INT_MODULE_PARM(pc_debug, PCMCIA_DEBUG); #define DEBUG(n, args...) if (pc_debug(n)) printk(KERN_DEBUG args) I removed the above change @@ -399,6 +400,7 @@ PCMCIA_DEVICE_PROD_ID12(TOSHIBA, MK2001MPL, 0xb4585a1a, 0x3489e003), PCMCIA_DEVICE_PROD_ID1(TRANSCEND512M , 0xd0909443), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS1GCF80, 0x709b1bf1, 0x2a54d4b1), + PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS2GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(TRANSCEND, TS4GCF120, 0x709b1bf1, 0xf54a91c8), PCMCIA_DEVICE_PROD_ID12(WIT, IDE16, 0x244e5994, 0x3e232852), PCMCIA_DEVICE_PROD_ID12(WEIDA, TWTTI, 0xcc7cf69c, 0x212bb918), I'm never sure whether it's Bart or Dominik who handles pcmcia-cs patches. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
