Re: [PATCH] infiniband: remove redundant condition check before debugfs_remove

2018-09-11 Thread Jason Gunthorpe 
On Sat, Sep 08, 2018 at 09:49:31PM +0800, zhong jiang wrote:
> debugfs_remove has taken the IS_ERR_OR_NULL into account. Just
> remove the unnecessary condition.
> 
> Signed-off-by: zhong jiang 
> ---
>  drivers/infiniband/hw/usnic/usnic_debugfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied to for-next, thanks

Jason

Re: [PATCH] infiniband: remove redundant condition check before debugfs_remove

2018-09-11 Thread Jason Gunthorpe 
On Sat, Sep 08, 2018 at 09:49:31PM +0800, zhong jiang wrote:
> debugfs_remove has taken the IS_ERR_OR_NULL into account. Just
> remove the unnecessary condition.
> 
> Signed-off-by: zhong jiang 
> ---
>  drivers/infiniband/hw/usnic/usnic_debugfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied to for-next, thanks

Jason

[PATCH] infiniband: remove redundant condition check before debugfs_remove

2018-09-08 Thread zhong jiang 
debugfs_remove has taken the IS_ERR_OR_NULL into account. Just
remove the unnecessary condition.

Signed-off-by: zhong jiang 
---
 drivers/infiniband/hw/usnic/usnic_debugfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/usnic/usnic_debugfs.c 
b/drivers/infiniband/hw/usnic/usnic_debugfs.c
index 92dc66c..a311570 100644
--- a/drivers/infiniband/hw/usnic/usnic_debugfs.c
+++ b/drivers/infiniband/hw/usnic/usnic_debugfs.c
@@ -165,6 +165,5 @@ void usnic_debugfs_flow_add(struct usnic_ib_qp_grp_flow 
*qp_flow)
 
 void usnic_debugfs_flow_remove(struct usnic_ib_qp_grp_flow *qp_flow)
 {
-   if (!IS_ERR_OR_NULL(qp_flow->dbgfs_dentry))
-   debugfs_remove(qp_flow->dbgfs_dentry);
+   debugfs_remove(qp_flow->dbgfs_dentry);
 }
-- 
1.7.12.4

[PATCH] infiniband: remove redundant condition check before debugfs_remove

2018-09-08 Thread zhong jiang 
debugfs_remove has taken the IS_ERR_OR_NULL into account. Just
remove the unnecessary condition.

Signed-off-by: zhong jiang 
---
 drivers/infiniband/hw/usnic/usnic_debugfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/usnic/usnic_debugfs.c 
b/drivers/infiniband/hw/usnic/usnic_debugfs.c
index 92dc66c..a311570 100644
--- a/drivers/infiniband/hw/usnic/usnic_debugfs.c
+++ b/drivers/infiniband/hw/usnic/usnic_debugfs.c
@@ -165,6 +165,5 @@ void usnic_debugfs_flow_add(struct usnic_ib_qp_grp_flow 
*qp_flow)
 
 void usnic_debugfs_flow_remove(struct usnic_ib_qp_grp_flow *qp_flow)
 {
-   if (!IS_ERR_OR_NULL(qp_flow->dbgfs_dentry))
-   debugfs_remove(qp_flow->dbgfs_dentry);
+   debugfs_remove(qp_flow->dbgfs_dentry);
 }
-- 
1.7.12.4