Re: [PATCH] init: print warning message if /dev/console failed to open

2016-02-03 Thread Peter Hurley 
Hi Alexander,

On 02/03/2016 10:58 AM, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov 
> ---
>  init/do_mounts.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index dea5de9..ca5da05 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
>   termios.c_lflag |= ICANON;
>   sys_ioctl(fd, TCSETSF, (long));
>   sys_close(fd);
> - }
> + } else
> + pr_err("Warning: unable to open /dev/console.\n");

I think you should include the -fd error code as well.

Is this failure new?


Regards,
Peter Hurley

> +
>  }
>  #endif
>  
>

Re: [PATCH] init: print warning message if /dev/console failed to open

2016-02-03 Thread Pranith Kumar 
Hello Alexander,

On Wed, Feb 3, 2016 at 1:58 PM, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov 

Please describe the changes in each patch. Why do you need this warning?

If you haven't read it yet, please read (esp. Section 2):
https://www.kernel.org/doc/Documentation/SubmittingPatches

> ---
>  init/do_mounts.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index dea5de9..ca5da05 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
> termios.c_lflag |= ICANON;
> sys_ioctl(fd, TCSETSF, (long));
> sys_close(fd);
> -   }
> +   } else
> +   pr_err("Warning: unable to open /dev/console.\n");

Your message says 'Warning'. But you use pr_err(). I think pr_warn()
might be a better option.

> +
>  }
>  #endif
>
> --
> 2.7.0.25.gfc10eb5
>


Thanks,
-- 
Pranith

[PATCH] init: print warning message if /dev/console failed to open

2016-02-03 Thread Alexander Kuleshov 
Signed-off-by: Alexander Kuleshov 
---
 init/do_mounts.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/init/do_mounts.c b/init/do_mounts.c
index dea5de9..ca5da05 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
termios.c_lflag |= ICANON;
sys_ioctl(fd, TCSETSF, (long));
sys_close(fd);
-   }
+   } else
+   pr_err("Warning: unable to open /dev/console.\n");
+
 }
 #endif
 
-- 
2.7.0.25.gfc10eb5

Re: [PATCH] init: print warning message if /dev/console failed to open

2016-02-03 Thread Peter Hurley 
Hi Alexander,

On 02/03/2016 10:58 AM, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov 
> ---
>  init/do_mounts.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index dea5de9..ca5da05 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
>   termios.c_lflag |= ICANON;
>   sys_ioctl(fd, TCSETSF, (long));
>   sys_close(fd);
> - }
> + } else
> + pr_err("Warning: unable to open /dev/console.\n");

I think you should include the -fd error code as well.

Is this failure new?


Regards,
Peter Hurley

> +
>  }
>  #endif
>  
>

[PATCH] init: print warning message if /dev/console failed to open

2016-02-03 Thread Alexander Kuleshov 
Signed-off-by: Alexander Kuleshov 
---
 init/do_mounts.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/init/do_mounts.c b/init/do_mounts.c
index dea5de9..ca5da05 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
termios.c_lflag |= ICANON;
sys_ioctl(fd, TCSETSF, (long));
sys_close(fd);
-   }
+   } else
+   pr_err("Warning: unable to open /dev/console.\n");
+
 }
 #endif
 
-- 
2.7.0.25.gfc10eb5

Re: [PATCH] init: print warning message if /dev/console failed to open

2016-02-03 Thread Pranith Kumar 
Hello Alexander,

On Wed, Feb 3, 2016 at 1:58 PM, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov 

Please describe the changes in each patch. Why do you need this warning?

If you haven't read it yet, please read (esp. Section 2):
https://www.kernel.org/doc/Documentation/SubmittingPatches

> ---
>  init/do_mounts.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index dea5de9..ca5da05 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
> termios.c_lflag |= ICANON;
> sys_ioctl(fd, TCSETSF, (long));
> sys_close(fd);
> -   }
> +   } else
> +   pr_err("Warning: unable to open /dev/console.\n");

Your message says 'Warning'. But you use pr_err(). I think pr_warn()
might be a better option.

> +
>  }
>  #endif
>
> --
> 2.7.0.25.gfc10eb5
>


Thanks,
-- 
Pranith