Re: [PATCH] ipc/mqueue: use unsigned int for retval

[Waiman Long]

On 02/10/2017 02:36 AM, Nicholas Mc Guire wrote:
> The retval variable is assigned by bitops only and thus there is no
> reason to use a signed type. Further matching it with the return 
> type of the function also makes static code checkers happy.
>
> Signed-off-by: Nicholas Mc Guire 
> ---
>
> Found by experimental type-checking coccinelle script
>
> Patch was compile tested with: x86_64_defconfig
>
> Patch is against 4.10-rc6 (localversion-next is next-20170209)
>
>  ipc/mqueue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 4fdd970..897ce70 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -519,7 +519,7 @@ static int mqueue_flush_file(struct file *filp, 
> fl_owner_t id)
>  static unsigned int mqueue_poll_file(struct file *filp, struct 
> poll_table_struct *poll_tab)
>  {
>   struct mqueue_inode_info *info = MQUEUE_I(file_inode(filp));
> - int retval = 0;
> + unsigned int retval = 0;
>  
>   poll_wait(filp, >wait_q, poll_tab);
>  

Acked-by: Waiman Long 

Re: [PATCH] ipc/mqueue: use unsigned int for retval

[Waiman Long]

On 02/10/2017 02:36 AM, Nicholas Mc Guire wrote:
> The retval variable is assigned by bitops only and thus there is no
> reason to use a signed type. Further matching it with the return 
> type of the function also makes static code checkers happy.
>
> Signed-off-by: Nicholas Mc Guire 
> ---
>
> Found by experimental type-checking coccinelle script
>
> Patch was compile tested with: x86_64_defconfig
>
> Patch is against 4.10-rc6 (localversion-next is next-20170209)
>
>  ipc/mqueue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 4fdd970..897ce70 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -519,7 +519,7 @@ static int mqueue_flush_file(struct file *filp, 
> fl_owner_t id)
>  static unsigned int mqueue_poll_file(struct file *filp, struct 
> poll_table_struct *poll_tab)
>  {
>   struct mqueue_inode_info *info = MQUEUE_I(file_inode(filp));
> - int retval = 0;
> + unsigned int retval = 0;
>  
>   poll_wait(filp, >wait_q, poll_tab);
>  

Acked-by: Waiman Long 

[PATCH] ipc/mqueue: use unsigned int for retval

[Nicholas Mc Guire]

The retval variable is assigned by bitops only and thus there is no
reason to use a signed type. Further matching it with the return 
type of the function also makes static code checkers happy.

Signed-off-by: Nicholas Mc Guire 
---

Found by experimental type-checking coccinelle script

Patch was compile tested with: x86_64_defconfig

Patch is against 4.10-rc6 (localversion-next is next-20170209)

 ipc/mqueue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 4fdd970..897ce70 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -519,7 +519,7 @@ static int mqueue_flush_file(struct file *filp, fl_owner_t 
id)
 static unsigned int mqueue_poll_file(struct file *filp, struct 
poll_table_struct *poll_tab)
 {
struct mqueue_inode_info *info = MQUEUE_I(file_inode(filp));
-   int retval = 0;
+   unsigned int retval = 0;
 
poll_wait(filp, >wait_q, poll_tab);
 
-- 
2.1.4

[PATCH] ipc/mqueue: use unsigned int for retval

[Nicholas Mc Guire]

The retval variable is assigned by bitops only and thus there is no
reason to use a signed type. Further matching it with the return 
type of the function also makes static code checkers happy.

Signed-off-by: Nicholas Mc Guire 
---

Found by experimental type-checking coccinelle script

Patch was compile tested with: x86_64_defconfig

Patch is against 4.10-rc6 (localversion-next is next-20170209)

 ipc/mqueue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 4fdd970..897ce70 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -519,7 +519,7 @@ static int mqueue_flush_file(struct file *filp, fl_owner_t 
id)
 static unsigned int mqueue_poll_file(struct file *filp, struct 
poll_table_struct *poll_tab)
 {
struct mqueue_inode_info *info = MQUEUE_I(file_inode(filp));
-   int retval = 0;
+   unsigned int retval = 0;
 
poll_wait(filp, >wait_q, poll_tab);
 
-- 
2.1.4