Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask
Hi Marc, On 26.06.2018 17:56, Marc Zyngier wrote: > On Tue, 26 Jun 2018 15:37:12 +0100, > Laurentiu Tudor wrote: >> >> Update the effective affinity mask to fix this warning issued by the >> generic irq handling code: >> >> "genirq: irq_chip MSI did not update eff. affinity mask of irq x" >> >> Signed-off-by: Laurentiu Tudor >> --- >> drivers/irqchip/irq-ls-scfg-msi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/irqchip/irq-ls-scfg-msi.c >> b/drivers/irqchip/irq-ls-scfg-msi.c >> index 1ec3bfe56693..d81d5b016438 100644 >> --- a/drivers/irqchip/irq-ls-scfg-msi.c >> +++ b/drivers/irqchip/irq-ls-scfg-msi.c >> @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data >> *irq_data, >> } >> >> cpumask_copy(irq_data->common->affinity, mask); >> +irq_data_update_effective_affinity(irq_data, mask); >> >> return IRQ_SET_MASK_OK; >> } > > It has already been addressed here: > Thanks for the obviously much better & complete fix. Will take care to keep my local repo more up-to-date. --- Best Regards, Laurentiu
Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask
Hi Marc, On 26.06.2018 17:56, Marc Zyngier wrote: > On Tue, 26 Jun 2018 15:37:12 +0100, > Laurentiu Tudor wrote: >> >> Update the effective affinity mask to fix this warning issued by the >> generic irq handling code: >> >> "genirq: irq_chip MSI did not update eff. affinity mask of irq x" >> >> Signed-off-by: Laurentiu Tudor >> --- >> drivers/irqchip/irq-ls-scfg-msi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/irqchip/irq-ls-scfg-msi.c >> b/drivers/irqchip/irq-ls-scfg-msi.c >> index 1ec3bfe56693..d81d5b016438 100644 >> --- a/drivers/irqchip/irq-ls-scfg-msi.c >> +++ b/drivers/irqchip/irq-ls-scfg-msi.c >> @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data >> *irq_data, >> } >> >> cpumask_copy(irq_data->common->affinity, mask); >> +irq_data_update_effective_affinity(irq_data, mask); >> >> return IRQ_SET_MASK_OK; >> } > > It has already been addressed here: > Thanks for the obviously much better & complete fix. Will take care to keep my local repo more up-to-date. --- Best Regards, Laurentiu
Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask
On Tue, 26 Jun 2018 15:37:12 +0100, Laurentiu Tudor wrote: > > Update the effective affinity mask to fix this warning issued by the > generic irq handling code: > > "genirq: irq_chip MSI did not update eff. affinity mask of irq x" > > Signed-off-by: Laurentiu Tudor > --- > drivers/irqchip/irq-ls-scfg-msi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-ls-scfg-msi.c > b/drivers/irqchip/irq-ls-scfg-msi.c > index 1ec3bfe56693..d81d5b016438 100644 > --- a/drivers/irqchip/irq-ls-scfg-msi.c > +++ b/drivers/irqchip/irq-ls-scfg-msi.c > @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data > *irq_data, > } > > cpumask_copy(irq_data->common->affinity, mask); > + irq_data_update_effective_affinity(irq_data, mask); > > return IRQ_SET_MASK_OK; > } It has already been addressed here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=893fbfff976cd069f2e60c3b186dbe3f85504db2 Thanks, M. -- Jazz is not dead, it just smell funny.
Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask
On Tue, 26 Jun 2018 15:37:12 +0100, Laurentiu Tudor wrote: > > Update the effective affinity mask to fix this warning issued by the > generic irq handling code: > > "genirq: irq_chip MSI did not update eff. affinity mask of irq x" > > Signed-off-by: Laurentiu Tudor > --- > drivers/irqchip/irq-ls-scfg-msi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-ls-scfg-msi.c > b/drivers/irqchip/irq-ls-scfg-msi.c > index 1ec3bfe56693..d81d5b016438 100644 > --- a/drivers/irqchip/irq-ls-scfg-msi.c > +++ b/drivers/irqchip/irq-ls-scfg-msi.c > @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data > *irq_data, > } > > cpumask_copy(irq_data->common->affinity, mask); > + irq_data_update_effective_affinity(irq_data, mask); > > return IRQ_SET_MASK_OK; > } It has already been addressed here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=893fbfff976cd069f2e60c3b186dbe3f85504db2 Thanks, M. -- Jazz is not dead, it just smell funny.
[PATCH] irqchip/ls-scfg-msi: update effective affinity mask
Update the effective affinity mask to fix this warning issued by the generic irq handling code: "genirq: irq_chip MSI did not update eff. affinity mask of irq x" Signed-off-by: Laurentiu Tudor --- drivers/irqchip/irq-ls-scfg-msi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c index 1ec3bfe56693..d81d5b016438 100644 --- a/drivers/irqchip/irq-ls-scfg-msi.c +++ b/drivers/irqchip/irq-ls-scfg-msi.c @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data *irq_data, } cpumask_copy(irq_data->common->affinity, mask); + irq_data_update_effective_affinity(irq_data, mask); return IRQ_SET_MASK_OK; } -- 2.17.1
[PATCH] irqchip/ls-scfg-msi: update effective affinity mask
Update the effective affinity mask to fix this warning issued by the generic irq handling code: "genirq: irq_chip MSI did not update eff. affinity mask of irq x" Signed-off-by: Laurentiu Tudor --- drivers/irqchip/irq-ls-scfg-msi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c index 1ec3bfe56693..d81d5b016438 100644 --- a/drivers/irqchip/irq-ls-scfg-msi.c +++ b/drivers/irqchip/irq-ls-scfg-msi.c @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data *irq_data, } cpumask_copy(irq_data->common->affinity, mask); + irq_data_update_effective_affinity(irq_data, mask); return IRQ_SET_MASK_OK; } -- 2.17.1
