Re: [PATCH] irqdomain: remove the confused log
On Wed, 26 Aug 2015, Huang Shijie wrote: > On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote: > > On Tue, 25 Aug 2015, Huang Shijie wrote: > > > > > When the dynamic debug is enabled for irq domain, the kernel will print > > > out: > > > -- > > > irqdomain:__irq_domain_add: irq: Added domain (null) > > > -- > > > > > > It does not print out the irq domain's name, since the @domain->name is > > > NULL. > > > Keep the log here just makes people nervous. > > > > Well, it might be NULL in your case, but there are enough cases where > > its not NULL and the output valuable. > In which case ? > > The domain is allocated by kzalloc_node(), so @domain->name is NULL in the > function. > The @domain->name is set in other function, such as irq_domain_associate(). Indeed. I misread the patch, sorry. Yes that thing can go. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] irqdomain: remove the confused log
On Wed, 26 Aug 2015, Huang Shijie wrote: On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote: On Tue, 25 Aug 2015, Huang Shijie wrote: When the dynamic debug is enabled for irq domain, the kernel will print out: -- irqdomain:__irq_domain_add: irq: Added domain (null) -- It does not print out the irq domain's name, since the @domain-name is NULL. Keep the log here just makes people nervous. Well, it might be NULL in your case, but there are enough cases where its not NULL and the output valuable. In which case ? The domain is allocated by kzalloc_node(), so @domain-name is NULL in the function. The @domain-name is set in other function, such as irq_domain_associate(). Indeed. I misread the patch, sorry. Yes that thing can go. Thanks, tglx -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] irqdomain: remove the confused log
On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote: > On Tue, 25 Aug 2015, Huang Shijie wrote: > > > When the dynamic debug is enabled for irq domain, the kernel will print out: > > -- > > irqdomain:__irq_domain_add: irq: Added domain (null) > > -- > > > > It does not print out the irq domain's name, since the @domain->name is > > NULL. > > Keep the log here just makes people nervous. > > Well, it might be NULL in your case, but there are enough cases where > its not NULL and the output valuable. In which case ? The domain is allocated by kzalloc_node(), so @domain->name is NULL in the function. The @domain->name is set in other function, such as irq_domain_associate(). > > > Aside of that I don't understand what's making one nervous > here. People who enable that debug stuff should know that this can be > NULL and just deal with it. If they get nervous about it they probably > should not try to debug that code in the first place. okay. thanks Huang Shijie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] irqdomain: remove the confused log
On Tue, 25 Aug 2015, Huang Shijie wrote: > When the dynamic debug is enabled for irq domain, the kernel will print out: > -- > irqdomain:__irq_domain_add: irq: Added domain (null) > -- > > It does not print out the irq domain's name, since the @domain->name is NULL. > Keep the log here just makes people nervous. Well, it might be NULL in your case, but there are enough cases where its not NULL and the output valuable. Aside of that I don't understand what's making one nervous here. People who enable that debug stuff should know that this can be NULL and just deal with it. If they get nervous about it they probably should not try to debug that code in the first place. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] irqdomain: remove the confused log
When the dynamic debug is enabled for irq domain, the kernel will print out:
--
irqdomain:__irq_domain_add: irq: Added domain (null)
--
It does not print out the irq domain's name, since the @domain->name is NULL.
Keep the log here just makes people nervous.
Signed-off-by: Huang Shijie
---
kernel/irq/irqdomain.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 79baaf8..8c582de 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -66,7 +66,6 @@ struct irq_domain *__irq_domain_add(struct device_node
*of_node, int size,
list_add(>link, _domain_list);
mutex_unlock(_domain_mutex);
- pr_debug("Added domain %s\n", domain->name);
return domain;
}
EXPORT_SYMBOL_GPL(__irq_domain_add);
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] irqdomain: remove the confused log
When the dynamic debug is enabled for irq domain, the kernel will print out: -- irqdomain:__irq_domain_add: irq: Added domain (null) -- It does not print out the irq domain's name, since the @domain-name is NULL. Keep the log here just makes people nervous. Signed-off-by: Huang Shijie shijie.hu...@arm.com --- kernel/irq/irqdomain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 79baaf8..8c582de 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -66,7 +66,6 @@ struct irq_domain *__irq_domain_add(struct device_node *of_node, int size, list_add(domain-link, irq_domain_list); mutex_unlock(irq_domain_mutex); - pr_debug(Added domain %s\n, domain-name); return domain; } EXPORT_SYMBOL_GPL(__irq_domain_add); -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] irqdomain: remove the confused log
On Tue, 25 Aug 2015, Huang Shijie wrote: When the dynamic debug is enabled for irq domain, the kernel will print out: -- irqdomain:__irq_domain_add: irq: Added domain (null) -- It does not print out the irq domain's name, since the @domain-name is NULL. Keep the log here just makes people nervous. Well, it might be NULL in your case, but there are enough cases where its not NULL and the output valuable. Aside of that I don't understand what's making one nervous here. People who enable that debug stuff should know that this can be NULL and just deal with it. If they get nervous about it they probably should not try to debug that code in the first place. Thanks, tglx -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] irqdomain: remove the confused log
On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote: On Tue, 25 Aug 2015, Huang Shijie wrote: When the dynamic debug is enabled for irq domain, the kernel will print out: -- irqdomain:__irq_domain_add: irq: Added domain (null) -- It does not print out the irq domain's name, since the @domain-name is NULL. Keep the log here just makes people nervous. Well, it might be NULL in your case, but there are enough cases where its not NULL and the output valuable. In which case ? The domain is allocated by kzalloc_node(), so @domain-name is NULL in the function. The @domain-name is set in other function, such as irq_domain_associate(). Aside of that I don't understand what's making one nervous here. People who enable that debug stuff should know that this can be NULL and just deal with it. If they get nervous about it they probably should not try to debug that code in the first place. okay. thanks Huang Shijie -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
