Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage
On Fri, 2012-07-27 at 09:45 -0600, Tim Gardner wrote: > On 07/26/2012 04:21 PM, Andy Walls wrote: > > On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: > >> Cc: Andy Walls > >> Cc: Mauro Carvalho Chehab > >> Cc: ivtv-de...@ivtvdriver.org > >> Cc: linux-me...@vger.kernel.org > >> Signed-off-by: Tim Gardner > >> --- > >> drivers/media/video/ivtv/ivtv-firmware.c |4 > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c > >> b/drivers/media/video/ivtv/ivtv-firmware.c > >> index 02c5ade..6ec7705 100644 > >> --- a/drivers/media/video/ivtv/ivtv-firmware.c > >> +++ b/drivers/media/video/ivtv/ivtv-firmware.c > >> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) > >> > >>return res; > >> } > >> + > >> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); > >> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); > >> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); > > > > Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the > > CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even > > in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME > > file is non-fatal.) > > > > I would not want anything in user-space or kernel space preventing the > > ivtv module from loading, if some of those files don't exist. > > > > Regards, > > Andy > > > > MODULE_FIRMWARE is informational only and has no runtime impact. OK. Acked-by: Andy Walls Regards, Andy > > rtg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage
On Fri, 2012-07-27 at 09:45 -0600, Tim Gardner wrote: On 07/26/2012 04:21 PM, Andy Walls wrote: On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: Cc: Andy Walls awa...@md.metrocast.net Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: ivtv-de...@ivtvdriver.org Cc: linux-me...@vger.kernel.org Signed-off-by: Tim Gardner tim.gard...@canonical.com --- drivers/media/video/ivtv/ivtv-firmware.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c index 02c5ade..6ec7705 100644 --- a/drivers/media/video/ivtv/ivtv-firmware.c +++ b/drivers/media/video/ivtv/ivtv-firmware.c @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) return res; } + +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME file is non-fatal.) I would not want anything in user-space or kernel space preventing the ivtv module from loading, if some of those files don't exist. Regards, Andy MODULE_FIRMWARE is informational only and has no runtime impact. OK. Acked-by: Andy Walls awa...@md.metrocast.net Regards, Andy rtg -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage
On 07/26/2012 04:21 PM, Andy Walls wrote: > On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: >> Cc: Andy Walls >> Cc: Mauro Carvalho Chehab >> Cc: ivtv-de...@ivtvdriver.org >> Cc: linux-me...@vger.kernel.org >> Signed-off-by: Tim Gardner >> --- >> drivers/media/video/ivtv/ivtv-firmware.c |4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c >> b/drivers/media/video/ivtv/ivtv-firmware.c >> index 02c5ade..6ec7705 100644 >> --- a/drivers/media/video/ivtv/ivtv-firmware.c >> +++ b/drivers/media/video/ivtv/ivtv-firmware.c >> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) >> >> return res; >> } >> + >> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); >> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); >> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); > > Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the > CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even > in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME > file is non-fatal.) > > I would not want anything in user-space or kernel space preventing the > ivtv module from loading, if some of those files don't exist. > > Regards, > Andy > MODULE_FIRMWARE is informational only and has no runtime impact. rtg -- Tim Gardner tim.gard...@canonical.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage
On 07/26/2012 04:21 PM, Andy Walls wrote: On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: Cc: Andy Walls awa...@md.metrocast.net Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: ivtv-de...@ivtvdriver.org Cc: linux-me...@vger.kernel.org Signed-off-by: Tim Gardner tim.gard...@canonical.com --- drivers/media/video/ivtv/ivtv-firmware.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c index 02c5ade..6ec7705 100644 --- a/drivers/media/video/ivtv/ivtv-firmware.c +++ b/drivers/media/video/ivtv/ivtv-firmware.c @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) return res; } + +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME file is non-fatal.) I would not want anything in user-space or kernel space preventing the ivtv module from loading, if some of those files don't exist. Regards, Andy MODULE_FIRMWARE is informational only and has no runtime impact. rtg -- Tim Gardner tim.gard...@canonical.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage
On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: ivtv-de...@ivtvdriver.org > Cc: linux-me...@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/media/video/ivtv/ivtv-firmware.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/video/ivtv/ivtv-firmware.c > b/drivers/media/video/ivtv/ivtv-firmware.c > index 02c5ade..6ec7705 100644 > --- a/drivers/media/video/ivtv/ivtv-firmware.c > +++ b/drivers/media/video/ivtv/ivtv-firmware.c > @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) > > return res; > } > + > +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); > +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); > +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME file is non-fatal.) I would not want anything in user-space or kernel space preventing the ivtv module from loading, if some of those files don't exist. Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ivtv: Declare MODULE_FIRMWARE usage
Cc: Andy Walls Cc: Mauro Carvalho Chehab Cc: ivtv-de...@ivtvdriver.org Cc: linux-me...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/media/video/ivtv/ivtv-firmware.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c index 02c5ade..6ec7705 100644 --- a/drivers/media/video/ivtv/ivtv-firmware.c +++ b/drivers/media/video/ivtv/ivtv-firmware.c @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) return res; } + +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ivtv: Declare MODULE_FIRMWARE usage
Cc: Andy Walls awa...@md.metrocast.net Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: ivtv-de...@ivtvdriver.org Cc: linux-me...@vger.kernel.org Signed-off-by: Tim Gardner tim.gard...@canonical.com --- drivers/media/video/ivtv/ivtv-firmware.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c index 02c5ade..6ec7705 100644 --- a/drivers/media/video/ivtv/ivtv-firmware.c +++ b/drivers/media/video/ivtv/ivtv-firmware.c @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) return res; } + +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage
On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: Cc: Andy Walls awa...@md.metrocast.net Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: ivtv-de...@ivtvdriver.org Cc: linux-me...@vger.kernel.org Signed-off-by: Tim Gardner tim.gard...@canonical.com --- drivers/media/video/ivtv/ivtv-firmware.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c index 02c5ade..6ec7705 100644 --- a/drivers/media/video/ivtv/ivtv-firmware.c +++ b/drivers/media/video/ivtv/ivtv-firmware.c @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) return res; } + +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME file is non-fatal.) I would not want anything in user-space or kernel space preventing the ivtv module from loading, if some of those files don't exist. Regards, Andy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
