[PATCH] ix86/entry: add instruction suffix
Omitting suffixes from instructions in AT mode is bad practice when operand size cannot be determined by the assembler from register operands, and is likely going to be warned about by upstream gas in the future (mine does already). Add the single missing suffix here. Signed-off-by: Jan Beulich --- arch/x86/entry/entry_32.S |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 4.18-rc2/arch/x86/entry/entry_32.S +++ 4.18-rc2-ix86-entry-insn-suffix/arch/x86/entry/entry_32.S @@ -477,7 +477,7 @@ ENTRY(entry_SYSENTER_32) * whereas POPF does not.) */ addl$PT_EFLAGS-PT_DS, %esp /* point esp at pt_regs->flags */ - btr $X86_EFLAGS_IF_BIT, (%esp) + btrl$X86_EFLAGS_IF_BIT, (%esp) popfl /*
[PATCH] ix86/entry: add instruction suffix
Omitting suffixes from instructions in AT mode is bad practice when operand size cannot be determined by the assembler from register operands, and is likely going to be warned about by upstream gas in the future (mine does already). Add the single missing suffix here. Signed-off-by: Jan Beulich --- arch/x86/entry/entry_32.S |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 4.18-rc2/arch/x86/entry/entry_32.S +++ 4.18-rc2-ix86-entry-insn-suffix/arch/x86/entry/entry_32.S @@ -477,7 +477,7 @@ ENTRY(entry_SYSENTER_32) * whereas POPF does not.) */ addl$PT_EFLAGS-PT_DS, %esp /* point esp at pt_regs->flags */ - btr $X86_EFLAGS_IF_BIT, (%esp) + btrl$X86_EFLAGS_IF_BIT, (%esp) popfl /*
