Re: [PATCH] jfs: Simplify code

[Dave Kleikamp]

On 09/03/2016 12:35 AM, Christophe JAILLET wrote:
> Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to
> 'list_splice_init'.

Looks good. I'll push this upstream.

> 
> This has been spotted with the following coccinelle script:
> /
> @@
> expression y,z;
> @@
> 
> -   list_splice(y,z);
> -   INIT_LIST_HEAD(y);
> +   list_splice_init(y,z);
> 
> Signed-off-by: Christophe JAILLET 
Signed-off-by: Dave Kleikamp 

> ---
>  fs/jfs/jfs_txnmgr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
> index 2e58978d6f45..4d973524c887 100644
> --- a/fs/jfs/jfs_txnmgr.c
> +++ b/fs/jfs/jfs_txnmgr.c
> @@ -2893,8 +2893,7 @@ restart:
>* on anon_list2.  Let's check.
>*/
>   if (!list_empty(_list2)) {
> - list_splice(_list2, _list);
> - INIT_LIST_HEAD(_list2);
> + list_splice_init(_list2, _list);
>   goto restart;
>   }
>   TXN_UNLOCK();
> 

Re: [PATCH] jfs: Simplify code

[Dave Kleikamp]

On 09/03/2016 12:35 AM, Christophe JAILLET wrote:
> Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to
> 'list_splice_init'.

Looks good. I'll push this upstream.

> 
> This has been spotted with the following coccinelle script:
> /
> @@
> expression y,z;
> @@
> 
> -   list_splice(y,z);
> -   INIT_LIST_HEAD(y);
> +   list_splice_init(y,z);
> 
> Signed-off-by: Christophe JAILLET 
Signed-off-by: Dave Kleikamp 

> ---
>  fs/jfs/jfs_txnmgr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
> index 2e58978d6f45..4d973524c887 100644
> --- a/fs/jfs/jfs_txnmgr.c
> +++ b/fs/jfs/jfs_txnmgr.c
> @@ -2893,8 +2893,7 @@ restart:
>* on anon_list2.  Let's check.
>*/
>   if (!list_empty(_list2)) {
> - list_splice(_list2, _list);
> - INIT_LIST_HEAD(_list2);
> + list_splice_init(_list2, _list);
>   goto restart;
>   }
>   TXN_UNLOCK();
> 

[PATCH] jfs: Simplify code

[Christophe JAILLET]

Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to
'list_splice_init'.

This has been spotted with the following coccinelle script:
/
@@
expression y,z;
@@

-   list_splice(y,z);
-   INIT_LIST_HEAD(y);
+   list_splice_init(y,z);

Signed-off-by: Christophe JAILLET 
---
 fs/jfs/jfs_txnmgr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
index 2e58978d6f45..4d973524c887 100644
--- a/fs/jfs/jfs_txnmgr.c
+++ b/fs/jfs/jfs_txnmgr.c
@@ -2893,8 +2893,7 @@ restart:
 * on anon_list2.  Let's check.
 */
if (!list_empty(_list2)) {
-   list_splice(_list2, _list);
-   INIT_LIST_HEAD(_list2);
+   list_splice_init(_list2, _list);
goto restart;
}
TXN_UNLOCK();
-- 
2.7.4

[PATCH] jfs: Simplify code

[Christophe JAILLET]

Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to
'list_splice_init'.

This has been spotted with the following coccinelle script:
/
@@
expression y,z;
@@

-   list_splice(y,z);
-   INIT_LIST_HEAD(y);
+   list_splice_init(y,z);

Signed-off-by: Christophe JAILLET 
---
 fs/jfs/jfs_txnmgr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
index 2e58978d6f45..4d973524c887 100644
--- a/fs/jfs/jfs_txnmgr.c
+++ b/fs/jfs/jfs_txnmgr.c
@@ -2893,8 +2893,7 @@ restart:
 * on anon_list2.  Let's check.
 */
if (!list_empty(_list2)) {
-   list_splice(_list2, _list);
-   INIT_LIST_HEAD(_list2);
+   list_splice_init(_list2, _list);
goto restart;
}
TXN_UNLOCK();
-- 
2.7.4