Re: [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX

[Jessica Yu]

+++ Miroslav Benes [05/06/20 09:50 +0200]:

Hi,

On Thu, 4 Jun 2020, Max Filippov wrote:


On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel
build fails with the following message:

  kernel/module.c:3593:2: error: implicit declaration of function
  ‘module_enable_ro’;

Add empty module_enable_ro definition to fix the build.

Fixes: e6eff4376e28 ("module: Make module_enable_ro() static again")
Signed-off-by: Max Filippov 


I think the problem should disappear once Jessica sends her pull request
for modules tree.


Yep, the pull request was sent today. So this should get resolved in
the next day or two.

Thanks,

Jessica

Re: [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX

[Miroslav Benes]

Hi,

On Thu, 4 Jun 2020, Max Filippov wrote:

> On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel
> build fails with the following message:
> 
>   kernel/module.c:3593:2: error: implicit declaration of function
>   ‘module_enable_ro’;
> 
> Add empty module_enable_ro definition to fix the build.
> 
> Fixes: e6eff4376e28 ("module: Make module_enable_ro() static again")
> Signed-off-by: Max Filippov 

I think the problem should disappear once Jessica sends her pull request 
for modules tree.

Unfortunate though.

Miroslav

[PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX

[Max Filippov]

On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel
build fails with the following message:

  kernel/module.c:3593:2: error: implicit declaration of function
  ‘module_enable_ro’;

Add empty module_enable_ro definition to fix the build.

Fixes: e6eff4376e28 ("module: Make module_enable_ro() static again")
Signed-off-by: Max Filippov 
---
 kernel/module.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/module.c b/kernel/module.c
index bca993c5f1bc..a74a29001814 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2038,6 +2038,7 @@ static void module_enable_x(const struct module *mod)
 #else /* !CONFIG_ARCH_HAS_STRICT_MODULE_RWX */
 static void module_enable_nx(const struct module *mod) { }
 static void module_enable_x(const struct module *mod) { }
+static void module_enable_ro(const struct module *mod, bool after_init) {}
 #endif /* CONFIG_ARCH_HAS_STRICT_MODULE_RWX */
 
 
-- 
2.20.1