Re: [PATCH] ks7010: adding parenthesis to macro argument

[Dan Carpenter]

On Tue, Mar 14, 2017 at 03:01:50AM -0700, Pushkar Jambhlekar wrote:
> Hi Dan,
> 
> I am trying to fix warnings by "checkpatch.pl". Even though it is not
> super exciting, no harm to follow correct way.
> 

The harm is that it takes something that's already terrible and makes it
even more unreadable.

regards,
dan carpenter

Re: [PATCH] ks7010: adding parenthesis to macro argument

[Pushkar Jambhlekar]

Hi Dan,

I am trying to fix warnings by "checkpatch.pl". Even though it is not
super exciting, no harm to follow correct way.

On Tue, Mar 14, 2017 at 2:43 AM, Dan Carpenter  wrote:
> On Tue, Mar 14, 2017 at 11:12:42AM +0530, Pushkar Jambhlekar wrote:
>> Description:
>> In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis 
>> around macro params.
>> Also, removing extra line.
>
> Don't do this as one patch.
>
>>
>> Signed-off-by: Pushkar Jambhlekar 
>> ---
>>  drivers/staging/ks7010/ks7010_sdio.c | 13 ++---
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/staging/ks7010/ks7010_sdio.c 
>> b/drivers/staging/ks7010/ks7010_sdio.c
>> index a604c83..644b8d4 100644
>> --- a/drivers/staging/ks7010/ks7010_sdio.c
>> +++ b/drivers/staging/ks7010/ks7010_sdio.c
>> @@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids);
>>  /* macro */
>>
>>  #define inc_txqhead(priv) \
>> - (priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)
>> + ((priv)->tx_dev.qhead = ((priv)->tx_dev.qhead + 1) % 
>> TX_DEVICE_BUFF_SIZE)
>
> I can't get excited about this at all.  Make it a function or leave it
> alone.
>
> regards,
> dan carpenter
>



-- 
Jambhlekar Pushkar Arun
M.Tech IIT Roorkee

Re: [PATCH] ks7010: adding parenthesis to macro argument

[Dan Carpenter]

On Tue, Mar 14, 2017 at 11:12:42AM +0530, Pushkar Jambhlekar wrote:
> Description:
> In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis 
> around macro params.
> Also, removing extra line.

Don't do this as one patch.

> 
> Signed-off-by: Pushkar Jambhlekar 
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 13 ++---
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c 
> b/drivers/staging/ks7010/ks7010_sdio.c
> index a604c83..644b8d4 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids);
>  /* macro */
>  
>  #define inc_txqhead(priv) \
> - (priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)
> + ((priv)->tx_dev.qhead = ((priv)->tx_dev.qhead + 1) % 
> TX_DEVICE_BUFF_SIZE)

I can't get excited about this at all.  Make it a function or leave it
alone.

regards,
dan carpenter

[PATCH] ks7010: adding parenthesis to macro argument

[Pushkar Jambhlekar]

Description:
In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis 
around macro params.
Also, removing extra line.

Signed-off-by: Pushkar Jambhlekar 
---
 drivers/staging/ks7010/ks7010_sdio.c | 13 ++---
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c 
b/drivers/staging/ks7010/ks7010_sdio.c
index a604c83..644b8d4 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids);
 /* macro */
 
 #define inc_txqhead(priv) \
-   (priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)
+   ((priv)->tx_dev.qhead = ((priv)->tx_dev.qhead + 1) % 
TX_DEVICE_BUFF_SIZE)
 #define inc_txqtail(priv) \
-   (priv->tx_dev.qtail = (priv->tx_dev.qtail + 1) % TX_DEVICE_BUFF_SIZE)
+   ((priv)->tx_dev.qtail = ((priv)->tx_dev.qtail + 1) % 
TX_DEVICE_BUFF_SIZE)
 #define cnt_txqbody(priv) \
-   (((priv->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - (priv->tx_dev.qhead)) % 
TX_DEVICE_BUFF_SIZE)
+   priv)->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - 
((priv)->tx_dev.qhead)) % TX_DEVICE_BUFF_SIZE)
 
 #define inc_rxqhead(priv) \
-   (priv->rx_dev.qhead = (priv->rx_dev.qhead + 1) % RX_DEVICE_BUFF_SIZE)
+   ((priv)->rx_dev.qhead = ((priv)->rx_dev.qhead + 1) % 
RX_DEVICE_BUFF_SIZE)
 #define inc_rxqtail(priv) \
-   (priv->rx_dev.qtail = (priv->rx_dev.qtail + 1) % RX_DEVICE_BUFF_SIZE)
+   ((priv)->rx_dev.qtail = ((priv)->rx_dev.qtail + 1) % 
RX_DEVICE_BUFF_SIZE)
 #define cnt_rxqbody(priv) \
-   (((priv->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - (priv->rx_dev.qhead)) % 
RX_DEVICE_BUFF_SIZE)
+   priv)->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - 
((priv)->rx_dev.qhead)) % RX_DEVICE_BUFF_SIZE)
 
 static int ks7010_sdio_read(struct ks_wlan_private *priv, unsigned int address,
unsigned char *buffer, int length)
@@ -884,7 +884,6 @@ static void ks7010_card_init(struct ks_wlan_private *priv)
if (priv->mac_address_valid && priv->version_size)
priv->dev_state = DEVICE_STATE_PREINIT;
 
-
hostif_sme_enqueue(priv, SME_GET_EEPROM_CKSUM);
 
/* load initial wireless parameter */
-- 
2.7.4