Re: [PATCH] kvm/ftrace: change the diplaying format of vector in trace_msi_set_irq

2012-10-18 Thread Avi Kivity 
On 10/12/2012 02:03 AM, Sanagi, Koki wrote:
> This patch changes the way to diplay the vector in trace_msi_set_irq from %x 
> to
> %u.  Currently, it mismatches another output of ftrace such as kvm_msi_set_irq
> and kvm_inj_virq which uses %u.
> 
> Signed-off-by: Koki Sanagi 
> ---
>  include/trace/events/kvm.h |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
> index 7ef9e75..0a83632 100644
> --- a/include/trace/events/kvm.h
> +++ b/include/trace/events/kvm.h
> @@ -109,7 +109,7 @@ TRACE_EVENT(kvm_msi_set_irq,
>   __entry->data   = data;
>   ),
>  
> - TP_printk("dst %u vec %x (%s|%s|%s%s)",
> + TP_printk("dst %u vec %u (%s|%s|%s%s)",
> (u8)(__entry->address >> 12), (u8)__entry->data,
> __print_symbolic((__entry->data >> 8 & 0x7), 
> kvm_deliver_mode),
> (__entry->address & (1<<2)) ? "logical" : "physical",


Changing them all to %02x is probably better.  For example, writes to
APIC_ICR will be shown as hex, with the vector in the low order 8 bits,
so it will be easier to match them if they are all in hex.


-- 
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] kvm/ftrace: change the diplaying format of vector in trace_msi_set_irq

2012-10-18 Thread Avi Kivity 
On 10/12/2012 02:03 AM, Sanagi, Koki wrote:
 This patch changes the way to diplay the vector in trace_msi_set_irq from %x 
 to
 %u.  Currently, it mismatches another output of ftrace such as kvm_msi_set_irq
 and kvm_inj_virq which uses %u.
 
 Signed-off-by: Koki Sanagi sanagi.k...@jp.fujitsu.com
 ---
  include/trace/events/kvm.h |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
 index 7ef9e75..0a83632 100644
 --- a/include/trace/events/kvm.h
 +++ b/include/trace/events/kvm.h
 @@ -109,7 +109,7 @@ TRACE_EVENT(kvm_msi_set_irq,
   __entry-data   = data;
   ),
  
 - TP_printk(dst %u vec %x (%s|%s|%s%s),
 + TP_printk(dst %u vec %u (%s|%s|%s%s),
 (u8)(__entry-address  12), (u8)__entry-data,
 __print_symbolic((__entry-data  8  0x7), 
 kvm_deliver_mode),
 (__entry-address  (12)) ? logical : physical,


Changing them all to %02x is probably better.  For example, writes to
APIC_ICR will be shown as hex, with the vector in the low order 8 bits,
so it will be easier to match them if they are all in hex.


-- 
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] kvm/ftrace: change the diplaying format of vector in trace_msi_set_irq

2012-10-11 Thread Sanagi, Koki 
This patch changes the way to diplay the vector in trace_msi_set_irq from %x to
%u.  Currently, it mismatches another output of ftrace such as kvm_msi_set_irq
and kvm_inj_virq which uses %u.

Signed-off-by: Koki Sanagi 
---
 include/trace/events/kvm.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
index 7ef9e75..0a83632 100644
--- a/include/trace/events/kvm.h
+++ b/include/trace/events/kvm.h
@@ -109,7 +109,7 @@ TRACE_EVENT(kvm_msi_set_irq,
__entry->data   = data;
),
 
-   TP_printk("dst %u vec %x (%s|%s|%s%s)",
+   TP_printk("dst %u vec %u (%s|%s|%s%s)",
  (u8)(__entry->address >> 12), (u8)__entry->data,
  __print_symbolic((__entry->data >> 8 & 0x7), 
kvm_deliver_mode),
  (__entry->address & (1<<2)) ? "logical" : "physical",
N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i

[PATCH] kvm/ftrace: change the diplaying format of vector in trace_msi_set_irq

2012-10-11 Thread Sanagi, Koki 
This patch changes the way to diplay the vector in trace_msi_set_irq from %x to
%u.  Currently, it mismatches another output of ftrace such as kvm_msi_set_irq
and kvm_inj_virq which uses %u.

Signed-off-by: Koki Sanagi sanagi.k...@jp.fujitsu.com
---
 include/trace/events/kvm.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
index 7ef9e75..0a83632 100644
--- a/include/trace/events/kvm.h
+++ b/include/trace/events/kvm.h
@@ -109,7 +109,7 @@ TRACE_EVENT(kvm_msi_set_irq,
__entry-data   = data;
),
 
-   TP_printk(dst %u vec %x (%s|%s|%s%s),
+   TP_printk(dst %u vec %u (%s|%s|%s%s),
  (u8)(__entry-address  12), (u8)__entry-data,
  __print_symbolic((__entry-data  8  0x7), 
kvm_deliver_mode),
  (__entry-address  (12)) ? logical : physical,
N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z��w���?��)ߢf��^jǫy�m��@A�a���
0��h���i