Re: [PATCH] linux-firmware/AMD: add readme files for amd-ucode

2013-08-09 Thread Sherry Hurwitz

On 08/08/2013 03:13 PM, Ben Hutchings wrote:

I don't think this documentation is currently very useful.  See further
comments inline:

On Fri, 2013-07-19 at 17:43 -0500, Sherry Hurwitz wrote:

File: README
File: microcode_amd.bin.README
File: microcode_amd_fam15h.bin.README

Signed-off-by: Sherry Hurwitz 
---
  amd-ucode/README  |   46 +
  amd-ucode/microcode_amd.bin.README|   29 ++
  amd-ucode/microcode_amd_fam15h.bin.README |   13 
  3 files changed, 88 insertions(+)
  create mode 100644 amd-ucode/README
  create mode 100644 amd-ucode/microcode_amd.bin.README
  create mode 100644 amd-ucode/microcode_amd_fam15h.bin.README

diff --git a/amd-ucode/README b/amd-ucode/README
new file mode 100644
index 000..a92831d
--- /dev/null
+++ b/amd-ucode/README
@@ -0,0 +1,46 @@
+This package provides latest microcode patches
+for AMD processor families >= 0x10.
+
+See http://www.amd64.org/support/microcode.html
+for details.

As Marc Dietrich pointed out, this URL is currently broken.

I will remove the reference to the URL.



+Microcode patches are included in container files:
+- 'microcode_amd.bin' (for AMD CPU families 10h - 14h)
+- 'microcode_amd_fam15h.bin' (for AMD CPU family 15h)
+
+Please read the file INSTALL for install instructions.
+Please read the file LICENSE for licensing information.

These aren't the filenames used in linux-firmware.git.
no the files in linux-firmware.git are container files that hold these 
.asm files which are the true ucode.  This was merely listing what is in 
the container.



+The container files include following microcode patches:
+
+mc_patch_0183_PUB-v4/mc_patch_0183.asm
+mc_patch_0184_PUB-v4/mc_patch_0184.asm
+mc_patch_01C7_PUB-v1/mc_patch_01C7.asm
+mc_patch_01C8_PUB-v1/mc_patch_01C8.asm
+mc_patch_01D9_PUB-v1/mc_patch_01D9.asm
+mc_patch_01DA_PUB-v1/mc_patch_01DA.asm
+mc_patch_01DB_PUB-v1/mc_patch_01DB.asm
+mc_patch_01DC_PUB-v1/mc_patch_01DC.asm
+mc_patch_0232_PUB-v3/mc_patch_0232.asm
+mc_patch_0327_PUB-v1/mc_patch_0327.asm
+mc_patch_0529_PUB-v1/mc_patch_0529.asm
+mc_patch_05000119_PUB-v1/mc_patch_05000119.asm
+mc_patch_0600063D_PUB-v1/mc_patch_0600063D.asm
+mc_patch_06000822_PUB-v1/mc_patch_06000822.asm
+mc_patch_06001119_PUB-v2/mc_patch_06001119.asm

Are these filenames supposed to be meaningful?  Are they referenced by
some other documentation?
These names include the patch ID numbers that could be referenced in the 
table showing the list of errata or when talking to AMD support.  I will 
explain that in a better way in a new version of the document



+***
+Copyright 2008-2013 ADVANCED MICRO DEVICES, INC.  All Rights Reserved.
+
+AMD is granting you permission to use this software and documentation
+(if any) (collectively, the “Materials”) pursuant to the terms and
+conditions of the Software License Agreement included with the
+Materials.  This header does NOT give you permission to use the
+Materials or any rights under AMD’s intellectual property.  Your use
+of any portion of these Materials shall constitute your acceptance of
+those terms and conditions.  If you do not agree to the terms and
+conditions of the Software License Agreement, you do not have
+permission to use any portion of these Materials.  If you do not have
+a copy of the Software License Agreement, contact your AMD
+representative for a copy.
+

Isn't this redundant with LICENSE.amd-ucode?

Yes, I will remove this in version 2



diff --git a/amd-ucode/microcode_amd.bin.README 
b/amd-ucode/microcode_amd.bin.README
new file mode 100644
index 000..617d951
--- /dev/null
+++ b/amd-ucode/microcode_amd.bin.README
@@ -0,0 +1,29 @@
+;**
+; The associated microcode container file fixes the errata as documented in
+; Revision Guide for AMD Family 10h Processors, order #41322,
+; Revision Guide for AMD Family 11h Processors, order #41788,
+; Revision Guide for AMD Family 12h Processors, order #44739,
+; Revision Guide for AMD Family 14h Models 00h-0Fh Processors, order #47534,

Where can these be found?  (I found *some* revision guides with a web
search, but nothing with errata numbers above 400.)
I will include the URL for amd developer central where they can be 
downloaded.



+; for different revisions of AMD processors as follows:
+;
+; CPUIDFn[_0001]_EAX; ID; Errata fixed;
+;
+; 0x00100F22; 0x0183; 244, 260, 280, 302, 308, 315, 342;
+; 0x00100F23; 0x0183; 244, 260, 280, 302, 308, 315, 342;
+; 0x00100F2A; 0x0184; 244, 260, 280, 302, 308, 315, 342;
+; 0x00100F42; 0x01DB; 342, 440, 573;
+; 0x00100F43; 0x01C8; 407, 440;
+; 0x00100F52;

Re: [PATCH] linux-firmware/AMD: add readme files for amd-ucode

2013-08-08 Thread Ben Hutchings
On Wed, 2013-08-07 at 15:14 -0500, suravee suthikulpanit wrote:
> Hi All,
> 
> 
> I just would like to follow up the status of this patch.

I've not applied it, and I think the documentation needs some changes to
make it useful outside of www.amd64.org.

Ben.

-- 
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.


signature.asc
Description: This is a digitally signed message part


Re: [PATCH] linux-firmware/AMD: add readme files for amd-ucode

2013-08-08 Thread Ben Hutchings
I don't think this documentation is currently very useful.  See further
comments inline:

On Fri, 2013-07-19 at 17:43 -0500, Sherry Hurwitz wrote:
> File: README
> File: microcode_amd.bin.README
> File: microcode_amd_fam15h.bin.README
> 
> Signed-off-by: Sherry Hurwitz 
> ---
>  amd-ucode/README  |   46 
> +
>  amd-ucode/microcode_amd.bin.README|   29 ++
>  amd-ucode/microcode_amd_fam15h.bin.README |   13 
>  3 files changed, 88 insertions(+)
>  create mode 100644 amd-ucode/README
>  create mode 100644 amd-ucode/microcode_amd.bin.README
>  create mode 100644 amd-ucode/microcode_amd_fam15h.bin.README
> 
> diff --git a/amd-ucode/README b/amd-ucode/README
> new file mode 100644
> index 000..a92831d
> --- /dev/null
> +++ b/amd-ucode/README
> @@ -0,0 +1,46 @@
> +This package provides latest microcode patches
> +for AMD processor families >= 0x10.
> +
> +See http://www.amd64.org/support/microcode.html
> +for details.

As Marc Dietrich pointed out, this URL is currently broken.

> +Microcode patches are included in container files:
> +- 'microcode_amd.bin' (for AMD CPU families 10h - 14h)
> +- 'microcode_amd_fam15h.bin' (for AMD CPU family 15h)
> +
> +Please read the file INSTALL for install instructions.
> +Please read the file LICENSE for licensing information.

These aren't the filenames used in linux-firmware.git.

> +The container files include following microcode patches:
> +
> +mc_patch_0183_PUB-v4/mc_patch_0183.asm
> +mc_patch_0184_PUB-v4/mc_patch_0184.asm
> +mc_patch_01C7_PUB-v1/mc_patch_01C7.asm
> +mc_patch_01C8_PUB-v1/mc_patch_01C8.asm
> +mc_patch_01D9_PUB-v1/mc_patch_01D9.asm
> +mc_patch_01DA_PUB-v1/mc_patch_01DA.asm
> +mc_patch_01DB_PUB-v1/mc_patch_01DB.asm
> +mc_patch_01DC_PUB-v1/mc_patch_01DC.asm
> +mc_patch_0232_PUB-v3/mc_patch_0232.asm
> +mc_patch_0327_PUB-v1/mc_patch_0327.asm
> +mc_patch_0529_PUB-v1/mc_patch_0529.asm
> +mc_patch_05000119_PUB-v1/mc_patch_05000119.asm
> +mc_patch_0600063D_PUB-v1/mc_patch_0600063D.asm
> +mc_patch_06000822_PUB-v1/mc_patch_06000822.asm
> +mc_patch_06001119_PUB-v2/mc_patch_06001119.asm

Are these filenames supposed to be meaningful?  Are they referenced by
some other documentation?

> +***
> +Copyright 2008-2013 ADVANCED MICRO DEVICES, INC.  All Rights Reserved.
> +
> +AMD is granting you permission to use this software and documentation
> +(if any) (collectively, the “Materials”) pursuant to the terms and
> +conditions of the Software License Agreement included with the
> +Materials.  This header does NOT give you permission to use the
> +Materials or any rights under AMD’s intellectual property.  Your use
> +of any portion of these Materials shall constitute your acceptance of
> +those terms and conditions.  If you do not agree to the terms and
> +conditions of the Software License Agreement, you do not have
> +permission to use any portion of these Materials.  If you do not have
> +a copy of the Software License Agreement, contact your AMD
> +representative for a copy.
> +

Isn't this redundant with LICENSE.amd-ucode?

> diff --git a/amd-ucode/microcode_amd.bin.README 
> b/amd-ucode/microcode_amd.bin.README
> new file mode 100644
> index 000..617d951
> --- /dev/null
> +++ b/amd-ucode/microcode_amd.bin.README
> @@ -0,0 +1,29 @@
> +;**
> +; The associated microcode container file fixes the errata as documented in
> +; Revision Guide for AMD Family 10h Processors, order #41322,
> +; Revision Guide for AMD Family 11h Processors, order #41788,
> +; Revision Guide for AMD Family 12h Processors, order #44739,
> +; Revision Guide for AMD Family 14h Models 00h-0Fh Processors, order #47534,

Where can these be found?  (I found *some* revision guides with a web
search, but nothing with errata numbers above 400.)

> +; for different revisions of AMD processors as follows:
> +; 
> +; CPUIDFn[_0001]_EAX; ID; Errata fixed;
> +;
> +; 0x00100F22; 0x0183; 244, 260, 280, 302, 308, 315, 342;
> +; 0x00100F23; 0x0183; 244, 260, 280, 302, 308, 315, 342;
> +; 0x00100F2A; 0x0184; 244, 260, 280, 302, 308, 315, 342;
> +; 0x00100F42; 0x01DB; 342, 440, 573;
> +; 0x00100F43; 0x01C8; 407, 440;
> +; 0x00100F52; 0x01DB; 342, 440, 573;
> +; 0x00100F53; 0x01C8; 407, 440;
> +; 0x00100F62; 0x01C7; 407, 440;
> +; 0x00100F63; 0x01C8; 407, 440;
> +; 0x00100F80; 0x01DA; 419, 440, 573;
> +; 0x00100F81; 0x01D9; #406, #407, #440, #573, #669;
> +; 0x00100F91; 0x01D9; #406, #407, #440, #573, #669;
> +; 0x00100FA0; 0x01000

RE: [PATCH] linux-firmware/AMD: add readme files for amd-ucode

2013-07-24 Thread Hurwitz, Sherry
Yes, this site is down for the moment but we are working to get it back up as 
an informational site.  It will not be used as the primary distribution site 
for the ucode.  We want to direct people to the linux-firmware tree. 

> -Original Message-
> From: Marc Dietrich [mailto:marvi...@gmx.de]
> Sent: Saturday, July 20, 2013 4:44 AM
> To: Hurwitz, Sherry
> Cc: David Woodhouse; Ben Hutchings; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] linux-firmware/AMD: add readme files for amd-ucode
> 
> On Friday 19 July 2013 17:43:52 Sherry Hurwitz wrote:
> > File: README
> > File: microcode_amd.bin.README
> > File: microcode_amd_fam15h.bin.README
> >
> > Signed-off-by: Sherry Hurwitz 
> > ---
> >  amd-ucode/README  |   46
> > + amd-ucode/microcode_amd.bin.README
> |
> > 29 ++ amd-ucode/microcode_amd_fam15h.bin.README |
> 13
> > 
> >  3 files changed, 88 insertions(+)
> >  create mode 100644 amd-ucode/README
> >  create mode 100644 amd-ucode/microcode_amd.bin.README
> >  create mode 100644 amd-ucode/microcode_amd_fam15h.bin.README
> >
> > diff --git a/amd-ucode/README b/amd-ucode/README new file mode
> 100644
> > index 000..a92831d
> > --- /dev/null
> > +++ b/amd-ucode/README
> > @@ -0,0 +1,46 @@
> > +This package provides latest microcode patches for AMD processor
> > +families >= 0x10.
> > +
> > +See http://www.amd64.org/support/microcode.html
> > +for details.
> 
> Wasn't this URL deprecated (at least it's offline now)?
> 
> Marc
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] linux-firmware/AMD: add readme files for amd-ucode

2013-07-20 Thread Marc Dietrich
On Friday 19 July 2013 17:43:52 Sherry Hurwitz wrote:
> File: README
> File: microcode_amd.bin.README
> File: microcode_amd_fam15h.bin.README
> 
> Signed-off-by: Sherry Hurwitz 
> ---
>  amd-ucode/README  |   46
> + amd-ucode/microcode_amd.bin.README|  
> 29 ++ amd-ucode/microcode_amd_fam15h.bin.README |   13
> 
>  3 files changed, 88 insertions(+)
>  create mode 100644 amd-ucode/README
>  create mode 100644 amd-ucode/microcode_amd.bin.README
>  create mode 100644 amd-ucode/microcode_amd_fam15h.bin.README
> 
> diff --git a/amd-ucode/README b/amd-ucode/README
> new file mode 100644
> index 000..a92831d
> --- /dev/null
> +++ b/amd-ucode/README
> @@ -0,0 +1,46 @@
> +This package provides latest microcode patches
> +for AMD processor families >= 0x10.
> +
> +See http://www.amd64.org/support/microcode.html
> +for details.

Wasn't this URL deprecated (at least it's offline now)?

Marc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] linux-firmware/AMD: add readme files for amd-ucode

2013-07-19 Thread Sherry Hurwitz
File: README
File: microcode_amd.bin.README
File: microcode_amd_fam15h.bin.README

Signed-off-by: Sherry Hurwitz 
---
 amd-ucode/README  |   46 +
 amd-ucode/microcode_amd.bin.README|   29 ++
 amd-ucode/microcode_amd_fam15h.bin.README |   13 
 3 files changed, 88 insertions(+)
 create mode 100644 amd-ucode/README
 create mode 100644 amd-ucode/microcode_amd.bin.README
 create mode 100644 amd-ucode/microcode_amd_fam15h.bin.README

diff --git a/amd-ucode/README b/amd-ucode/README
new file mode 100644
index 000..a92831d
--- /dev/null
+++ b/amd-ucode/README
@@ -0,0 +1,46 @@
+This package provides latest microcode patches
+for AMD processor families >= 0x10.
+
+See http://www.amd64.org/support/microcode.html
+for details.
+
+Microcode patches are included in container files:
+- 'microcode_amd.bin' (for AMD CPU families 10h - 14h)
+- 'microcode_amd_fam15h.bin' (for AMD CPU family 15h)
+
+Please read the file INSTALL for install instructions.
+Please read the file LICENSE for licensing information.
+
+The container files include following microcode patches:
+
+mc_patch_0183_PUB-v4/mc_patch_0183.asm
+mc_patch_0184_PUB-v4/mc_patch_0184.asm
+mc_patch_01C7_PUB-v1/mc_patch_01C7.asm
+mc_patch_01C8_PUB-v1/mc_patch_01C8.asm
+mc_patch_01D9_PUB-v1/mc_patch_01D9.asm
+mc_patch_01DA_PUB-v1/mc_patch_01DA.asm
+mc_patch_01DB_PUB-v1/mc_patch_01DB.asm
+mc_patch_01DC_PUB-v1/mc_patch_01DC.asm
+mc_patch_0232_PUB-v3/mc_patch_0232.asm
+mc_patch_0327_PUB-v1/mc_patch_0327.asm
+mc_patch_0529_PUB-v1/mc_patch_0529.asm
+mc_patch_05000119_PUB-v1/mc_patch_05000119.asm
+mc_patch_0600063D_PUB-v1/mc_patch_0600063D.asm
+mc_patch_06000822_PUB-v1/mc_patch_06000822.asm
+mc_patch_06001119_PUB-v2/mc_patch_06001119.asm
+
+***
+Copyright 2008-2013 ADVANCED MICRO DEVICES, INC.  All Rights Reserved.
+
+AMD is granting you permission to use this software and documentation
+(if any) (collectively, the “Materials”) pursuant to the terms and
+conditions of the Software License Agreement included with the
+Materials.  This header does NOT give you permission to use the
+Materials or any rights under AMD’s intellectual property.  Your use
+of any portion of these Materials shall constitute your acceptance of
+those terms and conditions.  If you do not agree to the terms and
+conditions of the Software License Agreement, you do not have
+permission to use any portion of these Materials.  If you do not have
+a copy of the Software License Agreement, contact your AMD
+representative for a copy.
+
diff --git a/amd-ucode/microcode_amd.bin.README 
b/amd-ucode/microcode_amd.bin.README
new file mode 100644
index 000..617d951
--- /dev/null
+++ b/amd-ucode/microcode_amd.bin.README
@@ -0,0 +1,29 @@
+;**
+; The associated microcode container file fixes the errata as documented in
+; Revision Guide for AMD Family 10h Processors, order #41322,
+; Revision Guide for AMD Family 11h Processors, order #41788,
+; Revision Guide for AMD Family 12h Processors, order #44739,
+; Revision Guide for AMD Family 14h Models 00h-0Fh Processors, order #47534,
+; for different revisions of AMD processors as follows:
+; 
+; CPUIDFn[_0001]_EAX; ID; Errata fixed;
+;
+; 0x00100F22; 0x0183; 244, 260, 280, 302, 308, 315, 342;
+; 0x00100F23; 0x0183; 244, 260, 280, 302, 308, 315, 342;
+; 0x00100F2A; 0x0184; 244, 260, 280, 302, 308, 315, 342;
+; 0x00100F42; 0x01DB; 342, 440, 573;
+; 0x00100F43; 0x01C8; 407, 440;
+; 0x00100F52; 0x01DB; 342, 440, 573;
+; 0x00100F53; 0x01C8; 407, 440;
+; 0x00100F62; 0x01C7; 407, 440;
+; 0x00100F63; 0x01C8; 407, 440;
+; 0x00100F80; 0x01DA; 419, 440, 573;
+; 0x00100F81; 0x01D9; #406, #407, #440, #573, #669;
+; 0x00100F91; 0x01D9; #406, #407, #440, #573, #669;
+; 0x00100FA0; 0x01DC; 438, 440, 573;
+; 0x00200F31; 0x0232; 311, 316;
+; 0x00300F10; 0x0327; #564, #573, #662, #686;
+; 0x00500F10; 0x0529; #461, #564, #594, #595, #784;
+; 0x00500F20; 0x05000119; #461, #564, #594, #639, #662, #686, #784;
+;
+;**
diff --git a/amd-ucode/microcode_amd_fam15h.bin.README 
b/amd-ucode/microcode_amd_fam15h.bin.README
new file mode 100644
index 000..a688b84
--- /dev/null
+++ b/amd-ucode/microcode_amd_fam15h.bin.README
@@ -0,0 +1,13 @@
+;**
+; The associated microcode container file fixes