[PATCH] llist: Use for() initializer and conditional
Simplify the code a bit by using the initializer and conditional check in for() instead of a separate if() statement in the loop. Signed-off-by: Pranith Kumar --- lib/llist.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/llist.c b/lib/llist.c index ae5872b..ddbeebb 100644 --- a/lib/llist.c +++ b/lib/llist.c @@ -66,10 +66,7 @@ struct llist_node *llist_del_first(struct llist_head *head) { struct llist_node *entry, *old_entry, *next; - entry = smp_load_acquire(>first); - for (;;) { - if (entry == NULL) - return NULL; + for (entry = smp_load_acquire(>first); entry ; ) { old_entry = entry; next = READ_ONCE(entry->next); entry = cmpxchg(>first, old_entry, next); -- 2.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] llist: Use for() initializer and conditional
Simplify the code a bit by using the initializer and conditional check in for() instead of a separate if() statement in the loop. Signed-off-by: Pranith Kumar--- lib/llist.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/llist.c b/lib/llist.c index ae5872b..ddbeebb 100644 --- a/lib/llist.c +++ b/lib/llist.c @@ -66,10 +66,7 @@ struct llist_node *llist_del_first(struct llist_head *head) { struct llist_node *entry, *old_entry, *next; - entry = smp_load_acquire(>first); - for (;;) { - if (entry == NULL) - return NULL; + for (entry = smp_load_acquire(>first); entry ; ) { old_entry = entry; next = READ_ONCE(entry->next); entry = cmpxchg(>first, old_entry, next); -- 2.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/