Re: [PATCH] markers: fix sparse warnings in markers.c

2008-02-21 Thread Mathieu Desnoyers 
* Harvey Harrison ([EMAIL PROTECTED]) wrote:
> char can be unsigned
> kernel/marker.c:64:20: error: dubious one-bit signed bitfield
> kernel/marker.c:65:14: error: dubious one-bit signed bitfield
> 
> Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>

Yep, it makes sense.

Thanks!

Acked-by: Mathieu Desnoyers <[EMAIL PROTECTED]>

> ---
> Introduced between -rc1 and -rc2
>  kernel/marker.c |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/marker.c b/kernel/marker.c
> index c4c2cd8..50effc0 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -61,8 +61,8 @@ struct marker_entry {
>   int refcount;   /* Number of times armed. 0 if disarmed. */
>   struct rcu_head rcu;
>   void *oldptr;
> - char rcu_pending:1;
> - char ptype:1;
> + unsigned char rcu_pending:1;
> + unsigned char ptype:1;
>   char name[0];   /* Contains name'\0'format'\0' */
>  };
>  
> -- 
> 1.5.4.2.200.g99e75
> 
> 
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] markers: fix sparse warnings in markers.c

2008-02-21 Thread Mathieu Desnoyers 
* Harvey Harrison ([EMAIL PROTECTED]) wrote:
 char can be unsigned
 kernel/marker.c:64:20: error: dubious one-bit signed bitfield
 kernel/marker.c:65:14: error: dubious one-bit signed bitfield
 
 Signed-off-by: Harvey Harrison [EMAIL PROTECTED]

Yep, it makes sense.

Thanks!

Acked-by: Mathieu Desnoyers [EMAIL PROTECTED]

 ---
 Introduced between -rc1 and -rc2
  kernel/marker.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/kernel/marker.c b/kernel/marker.c
 index c4c2cd8..50effc0 100644
 --- a/kernel/marker.c
 +++ b/kernel/marker.c
 @@ -61,8 +61,8 @@ struct marker_entry {
   int refcount;   /* Number of times armed. 0 if disarmed. */
   struct rcu_head rcu;
   void *oldptr;
 - char rcu_pending:1;
 - char ptype:1;
 + unsigned char rcu_pending:1;
 + unsigned char ptype:1;
   char name[0];   /* Contains name'\0'format'\0' */
  };
  
 -- 
 1.5.4.2.200.g99e75
 
 
 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] markers: fix sparse warnings in markers.c

2008-02-20 Thread Harvey Harrison 
char can be unsigned
kernel/marker.c:64:20: error: dubious one-bit signed bitfield
kernel/marker.c:65:14: error: dubious one-bit signed bitfield

Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Introduced between -rc1 and -rc2
 kernel/marker.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/marker.c b/kernel/marker.c
index c4c2cd8..50effc0 100644
--- a/kernel/marker.c
+++ b/kernel/marker.c
@@ -61,8 +61,8 @@ struct marker_entry {
int refcount;   /* Number of times armed. 0 if disarmed. */
struct rcu_head rcu;
void *oldptr;
-   char rcu_pending:1;
-   char ptype:1;
+   unsigned char rcu_pending:1;
+   unsigned char ptype:1;
char name[0];   /* Contains name'\0'format'\0' */
 };
 
-- 
1.5.4.2.200.g99e75



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] markers: fix sparse warnings in markers.c

2008-02-20 Thread Harvey Harrison 
char can be unsigned
kernel/marker.c:64:20: error: dubious one-bit signed bitfield
kernel/marker.c:65:14: error: dubious one-bit signed bitfield

Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Introduced between -rc1 and -rc2
 kernel/marker.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/marker.c b/kernel/marker.c
index c4c2cd8..50effc0 100644
--- a/kernel/marker.c
+++ b/kernel/marker.c
@@ -61,8 +61,8 @@ struct marker_entry {
int refcount;   /* Number of times armed. 0 if disarmed. */
struct rcu_head rcu;
void *oldptr;
-   char rcu_pending:1;
-   char ptype:1;
+   unsigned char rcu_pending:1;
+   unsigned char ptype:1;
char name[0];   /* Contains name'\0'format'\0' */
 };
 
-- 
1.5.4.2.200.g99e75



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/