RE: [PATCH] media: Add BCM2048 radio driver
> From: ext Nils Faerber [nils.faer...@kernelconcepts.de] > Sent: Thursday, December 05, 2013 4:03 PM > To: Pali Rohár; Hans Verkuil; Mauro Carvalho Chehab; > linux-kernel@vger.kernel.org; linux-me...@vger.kernel.org; Nurkkala Eero.1 > (EXT-Haltian/Oulu); Joni Lapilainen; Ивайло Димитров; Pavel Machek; > aaro.koski...@iki.fi > Subject: Re: [PATCH] media: Add BCM2048 radio driver > > Am 05.12.2013 14:57, schrieb Sebastian Reichel: >> On Thu, Dec 05, 2013 at 02:20:56PM +0100, Pali Rohár wrote: >>>> Anyway, I've posted the pull request. Please note, if you want >>>> to avoid having this driver be removed again in the future, >>>> then you (or someone else) should work on addressing the >>>> issues in the TODO file I added. >>> >>> Ok. CCing other people who works with n900 kernel. >> >> Does the bcm2048's radio part work without the bluetooth driver? > Hello all, I recall that is doesn't work separately, but instead, it had to be powered on via a separate hci command. I don't remember what it was though. But again it maybe had to do with the configuration of the BT. Anyway, by having no BT driver at all would make it impossible to use the radio alone. - Eero > At least I do not know. > I just added the RDS data interface, I have no idea of about the > hardware and the other parts of it, sorry. > >> -- Sebastian > Cheers > nils > > -- > kernel concepts GmbH Tel: +49-271-771091-12 > Sieghuetter Hauptweg 48 > D-57072 Siegen Mob: +49-176-21024535 > http://www.kernelconcepts.de
Re: [PATCH] media: Add BCM2048 radio driver
Am 05.12.2013 14:57, schrieb Sebastian Reichel: > On Thu, Dec 05, 2013 at 02:20:56PM +0100, Pali Rohár wrote: >>> Anyway, I've posted the pull request. Please note, if you want >>> to avoid having this driver be removed again in the future, >>> then you (or someone else) should work on addressing the >>> issues in the TODO file I added. >> >> Ok. CCing other people who works with n900 kernel. > > Does the bcm2048's radio part work without the bluetooth driver? At least I do not know. I just added the RDS data interface, I have no idea of about the hardware and the other parts of it, sorry. > -- Sebastian Cheers nils -- kernel concepts GmbH Tel: +49-271-771091-12 Sieghuetter Hauptweg 48 D-57072 Siegen Mob: +49-176-21024535 http://www.kernelconcepts.de signature.asc Description: OpenPGP digital signature
Re: [PATCH] media: Add BCM2048 radio driver
On Thu, Dec 05, 2013 at 02:20:56PM +0100, Pali Rohár wrote: > > Anyway, I've posted the pull request. Please note, if you want > > to avoid having this driver be removed again in the future, > > then you (or someone else) should work on addressing the > > issues in the TODO file I added. > > Ok. CCing other people who works with n900 kernel. Does the bcm2048's radio part work without the bluetooth driver? -- Sebastian signature.asc Description: Digital signature
Re: [PATCH] media: Add BCM2048 radio driver
On Thursday 05 December 2013 08:52:30 Hans Verkuil wrote: > On 12/02/2013 09:51 PM, Pali Rohár wrote: > > On Monday 04 November 2013 12:39:44 Hans Verkuil wrote: > >> Hi Pali, > >> > >> On 10/26/2013 10:45 PM, Pali Rohár wrote: > >>> On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: > > Hans, so can it be added to drivers/staging/media tree? > > Yes, that is an option. It's up to you to decide what you > want. Note that if no cleanup work is done on the staging > driver for a long time, then it can be removed again. > > Regards, > > Hans > >>> > >>> Ok, so if you can add it to staging tree. When driver will > >>> be in mainline other developers can look at it too. Now > >>> when driver is hidden, nobody know where to find it... You > >>> can see how upstream development for Nokia N900 HW going > >>> on: http://elinux.org/N900 > >> > >> Please check my tree: > >> > >> http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/ref > >> s/h eads/bcm > >> > >> If you're OK, then I'll queue it for 3.14 (it's too late > >> for 3.13). > >> > >> Regards, > >> > >>Hans > > > > Hi, sorry for late reply. I looked into your tree and > > difference is that you only removed "linux/slab.h" include. > > So it it is not needed, then it is OK. > > I *added* slab.h :-) > Right, I looked at reverse diff :-) > Anyway, I've posted the pull request. Please note, if you want > to avoid having this driver be removed again in the future, > then you (or someone else) should work on addressing the > issues in the TODO file I added. > > Regards, > > Hans Ok. CCing other people who works with n900 kernel. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] media: Add BCM2048 radio driver
On Thursday 05 December 2013 08:52:30 Hans Verkuil wrote: On 12/02/2013 09:51 PM, Pali Rohár wrote: On Monday 04 November 2013 12:39:44 Hans Verkuil wrote: Hi Pali, On 10/26/2013 10:45 PM, Pali Rohár wrote: On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: Hans, so can it be added to drivers/staging/media tree? Yes, that is an option. It's up to you to decide what you want. Note that if no cleanup work is done on the staging driver for a long time, then it can be removed again. Regards, Hans Ok, so if you can add it to staging tree. When driver will be in mainline other developers can look at it too. Now when driver is hidden, nobody know where to find it... You can see how upstream development for Nokia N900 HW going on: http://elinux.org/N900 Please check my tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/ref s/h eads/bcm If you're OK, then I'll queue it for 3.14 (it's too late for 3.13). Regards, Hans Hi, sorry for late reply. I looked into your tree and difference is that you only removed linux/slab.h include. So it it is not needed, then it is OK. I *added* slab.h :-) Right, I looked at reverse diff :-) Anyway, I've posted the pull request. Please note, if you want to avoid having this driver be removed again in the future, then you (or someone else) should work on addressing the issues in the TODO file I added. Regards, Hans Ok. CCing other people who works with n900 kernel. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] media: Add BCM2048 radio driver
On Thu, Dec 05, 2013 at 02:20:56PM +0100, Pali Rohár wrote: Anyway, I've posted the pull request. Please note, if you want to avoid having this driver be removed again in the future, then you (or someone else) should work on addressing the issues in the TODO file I added. Ok. CCing other people who works with n900 kernel. Does the bcm2048's radio part work without the bluetooth driver? -- Sebastian signature.asc Description: Digital signature
Re: [PATCH] media: Add BCM2048 radio driver
Am 05.12.2013 14:57, schrieb Sebastian Reichel: On Thu, Dec 05, 2013 at 02:20:56PM +0100, Pali Rohár wrote: Anyway, I've posted the pull request. Please note, if you want to avoid having this driver be removed again in the future, then you (or someone else) should work on addressing the issues in the TODO file I added. Ok. CCing other people who works with n900 kernel. Does the bcm2048's radio part work without the bluetooth driver? At least I do not know. I just added the RDS data interface, I have no idea of about the hardware and the other parts of it, sorry. -- Sebastian Cheers nils -- kernel concepts GmbH Tel: +49-271-771091-12 Sieghuetter Hauptweg 48 D-57072 Siegen Mob: +49-176-21024535 http://www.kernelconcepts.de signature.asc Description: OpenPGP digital signature
RE: [PATCH] media: Add BCM2048 radio driver
From: ext Nils Faerber [nils.faer...@kernelconcepts.de] Sent: Thursday, December 05, 2013 4:03 PM To: Pali Rohár; Hans Verkuil; Mauro Carvalho Chehab; linux-kernel@vger.kernel.org; linux-me...@vger.kernel.org; Nurkkala Eero.1 (EXT-Haltian/Oulu); Joni Lapilainen; Ивайло Димитров; Pavel Machek; aaro.koski...@iki.fi Subject: Re: [PATCH] media: Add BCM2048 radio driver Am 05.12.2013 14:57, schrieb Sebastian Reichel: On Thu, Dec 05, 2013 at 02:20:56PM +0100, Pali Rohár wrote: Anyway, I've posted the pull request. Please note, if you want to avoid having this driver be removed again in the future, then you (or someone else) should work on addressing the issues in the TODO file I added. Ok. CCing other people who works with n900 kernel. Does the bcm2048's radio part work without the bluetooth driver? Hello all, I recall that is doesn't work separately, but instead, it had to be powered on via a separate hci command. I don't remember what it was though. But again it maybe had to do with the configuration of the BT. Anyway, by having no BT driver at all would make it impossible to use the radio alone. - Eero At least I do not know. I just added the RDS data interface, I have no idea of about the hardware and the other parts of it, sorry. -- Sebastian Cheers nils -- kernel concepts GmbH Tel: +49-271-771091-12 Sieghuetter Hauptweg 48 D-57072 Siegen Mob: +49-176-21024535 http://www.kernelconcepts.de
Re: [PATCH] media: Add BCM2048 radio driver
On 12/02/2013 09:51 PM, Pali Rohár wrote: > On Monday 04 November 2013 12:39:44 Hans Verkuil wrote: >> Hi Pali, >> >> On 10/26/2013 10:45 PM, Pali Rohár wrote: >>> On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: > Hans, so can it be added to drivers/staging/media tree? Yes, that is an option. It's up to you to decide what you want. Note that if no cleanup work is done on the staging driver for a long time, then it can be removed again. Regards, Hans >>> >>> Ok, so if you can add it to staging tree. When driver will >>> be in mainline other developers can look at it too. Now >>> when driver is hidden, nobody know where to find it... You >>> can see how upstream development for Nokia N900 HW going >>> on: http://elinux.org/N900 >> >> Please check my tree: >> >> http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/h >> eads/bcm >> >> If you're OK, then I'll queue it for 3.14 (it's too late for >> 3.13). >> >> Regards, >> >> Hans > > Hi, sorry for late reply. I looked into your tree and difference > is that you only removed "linux/slab.h" include. So it it is not > needed, then it is OK. I *added* slab.h :-) Anyway, I've posted the pull request. Please note, if you want to avoid having this driver be removed again in the future, then you (or someone else) should work on addressing the issues in the TODO file I added. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] media: Add BCM2048 radio driver
On 12/02/2013 09:51 PM, Pali Rohár wrote: On Monday 04 November 2013 12:39:44 Hans Verkuil wrote: Hi Pali, On 10/26/2013 10:45 PM, Pali Rohár wrote: On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: Hans, so can it be added to drivers/staging/media tree? Yes, that is an option. It's up to you to decide what you want. Note that if no cleanup work is done on the staging driver for a long time, then it can be removed again. Regards, Hans Ok, so if you can add it to staging tree. When driver will be in mainline other developers can look at it too. Now when driver is hidden, nobody know where to find it... You can see how upstream development for Nokia N900 HW going on: http://elinux.org/N900 Please check my tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/h eads/bcm If you're OK, then I'll queue it for 3.14 (it's too late for 3.13). Regards, Hans Hi, sorry for late reply. I looked into your tree and difference is that you only removed linux/slab.h include. So it it is not needed, then it is OK. I *added* slab.h :-) Anyway, I've posted the pull request. Please note, if you want to avoid having this driver be removed again in the future, then you (or someone else) should work on addressing the issues in the TODO file I added. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] media: Add BCM2048 radio driver
On Monday 04 November 2013 12:39:44 Hans Verkuil wrote: > Hi Pali, > > On 10/26/2013 10:45 PM, Pali Rohár wrote: > > On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: > >>> Hans, so can it be added to drivers/staging/media tree? > >> > >> Yes, that is an option. It's up to you to decide what you > >> want. Note that if no cleanup work is done on the staging > >> driver for a long time, then it can be removed again. > >> > >> Regards, > >> > >> Hans > > > > Ok, so if you can add it to staging tree. When driver will > > be in mainline other developers can look at it too. Now > > when driver is hidden, nobody know where to find it... You > > can see how upstream development for Nokia N900 HW going > > on: http://elinux.org/N900 > > Please check my tree: > > http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/h > eads/bcm > > If you're OK, then I'll queue it for 3.14 (it's too late for > 3.13). > > Regards, > > Hans Hi, sorry for late reply. I looked into your tree and difference is that you only removed "linux/slab.h" include. So it it is not needed, then it is OK. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] media: Add BCM2048 radio driver
On Monday 04 November 2013 12:39:44 Hans Verkuil wrote: Hi Pali, On 10/26/2013 10:45 PM, Pali Rohár wrote: On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: Hans, so can it be added to drivers/staging/media tree? Yes, that is an option. It's up to you to decide what you want. Note that if no cleanup work is done on the staging driver for a long time, then it can be removed again. Regards, Hans Ok, so if you can add it to staging tree. When driver will be in mainline other developers can look at it too. Now when driver is hidden, nobody know where to find it... You can see how upstream development for Nokia N900 HW going on: http://elinux.org/N900 Please check my tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/h eads/bcm If you're OK, then I'll queue it for 3.14 (it's too late for 3.13). Regards, Hans Hi, sorry for late reply. I looked into your tree and difference is that you only removed linux/slab.h include. So it it is not needed, then it is OK. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] media: Add BCM2048 radio driver
Hi Pali, On 10/26/2013 10:45 PM, Pali Rohár wrote: > On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: >>> Hans, so can it be added to drivers/staging/media tree? >> >> Yes, that is an option. It's up to you to decide what you >> want. Note that if no cleanup work is done on the staging >> driver for a long time, then it can be removed again. >> >> Regards, >> >> Hans >> > > Ok, so if you can add it to staging tree. When driver will be in > mainline other developers can look at it too. Now when driver is > hidden, nobody know where to find it... You can see how upstream > development for Nokia N900 HW going on: http://elinux.org/N900 > Please check my tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/bcm If you're OK, then I'll queue it for 3.14 (it's too late for 3.13). Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] media: Add BCM2048 radio driver
Hi Pali, On 10/26/2013 10:45 PM, Pali Rohár wrote: On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: Hans, so can it be added to drivers/staging/media tree? Yes, that is an option. It's up to you to decide what you want. Note that if no cleanup work is done on the staging driver for a long time, then it can be removed again. Regards, Hans Ok, so if you can add it to staging tree. When driver will be in mainline other developers can look at it too. Now when driver is hidden, nobody know where to find it... You can see how upstream development for Nokia N900 HW going on: http://elinux.org/N900 Please check my tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/bcm If you're OK, then I'll queue it for 3.14 (it's too late for 3.13). Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] media: Add BCM2048 radio driver
On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: > > Hans, so can it be added to drivers/staging/media tree? > > Yes, that is an option. It's up to you to decide what you > want. Note that if no cleanup work is done on the staging > driver for a long time, then it can be removed again. > > Regards, > > Hans > Ok, so if you can add it to staging tree. When driver will be in mainline other developers can look at it too. Now when driver is hidden, nobody know where to find it... You can see how upstream development for Nokia N900 HW going on: http://elinux.org/N900 -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] media: Add BCM2048 radio driver
> Hans, so can it be added to drivers/staging/media tree? Yes, that is an option. It's up to you to decide what you want. Note that if no cleanup work is done on the staging driver for a long time, then it can be removed again. Regards, Hans > > On Thursday 17 October 2013 21:31:04 Pali Rohár wrote: >> Hello, >> >> so what do you suggest? Add it to staging for now (or not)? >> >> On Tuesday 15 October 2013 17:08:39 Hans Verkuil wrote: >> > Hi Pali, >> > >> > Thanks for the patch, but I am afraid it will need some work >> > to make this acceptable for inclusion into the kernel. >> > >> > The main thing you need to do is to implement all the >> > controls using the control framework (see >> > Documentation/video4linux/v4l2-controls.txt). Most drivers >> > are by now converted to the control framework, so you will >> > find many examples of how to do this in drivers/media/radio. >> > >> > The sysfs stuff should be replaced by controls as well. A >> > lot of the RDS support is now available as controls >> > (although there may well be some missing features, but that >> > is easy enough to add). Since the RDS data is actually >> > read() from the device I am not sure whether the RDS >> > properties/controls should be there at all. >> > >> > Finally this driver should probably be split up into two >> > parts: one v4l2_subdev-based core driver and one platform >> > driver. See e.g. radio-si4713/si4713-i2c.c as a good >> > example. But I would wait with that until the rest of the >> > driver is cleaned up. Then I have a better idea of whether >> > this is necessary or not. >> > >> > It's also very useful to run v4l2-compliance (available in >> > the v4l-utils.git repo on git.linuxtv.org). That does lots >> > of sanity checks. >> > >> > Another option is to add the driver as-is to >> > drivers/staging/media, and clean it up bit by bit. >> > >> > Regards, >> > >> >Hans >> > >> > On 10/15/2013 04:26 PM, Pali Rohár wrote: >> > > This adds support for the BCM2048 radio module found in >> > > Nokia N900 >> > > >> > > Signed-off-by: Eero Nurkkala >> > > Signed-off-by: Nils Faerber >> > > Signed-off-by: Joni >> > > Lapilainen Signed-off-by: >> > > Pali Rohár >> > > --- >> > > >> > > drivers/media/radio/Kconfig | 10 + >> > > drivers/media/radio/Makefile|1 + >> > > drivers/media/radio/radio-bcm2048.c | 2744 >> > > +++ >> > > include/media/radio-bcm2048.h | 30 + >> > > 4 files changed, 2785 insertions(+) >> > > create mode 100644 drivers/media/radio/radio-bcm2048.c >> > > create mode 100644 include/media/radio-bcm2048.h > > -- > Pali Rohár > pali.ro...@gmail.com > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] media: Add BCM2048 radio driver
Hans, so can it be added to drivers/staging/media tree? On Thursday 17 October 2013 21:31:04 Pali Rohár wrote: > Hello, > > so what do you suggest? Add it to staging for now (or not)? > > On Tuesday 15 October 2013 17:08:39 Hans Verkuil wrote: > > Hi Pali, > > > > Thanks for the patch, but I am afraid it will need some work > > to make this acceptable for inclusion into the kernel. > > > > The main thing you need to do is to implement all the > > controls using the control framework (see > > Documentation/video4linux/v4l2-controls.txt). Most drivers > > are by now converted to the control framework, so you will > > find many examples of how to do this in drivers/media/radio. > > > > The sysfs stuff should be replaced by controls as well. A > > lot of the RDS support is now available as controls > > (although there may well be some missing features, but that > > is easy enough to add). Since the RDS data is actually > > read() from the device I am not sure whether the RDS > > properties/controls should be there at all. > > > > Finally this driver should probably be split up into two > > parts: one v4l2_subdev-based core driver and one platform > > driver. See e.g. radio-si4713/si4713-i2c.c as a good > > example. But I would wait with that until the rest of the > > driver is cleaned up. Then I have a better idea of whether > > this is necessary or not. > > > > It's also very useful to run v4l2-compliance (available in > > the v4l-utils.git repo on git.linuxtv.org). That does lots > > of sanity checks. > > > > Another option is to add the driver as-is to > > drivers/staging/media, and clean it up bit by bit. > > > > Regards, > > > > Hans > > > > On 10/15/2013 04:26 PM, Pali Rohár wrote: > > > This adds support for the BCM2048 radio module found in > > > Nokia N900 > > > > > > Signed-off-by: Eero Nurkkala > > > Signed-off-by: Nils Faerber > > > Signed-off-by: Joni > > > Lapilainen Signed-off-by: > > > Pali Rohár > > > --- > > > > > > drivers/media/radio/Kconfig | 10 + > > > drivers/media/radio/Makefile|1 + > > > drivers/media/radio/radio-bcm2048.c | 2744 > > > +++ > > > include/media/radio-bcm2048.h | 30 + > > > 4 files changed, 2785 insertions(+) > > > create mode 100644 drivers/media/radio/radio-bcm2048.c > > > create mode 100644 include/media/radio-bcm2048.h -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] media: Add BCM2048 radio driver
Hans, so can it be added to drivers/staging/media tree? On Thursday 17 October 2013 21:31:04 Pali Rohár wrote: Hello, so what do you suggest? Add it to staging for now (or not)? On Tuesday 15 October 2013 17:08:39 Hans Verkuil wrote: Hi Pali, Thanks for the patch, but I am afraid it will need some work to make this acceptable for inclusion into the kernel. The main thing you need to do is to implement all the controls using the control framework (see Documentation/video4linux/v4l2-controls.txt). Most drivers are by now converted to the control framework, so you will find many examples of how to do this in drivers/media/radio. The sysfs stuff should be replaced by controls as well. A lot of the RDS support is now available as controls (although there may well be some missing features, but that is easy enough to add). Since the RDS data is actually read() from the device I am not sure whether the RDS properties/controls should be there at all. Finally this driver should probably be split up into two parts: one v4l2_subdev-based core driver and one platform driver. See e.g. radio-si4713/si4713-i2c.c as a good example. But I would wait with that until the rest of the driver is cleaned up. Then I have a better idea of whether this is necessary or not. It's also very useful to run v4l2-compliance (available in the v4l-utils.git repo on git.linuxtv.org). That does lots of sanity checks. Another option is to add the driver as-is to drivers/staging/media, and clean it up bit by bit. Regards, Hans On 10/15/2013 04:26 PM, Pali Rohár wrote: This adds support for the BCM2048 radio module found in Nokia N900 Signed-off-by: Eero Nurkkala ext-eero.nurkk...@nokia.com Signed-off-by: Nils Faerber nils.faer...@kernelconcepts.de Signed-off-by: Joni Lapilainen joni.lapilai...@gmail.com Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/media/radio/Kconfig | 10 + drivers/media/radio/Makefile|1 + drivers/media/radio/radio-bcm2048.c | 2744 +++ include/media/radio-bcm2048.h | 30 + 4 files changed, 2785 insertions(+) create mode 100644 drivers/media/radio/radio-bcm2048.c create mode 100644 include/media/radio-bcm2048.h -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] media: Add BCM2048 radio driver
Hans, so can it be added to drivers/staging/media tree? Yes, that is an option. It's up to you to decide what you want. Note that if no cleanup work is done on the staging driver for a long time, then it can be removed again. Regards, Hans On Thursday 17 October 2013 21:31:04 Pali Rohár wrote: Hello, so what do you suggest? Add it to staging for now (or not)? On Tuesday 15 October 2013 17:08:39 Hans Verkuil wrote: Hi Pali, Thanks for the patch, but I am afraid it will need some work to make this acceptable for inclusion into the kernel. The main thing you need to do is to implement all the controls using the control framework (see Documentation/video4linux/v4l2-controls.txt). Most drivers are by now converted to the control framework, so you will find many examples of how to do this in drivers/media/radio. The sysfs stuff should be replaced by controls as well. A lot of the RDS support is now available as controls (although there may well be some missing features, but that is easy enough to add). Since the RDS data is actually read() from the device I am not sure whether the RDS properties/controls should be there at all. Finally this driver should probably be split up into two parts: one v4l2_subdev-based core driver and one platform driver. See e.g. radio-si4713/si4713-i2c.c as a good example. But I would wait with that until the rest of the driver is cleaned up. Then I have a better idea of whether this is necessary or not. It's also very useful to run v4l2-compliance (available in the v4l-utils.git repo on git.linuxtv.org). That does lots of sanity checks. Another option is to add the driver as-is to drivers/staging/media, and clean it up bit by bit. Regards, Hans On 10/15/2013 04:26 PM, Pali Rohár wrote: This adds support for the BCM2048 radio module found in Nokia N900 Signed-off-by: Eero Nurkkala ext-eero.nurkk...@nokia.com Signed-off-by: Nils Faerber nils.faer...@kernelconcepts.de Signed-off-by: Joni Lapilainen joni.lapilai...@gmail.com Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/media/radio/Kconfig | 10 + drivers/media/radio/Makefile|1 + drivers/media/radio/radio-bcm2048.c | 2744 +++ include/media/radio-bcm2048.h | 30 + 4 files changed, 2785 insertions(+) create mode 100644 drivers/media/radio/radio-bcm2048.c create mode 100644 include/media/radio-bcm2048.h -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] media: Add BCM2048 radio driver
On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: Hans, so can it be added to drivers/staging/media tree? Yes, that is an option. It's up to you to decide what you want. Note that if no cleanup work is done on the staging driver for a long time, then it can be removed again. Regards, Hans Ok, so if you can add it to staging tree. When driver will be in mainline other developers can look at it too. Now when driver is hidden, nobody know where to find it... You can see how upstream development for Nokia N900 HW going on: http://elinux.org/N900 -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] media: Add BCM2048 radio driver
Hello, so what do you suggest? Add it to staging for now (or not)? On Tuesday 15 October 2013 17:08:39 Hans Verkuil wrote: > Hi Pali, > > Thanks for the patch, but I am afraid it will need some work > to make this acceptable for inclusion into the kernel. > > The main thing you need to do is to implement all the controls > using the control framework (see > Documentation/video4linux/v4l2-controls.txt). Most drivers > are by now converted to the control framework, so you will > find many examples of how to do this in drivers/media/radio. > > The sysfs stuff should be replaced by controls as well. A lot > of the RDS support is now available as controls (although > there may well be some missing features, but that is easy > enough to add). Since the RDS data is actually read() from > the device I am not sure whether the RDS properties/controls > should be there at all. > > Finally this driver should probably be split up into two > parts: one v4l2_subdev-based core driver and one platform > driver. See e.g. radio-si4713/si4713-i2c.c as a good example. > But I would wait with that until the rest of the driver is > cleaned up. Then I have a better idea of whether this is > necessary or not. > > It's also very useful to run v4l2-compliance (available in the > v4l-utils.git repo on git.linuxtv.org). That does lots of > sanity checks. > > Another option is to add the driver as-is to > drivers/staging/media, and clean it up bit by bit. > > Regards, > > Hans > > On 10/15/2013 04:26 PM, Pali Rohár wrote: > > This adds support for the BCM2048 radio module found in > > Nokia N900 > > > > Signed-off-by: Eero Nurkkala > > Signed-off-by: Nils Faerber > > Signed-off-by: Joni Lapilainen > > Signed-off-by: Pali Rohár > > --- > > > > drivers/media/radio/Kconfig | 10 + > > drivers/media/radio/Makefile|1 + > > drivers/media/radio/radio-bcm2048.c | 2744 > > +++ > > include/media/radio-bcm2048.h | 30 + > > 4 files changed, 2785 insertions(+) > > create mode 100644 drivers/media/radio/radio-bcm2048.c > > create mode 100644 include/media/radio-bcm2048.h > > -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] media: Add BCM2048 radio driver
Hello, so what do you suggest? Add it to staging for now (or not)? On Tuesday 15 October 2013 17:08:39 Hans Verkuil wrote: Hi Pali, Thanks for the patch, but I am afraid it will need some work to make this acceptable for inclusion into the kernel. The main thing you need to do is to implement all the controls using the control framework (see Documentation/video4linux/v4l2-controls.txt). Most drivers are by now converted to the control framework, so you will find many examples of how to do this in drivers/media/radio. The sysfs stuff should be replaced by controls as well. A lot of the RDS support is now available as controls (although there may well be some missing features, but that is easy enough to add). Since the RDS data is actually read() from the device I am not sure whether the RDS properties/controls should be there at all. Finally this driver should probably be split up into two parts: one v4l2_subdev-based core driver and one platform driver. See e.g. radio-si4713/si4713-i2c.c as a good example. But I would wait with that until the rest of the driver is cleaned up. Then I have a better idea of whether this is necessary or not. It's also very useful to run v4l2-compliance (available in the v4l-utils.git repo on git.linuxtv.org). That does lots of sanity checks. Another option is to add the driver as-is to drivers/staging/media, and clean it up bit by bit. Regards, Hans On 10/15/2013 04:26 PM, Pali Rohár wrote: This adds support for the BCM2048 radio module found in Nokia N900 Signed-off-by: Eero Nurkkala ext-eero.nurkk...@nokia.com Signed-off-by: Nils Faerber nils.faer...@kernelconcepts.de Signed-off-by: Joni Lapilainen joni.lapilai...@gmail.com Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/media/radio/Kconfig | 10 + drivers/media/radio/Makefile|1 + drivers/media/radio/radio-bcm2048.c | 2744 +++ include/media/radio-bcm2048.h | 30 + 4 files changed, 2785 insertions(+) create mode 100644 drivers/media/radio/radio-bcm2048.c create mode 100644 include/media/radio-bcm2048.h -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
