Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
On Mon, 18 Feb 2008 15:34:48 +0800 Li Zefan <[EMAIL PROTECTED]> wrote: > Remove this VM_BUG_ON(), as Balbir stated: > > We used to have a for loop with !list_empty() as a termination condition > and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not > make sense. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> > --- > mm/memcontrol.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 718acf8..631002d 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long > nr_to_scan, > if (scan >= nr_to_scan) > break; > page = pc->page; > - VM_BUG_ON(!pc); > > if (unlikely(!PageLRU(page))) > continue; > -- > 1.5.4.rc3 > Acked-by: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
Li Zefan wrote: > Remove this VM_BUG_ON(), as Balbir stated: > > We used to have a for loop with !list_empty() as a termination condition > and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not > make sense. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> > --- > mm/memcontrol.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 718acf8..631002d 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long > nr_to_scan, > if (scan >= nr_to_scan) > break; > page = pc->page; > - VM_BUG_ON(!pc); > > if (unlikely(!PageLRU(page))) > continue; This seems much better Acked-by: Balbir Singh <[EMAIL PROTECTED]> -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
Li Zefan wrote: Remove this VM_BUG_ON(), as Balbir stated: We used to have a for loop with !list_empty() as a termination condition and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not make sense. Signed-off-by: Li Zefan [EMAIL PROTECTED] --- mm/memcontrol.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 718acf8..631002d 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, if (scan = nr_to_scan) break; page = pc-page; - VM_BUG_ON(!pc); if (unlikely(!PageLRU(page))) continue; This seems much better Acked-by: Balbir Singh [EMAIL PROTECTED] -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
On Mon, 18 Feb 2008 15:34:48 +0800 Li Zefan [EMAIL PROTECTED] wrote: Remove this VM_BUG_ON(), as Balbir stated: We used to have a for loop with !list_empty() as a termination condition and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not make sense. Signed-off-by: Li Zefan [EMAIL PROTECTED] --- mm/memcontrol.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 718acf8..631002d 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, if (scan = nr_to_scan) break; page = pc-page; - VM_BUG_ON(!pc); if (unlikely(!PageLRU(page))) continue; -- 1.5.4.rc3 Acked-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] Thanks, -Kame -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] memcgroup: remove a useless VM_BUG_ON()
Remove this VM_BUG_ON(), as Balbir stated: We used to have a for loop with !list_empty() as a termination condition and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not make sense. Signed-off-by: Li Zefan <[EMAIL PROTECTED]> --- mm/memcontrol.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 718acf8..631002d 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, if (scan >= nr_to_scan) break; page = pc->page; - VM_BUG_ON(!pc); if (unlikely(!PageLRU(page))) continue; -- 1.5.4.rc3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] memcgroup: remove a useless VM_BUG_ON()
Remove this VM_BUG_ON(), as Balbir stated: We used to have a for loop with !list_empty() as a termination condition and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not make sense. Signed-off-by: Li Zefan [EMAIL PROTECTED] --- mm/memcontrol.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 718acf8..631002d 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, if (scan = nr_to_scan) break; page = pc-page; - VM_BUG_ON(!pc); if (unlikely(!PageLRU(page))) continue; -- 1.5.4.rc3 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
