Re: [PATCH] memory: tegra30-emc: Remove unnecessary of_node_put in tegra_emc_probe

[Krzysztof Kozlowski]

On Thu, Nov 19, 2020 at 12:52:44PM -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> drivers/memory/tegra/tegra30-emc.c:1275:15: warning: variable 'np' is
> uninitialized when used here [-Wuninitialized]
> of_node_put(np);
> ^~
> drivers/memory/tegra/tegra30-emc.c:1269:24: note: initialize the
> variable 'np' to silence this warning
> struct device_node *np;
>   ^
>= NULL
> 1 warning generated.
> 
> There does not need to be an of_node_put call in this error handling
> block after the shuffling of the np assignment. Remove it so there is
> no use of uninitialized memory.
> 
> Fixes: 5e00fd90183a ("memory: tegra30-emc: Continue probing if timings are 
> missing in device-tree")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1203
> Signed-off-by: Nathan Chancellor 
> ---
>  drivers/memory/tegra/tegra30-emc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Thanks, applied.

Best regards,
Krzysztof

Re: [PATCH] memory: tegra30-emc: Remove unnecessary of_node_put in tegra_emc_probe

[Dmitry Osipenko]

19.11.2020 22:52, Nathan Chancellor пишет:
> Clang warns:
> 
> drivers/memory/tegra/tegra30-emc.c:1275:15: warning: variable 'np' is
> uninitialized when used here [-Wuninitialized]
> of_node_put(np);
> ^~
> drivers/memory/tegra/tegra30-emc.c:1269:24: note: initialize the
> variable 'np' to silence this warning
> struct device_node *np;
>   ^
>= NULL
> 1 warning generated.
> 
> There does not need to be an of_node_put call in this error handling
> block after the shuffling of the np assignment. Remove it so there is
> no use of uninitialized memory.
> 
> Fixes: 5e00fd90183a ("memory: tegra30-emc: Continue probing if timings are 
> missing in device-tree")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1203
> Signed-off-by: Nathan Chancellor 
> ---
>  drivers/memory/tegra/tegra30-emc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/memory/tegra/tegra30-emc.c 
> b/drivers/memory/tegra/tegra30-emc.c
> index 3488786da03b..93f9002d32ad 100644
> --- a/drivers/memory/tegra/tegra30-emc.c
> +++ b/drivers/memory/tegra/tegra30-emc.c
> @@ -1271,10 +1271,8 @@ static int tegra_emc_probe(struct platform_device 
> *pdev)
>   int err;
>  
>   emc = devm_kzalloc(>dev, sizeof(*emc), GFP_KERNEL);
> - if (!emc) {
> - of_node_put(np);
> + if (!emc)
>   return -ENOMEM;
> - }
>  
>   emc->mc = devm_tegra_memory_controller_get(>dev);
>   if (IS_ERR(emc->mc))
> 
> base-commit: 5e00fd90183ab0103b9f403ce73cb8407ebeb145
> 

Reviewed-by: Dmitry Osipenko 

[PATCH] memory: tegra30-emc: Remove unnecessary of_node_put in tegra_emc_probe

[Nathan Chancellor]

Clang warns:

drivers/memory/tegra/tegra30-emc.c:1275:15: warning: variable 'np' is
uninitialized when used here [-Wuninitialized]
of_node_put(np);
^~
drivers/memory/tegra/tegra30-emc.c:1269:24: note: initialize the
variable 'np' to silence this warning
struct device_node *np;
  ^
   = NULL
1 warning generated.

There does not need to be an of_node_put call in this error handling
block after the shuffling of the np assignment. Remove it so there is
no use of uninitialized memory.

Fixes: 5e00fd90183a ("memory: tegra30-emc: Continue probing if timings are 
missing in device-tree")
Link: https://github.com/ClangBuiltLinux/linux/issues/1203
Signed-off-by: Nathan Chancellor 
---
 drivers/memory/tegra/tegra30-emc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/memory/tegra/tegra30-emc.c 
b/drivers/memory/tegra/tegra30-emc.c
index 3488786da03b..93f9002d32ad 100644
--- a/drivers/memory/tegra/tegra30-emc.c
+++ b/drivers/memory/tegra/tegra30-emc.c
@@ -1271,10 +1271,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
int err;
 
emc = devm_kzalloc(>dev, sizeof(*emc), GFP_KERNEL);
-   if (!emc) {
-   of_node_put(np);
+   if (!emc)
return -ENOMEM;
-   }
 
emc->mc = devm_tegra_memory_controller_get(>dev);
if (IS_ERR(emc->mc))

base-commit: 5e00fd90183ab0103b9f403ce73cb8407ebeb145
-- 
2.29.2