Re: [PATCH] mfd: ab8500: Drop bm disable parameter

[Lee Jones]

On Sun, 07 Mar 2021, Linus Walleij wrote:

> Nobody is passing the module parameter to disable the
> battery management portions so just drop this parameter.
> 
> Signed-off-by: Linus Walleij 
> ---
> ChangeLog v1->v2:
> - Rebased on v5.12-rc, seems to have been missed for v5.12
>   merge window.
> ---
>  drivers/mfd/ab8500-core.c | 20 ++--
>  1 file changed, 6 insertions(+), 14 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH] mfd: ab8500: Drop bm disable parameter

[Linus Walleij]

Nobody is passing the module parameter to disable the
battery management portions so just drop this parameter.

Signed-off-by: Linus Walleij 
---
ChangeLog v1->v2:
- Rebased on v5.12-rc, seems to have been missed for v5.12
  merge window.
---
 drivers/mfd/ab8500-core.c | 20 ++--
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index a9037911162b..db72d27070d9 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -121,12 +121,6 @@
 static DEFINE_SPINLOCK(on_stat_lock);
 static u8 turn_on_stat_mask = 0xFF;
 static u8 turn_on_stat_set;
-static bool no_bm; /* No battery management */
-/*
- * not really modular, but the easiest way to keep compat with existing
- * bootargs behaviour is to continue using module_param here.
- */
-module_param(no_bm, bool, S_IRUGO);
 
 #define AB9540_MODEM_CTRL2_REG 0x23
 #define AB9540_MODEM_CTRL2_SWDBBRSTN_BIT   BIT(2)
@@ -1255,14 +1249,12 @@ static int ab8500_probe(struct platform_device *pdev)
if (ret)
return ret;
 
-   if (!no_bm) {
-   /* Add battery management devices */
-   ret = mfd_add_devices(ab8500->dev, 0, ab8500_bm_devs,
- ARRAY_SIZE(ab8500_bm_devs), NULL,
- 0, ab8500->domain);
-   if (ret)
-   dev_err(ab8500->dev, "error adding bm devices\n");
-   }
+   /* Add battery management devices */
+   ret = mfd_add_devices(ab8500->dev, 0, ab8500_bm_devs,
+ ARRAY_SIZE(ab8500_bm_devs), NULL,
+ 0, ab8500->domain);
+   if (ret)
+   dev_err(ab8500->dev, "error adding bm devices\n");
 
if (((is_ab8505(ab8500) || is_ab9540(ab8500)) &&
ab8500->chip_id >= AB8500_CUT2P0) || is_ab8540(ab8500))
-- 
2.29.2

[PATCH] mfd: ab8500: Drop bm disable parameter

[Linus Walleij]

Nobody is passing the module parameter to disable the
battery management portions so just drop this parameter.

Signed-off-by: Linus Walleij 
---
 drivers/mfd/ab8500-core.c | 20 ++--
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index 3b2276f04a98..f63a8e51d0e4 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -121,12 +121,6 @@
 static DEFINE_SPINLOCK(on_stat_lock);
 static u8 turn_on_stat_mask = 0xFF;
 static u8 turn_on_stat_set;
-static bool no_bm; /* No battery management */
-/*
- * not really modular, but the easiest way to keep compat with existing
- * bootargs behaviour is to continue using module_param here.
- */
-module_param(no_bm, bool, S_IRUGO);
 
 #define AB9540_MODEM_CTRL2_REG 0x23
 #define AB9540_MODEM_CTRL2_SWDBBRSTN_BIT   BIT(2)
@@ -1255,14 +1249,12 @@ static int ab8500_probe(struct platform_device *pdev)
if (ret)
return ret;
 
-   if (!no_bm) {
-   /* Add battery management devices */
-   ret = mfd_add_devices(ab8500->dev, 0, ab8500_bm_devs,
- ARRAY_SIZE(ab8500_bm_devs), NULL,
- 0, ab8500->domain);
-   if (ret)
-   dev_err(ab8500->dev, "error adding bm devices\n");
-   }
+   /* Add battery management devices */
+   ret = mfd_add_devices(ab8500->dev, 0, ab8500_bm_devs,
+ ARRAY_SIZE(ab8500_bm_devs), NULL,
+ 0, ab8500->domain);
+   if (ret)
+   dev_err(ab8500->dev, "error adding bm devices\n");
 
if (((is_ab8505(ab8500) || is_ab9540(ab8500)) &&
ab8500->chip_id >= AB8500_CUT2P0) || is_ab8540(ab8500))
-- 
2.26.2