Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
On Tue, 11 Sep 2018, Dan Murphy wrote: > Lee > > On 09/11/2018 12:08 PM, Dan Murphy wrote: > > Lee > > > > On 09/11/2018 10:57 AM, Lee Jones wrote: > >> On Fri, 07 Sep 2018, Dan Murphy wrote: > >> > >>> Pavel > >>> > >>> On 09/07/2018 04:39 AM, Pavel Machek wrote: > On Wed 2018-08-29 11:31:08, Pavel Machek wrote: > > From: Sebastian Reichel > > > > mfd: ti-lmu: constify mfd_cell tables > > > > Add const attribute to all mfd_cell structures. > > > > Signed-off-by: Sebastian Reichel > > Signed-off-by: Pavel Machek > > Lee, I guess this is for you to apply. Any news there? > > There are more patches ready, > >>> > >>> As I stated in another email thread. I don't see the need for this level > >>> of LMU framework. > >>> > >>> Here is the reference thread > >>> > >>> https://lore.kernel.org/patchwork/patch/982550/ > >> > >> This driver has been present for 1.5 years. > >> > >> Is that a NACK for *this* patch or are you hijacking? :) > >> > > > > Its a NACK for adding this. I am pushing a new series for the LM3697 and > > will end up > > sending LED drivers for the non-MFD devices contained within. I will try to > > match the > > feature set the best I can. > > Sorry it is a NACK for adding the backlight series. This patch is fine. Ack, thanks for confirming. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
On Tue, 11 Sep 2018, Dan Murphy wrote: > Lee > > On 09/11/2018 12:08 PM, Dan Murphy wrote: > > Lee > > > > On 09/11/2018 10:57 AM, Lee Jones wrote: > >> On Fri, 07 Sep 2018, Dan Murphy wrote: > >> > >>> Pavel > >>> > >>> On 09/07/2018 04:39 AM, Pavel Machek wrote: > On Wed 2018-08-29 11:31:08, Pavel Machek wrote: > > From: Sebastian Reichel > > > > mfd: ti-lmu: constify mfd_cell tables > > > > Add const attribute to all mfd_cell structures. > > > > Signed-off-by: Sebastian Reichel > > Signed-off-by: Pavel Machek > > Lee, I guess this is for you to apply. Any news there? > > There are more patches ready, > >>> > >>> As I stated in another email thread. I don't see the need for this level > >>> of LMU framework. > >>> > >>> Here is the reference thread > >>> > >>> https://lore.kernel.org/patchwork/patch/982550/ > >> > >> This driver has been present for 1.5 years. > >> > >> Is that a NACK for *this* patch or are you hijacking? :) > >> > > > > Its a NACK for adding this. I am pushing a new series for the LM3697 and > > will end up > > sending LED drivers for the non-MFD devices contained within. I will try to > > match the > > feature set the best I can. > > Sorry it is a NACK for adding the backlight series. This patch is fine. Ack, thanks for confirming. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
Lee On 09/11/2018 12:08 PM, Dan Murphy wrote: > Lee > > On 09/11/2018 10:57 AM, Lee Jones wrote: >> On Fri, 07 Sep 2018, Dan Murphy wrote: >> >>> Pavel >>> >>> On 09/07/2018 04:39 AM, Pavel Machek wrote: On Wed 2018-08-29 11:31:08, Pavel Machek wrote: > From: Sebastian Reichel > > mfd: ti-lmu: constify mfd_cell tables > > Add const attribute to all mfd_cell structures. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Pavel Machek Lee, I guess this is for you to apply. Any news there? There are more patches ready, >>> >>> As I stated in another email thread. I don't see the need for this level >>> of LMU framework. >>> >>> Here is the reference thread >>> >>> https://lore.kernel.org/patchwork/patch/982550/ >> >> This driver has been present for 1.5 years. >> >> Is that a NACK for *this* patch or are you hijacking? :) >> > > Its a NACK for adding this. I am pushing a new series for the LM3697 and > will end up > sending LED drivers for the non-MFD devices contained within. I will try to > match the > feature set the best I can. > Sorry it is a NACK for adding the backlight series. This patch is fine. Dan -- -- Dan Murphy
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
Lee On 09/11/2018 12:08 PM, Dan Murphy wrote: > Lee > > On 09/11/2018 10:57 AM, Lee Jones wrote: >> On Fri, 07 Sep 2018, Dan Murphy wrote: >> >>> Pavel >>> >>> On 09/07/2018 04:39 AM, Pavel Machek wrote: On Wed 2018-08-29 11:31:08, Pavel Machek wrote: > From: Sebastian Reichel > > mfd: ti-lmu: constify mfd_cell tables > > Add const attribute to all mfd_cell structures. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Pavel Machek Lee, I guess this is for you to apply. Any news there? There are more patches ready, >>> >>> As I stated in another email thread. I don't see the need for this level >>> of LMU framework. >>> >>> Here is the reference thread >>> >>> https://lore.kernel.org/patchwork/patch/982550/ >> >> This driver has been present for 1.5 years. >> >> Is that a NACK for *this* patch or are you hijacking? :) >> > > Its a NACK for adding this. I am pushing a new series for the LM3697 and > will end up > sending LED drivers for the non-MFD devices contained within. I will try to > match the > feature set the best I can. > Sorry it is a NACK for adding the backlight series. This patch is fine. Dan -- -- Dan Murphy
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
Lee On 09/11/2018 10:57 AM, Lee Jones wrote: > On Fri, 07 Sep 2018, Dan Murphy wrote: > >> Pavel >> >> On 09/07/2018 04:39 AM, Pavel Machek wrote: >>> On Wed 2018-08-29 11:31:08, Pavel Machek wrote: From: Sebastian Reichel mfd: ti-lmu: constify mfd_cell tables Add const attribute to all mfd_cell structures. Signed-off-by: Sebastian Reichel Signed-off-by: Pavel Machek >>> >>> Lee, I guess this is for you to apply. Any news there? >>> >>> There are more patches ready, >> >> As I stated in another email thread. I don't see the need for this level of >> LMU framework. >> >> Here is the reference thread >> >> https://lore.kernel.org/patchwork/patch/982550/ > > This driver has been present for 1.5 years. > > Is that a NACK for *this* patch or are you hijacking? :) > Its a NACK for adding this. I am pushing a new series for the LM3697 and will end up sending LED drivers for the non-MFD devices contained within. I will try to match the feature set the best I can. -- -- Dan Murphy
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
Lee On 09/11/2018 10:57 AM, Lee Jones wrote: > On Fri, 07 Sep 2018, Dan Murphy wrote: > >> Pavel >> >> On 09/07/2018 04:39 AM, Pavel Machek wrote: >>> On Wed 2018-08-29 11:31:08, Pavel Machek wrote: From: Sebastian Reichel mfd: ti-lmu: constify mfd_cell tables Add const attribute to all mfd_cell structures. Signed-off-by: Sebastian Reichel Signed-off-by: Pavel Machek >>> >>> Lee, I guess this is for you to apply. Any news there? >>> >>> There are more patches ready, >> >> As I stated in another email thread. I don't see the need for this level of >> LMU framework. >> >> Here is the reference thread >> >> https://lore.kernel.org/patchwork/patch/982550/ > > This driver has been present for 1.5 years. > > Is that a NACK for *this* patch or are you hijacking? :) > Its a NACK for adding this. I am pushing a new series for the LM3697 and will end up sending LED drivers for the non-MFD devices contained within. I will try to match the feature set the best I can. -- -- Dan Murphy
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
On Wed, 29 Aug 2018, Pavel Machek wrote: > From: Sebastian Reichel > > mfd: ti-lmu: constify mfd_cell tables > > Add const attribute to all mfd_cell structures. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Pavel Machek Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
On Wed, 29 Aug 2018, Pavel Machek wrote: > From: Sebastian Reichel > > mfd: ti-lmu: constify mfd_cell tables > > Add const attribute to all mfd_cell structures. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Pavel Machek Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
On Fri, 07 Sep 2018, Dan Murphy wrote: > Pavel > > On 09/07/2018 04:39 AM, Pavel Machek wrote: > > On Wed 2018-08-29 11:31:08, Pavel Machek wrote: > >> From: Sebastian Reichel > >> > >> mfd: ti-lmu: constify mfd_cell tables > >> > >> Add const attribute to all mfd_cell structures. > >> > >> Signed-off-by: Sebastian Reichel > >> Signed-off-by: Pavel Machek > > > > Lee, I guess this is for you to apply. Any news there? > > > > There are more patches ready, > > As I stated in another email thread. I don't see the need for this level of > LMU framework. > > Here is the reference thread > > https://lore.kernel.org/patchwork/patch/982550/ This driver has been present for 1.5 years. Is that a NACK for *this* patch or are you hijacking? :) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
On Fri, 07 Sep 2018, Dan Murphy wrote: > Pavel > > On 09/07/2018 04:39 AM, Pavel Machek wrote: > > On Wed 2018-08-29 11:31:08, Pavel Machek wrote: > >> From: Sebastian Reichel > >> > >> mfd: ti-lmu: constify mfd_cell tables > >> > >> Add const attribute to all mfd_cell structures. > >> > >> Signed-off-by: Sebastian Reichel > >> Signed-off-by: Pavel Machek > > > > Lee, I guess this is for you to apply. Any news there? > > > > There are more patches ready, > > As I stated in another email thread. I don't see the need for this level of > LMU framework. > > Here is the reference thread > > https://lore.kernel.org/patchwork/patch/982550/ This driver has been present for 1.5 years. Is that a NACK for *this* patch or are you hijacking? :) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
Pavel
On 09/07/2018 04:39 AM, Pavel Machek wrote:
> On Wed 2018-08-29 11:31:08, Pavel Machek wrote:
>> From: Sebastian Reichel
>>
>> mfd: ti-lmu: constify mfd_cell tables
>>
>> Add const attribute to all mfd_cell structures.
>>
>> Signed-off-by: Sebastian Reichel
>> Signed-off-by: Pavel Machek
>
> Lee, I guess this is for you to apply. Any news there?
>
> There are more patches ready,
As I stated in another email thread. I don't see the need for this level of
LMU framework.
Here is the reference thread
https://lore.kernel.org/patchwork/patch/982550/
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v4.19
>
> and it would be good to get them in. (Alternatively, you can just
> cherry-pick them from droid4-pending-v4.19).
>
> Thanks,
> Pavel
>
>
>> diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
>> index cfb411c..990437e 100644
>> --- a/drivers/mfd/ti-lmu.c
>> +++ b/drivers/mfd/ti-lmu.c
>> @@ -25,7 +25,7 @@
>> #include
>>
>> struct ti_lmu_data {
>> -struct mfd_cell *cells;
>> +const struct mfd_cell *cells;
>> int num_cells;
>> unsigned int max_register;
>> };
>> @@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
>> gpio_set_value(lmu->en_gpio, 0);
>> }
>>
>> -static struct mfd_cell lm3532_devices[] = {
>> +static const struct mfd_cell lm3532_devices[] = {
>> {
>> .name = "ti-lmu-backlight",
>> .id= LM3532,
>> @@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
>> .of_compatible = "ti,lm363x-regulator", \
>> } \
>>
>> -static struct mfd_cell lm3631_devices[] = {
>> +static const struct mfd_cell lm3631_devices[] = {
>> LM363X_REGULATOR(LM3631_BOOST),
>> LM363X_REGULATOR(LM3631_LDO_CONT),
>> LM363X_REGULATOR(LM3631_LDO_OREF),
>> @@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
>> },
>> };
>>
>> -static struct mfd_cell lm3632_devices[] = {
>> +static const struct mfd_cell lm3632_devices[] = {
>> LM363X_REGULATOR(LM3632_BOOST),
>> LM363X_REGULATOR(LM3632_LDO_POS),
>> LM363X_REGULATOR(LM3632_LDO_NEG),
>> @@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
>> },
>> };
>>
>> -static struct mfd_cell lm3633_devices[] = {
>> +static const struct mfd_cell lm3633_devices[] = {
>> {
>> .name = "ti-lmu-backlight",
>> .id= LM3633,
>> @@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
>> },
>> };
>>
>> -static struct mfd_cell lm3695_devices[] = {
>> +static const struct mfd_cell lm3695_devices[] = {
>> {
>> .name = "ti-lmu-backlight",
>> .id= LM3695,
>> @@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
>> },
>> };
>>
>> -static struct mfd_cell lm3697_devices[] = {
>> +static const struct mfd_cell lm3697_devices[] = {
>> {
>> .name = "ti-lmu-backlight",
>> .id= LM3697,
>>
>
>
>
--
--
Dan Murphy
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
Pavel
On 09/07/2018 04:39 AM, Pavel Machek wrote:
> On Wed 2018-08-29 11:31:08, Pavel Machek wrote:
>> From: Sebastian Reichel
>>
>> mfd: ti-lmu: constify mfd_cell tables
>>
>> Add const attribute to all mfd_cell structures.
>>
>> Signed-off-by: Sebastian Reichel
>> Signed-off-by: Pavel Machek
>
> Lee, I guess this is for you to apply. Any news there?
>
> There are more patches ready,
As I stated in another email thread. I don't see the need for this level of
LMU framework.
Here is the reference thread
https://lore.kernel.org/patchwork/patch/982550/
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v4.19
>
> and it would be good to get them in. (Alternatively, you can just
> cherry-pick them from droid4-pending-v4.19).
>
> Thanks,
> Pavel
>
>
>> diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
>> index cfb411c..990437e 100644
>> --- a/drivers/mfd/ti-lmu.c
>> +++ b/drivers/mfd/ti-lmu.c
>> @@ -25,7 +25,7 @@
>> #include
>>
>> struct ti_lmu_data {
>> -struct mfd_cell *cells;
>> +const struct mfd_cell *cells;
>> int num_cells;
>> unsigned int max_register;
>> };
>> @@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
>> gpio_set_value(lmu->en_gpio, 0);
>> }
>>
>> -static struct mfd_cell lm3532_devices[] = {
>> +static const struct mfd_cell lm3532_devices[] = {
>> {
>> .name = "ti-lmu-backlight",
>> .id= LM3532,
>> @@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
>> .of_compatible = "ti,lm363x-regulator", \
>> } \
>>
>> -static struct mfd_cell lm3631_devices[] = {
>> +static const struct mfd_cell lm3631_devices[] = {
>> LM363X_REGULATOR(LM3631_BOOST),
>> LM363X_REGULATOR(LM3631_LDO_CONT),
>> LM363X_REGULATOR(LM3631_LDO_OREF),
>> @@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
>> },
>> };
>>
>> -static struct mfd_cell lm3632_devices[] = {
>> +static const struct mfd_cell lm3632_devices[] = {
>> LM363X_REGULATOR(LM3632_BOOST),
>> LM363X_REGULATOR(LM3632_LDO_POS),
>> LM363X_REGULATOR(LM3632_LDO_NEG),
>> @@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
>> },
>> };
>>
>> -static struct mfd_cell lm3633_devices[] = {
>> +static const struct mfd_cell lm3633_devices[] = {
>> {
>> .name = "ti-lmu-backlight",
>> .id= LM3633,
>> @@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
>> },
>> };
>>
>> -static struct mfd_cell lm3695_devices[] = {
>> +static const struct mfd_cell lm3695_devices[] = {
>> {
>> .name = "ti-lmu-backlight",
>> .id= LM3695,
>> @@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
>> },
>> };
>>
>> -static struct mfd_cell lm3697_devices[] = {
>> +static const struct mfd_cell lm3697_devices[] = {
>> {
>> .name = "ti-lmu-backlight",
>> .id= LM3697,
>>
>
>
>
--
--
Dan Murphy
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
On Wed 2018-08-29 11:31:08, Pavel Machek wrote:
> From: Sebastian Reichel
>
> mfd: ti-lmu: constify mfd_cell tables
>
> Add const attribute to all mfd_cell structures.
>
> Signed-off-by: Sebastian Reichel
> Signed-off-by: Pavel Machek
Lee, I guess this is for you to apply. Any news there?
There are more patches ready,
https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v4.19
and it would be good to get them in. (Alternatively, you can just
cherry-pick them from droid4-pending-v4.19).
Thanks,
Pavel
> diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
> index cfb411c..990437e 100644
> --- a/drivers/mfd/ti-lmu.c
> +++ b/drivers/mfd/ti-lmu.c
> @@ -25,7 +25,7 @@
> #include
>
> struct ti_lmu_data {
> - struct mfd_cell *cells;
> + const struct mfd_cell *cells;
> int num_cells;
> unsigned int max_register;
> };
> @@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
> gpio_set_value(lmu->en_gpio, 0);
> }
>
> -static struct mfd_cell lm3532_devices[] = {
> +static const struct mfd_cell lm3532_devices[] = {
> {
> .name = "ti-lmu-backlight",
> .id= LM3532,
> @@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
> .of_compatible = "ti,lm363x-regulator", \
> }\
>
> -static struct mfd_cell lm3631_devices[] = {
> +static const struct mfd_cell lm3631_devices[] = {
> LM363X_REGULATOR(LM3631_BOOST),
> LM363X_REGULATOR(LM3631_LDO_CONT),
> LM363X_REGULATOR(LM3631_LDO_OREF),
> @@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
> },
> };
>
> -static struct mfd_cell lm3632_devices[] = {
> +static const struct mfd_cell lm3632_devices[] = {
> LM363X_REGULATOR(LM3632_BOOST),
> LM363X_REGULATOR(LM3632_LDO_POS),
> LM363X_REGULATOR(LM3632_LDO_NEG),
> @@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
> },
> };
>
> -static struct mfd_cell lm3633_devices[] = {
> +static const struct mfd_cell lm3633_devices[] = {
> {
> .name = "ti-lmu-backlight",
> .id= LM3633,
> @@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
> },
> };
>
> -static struct mfd_cell lm3695_devices[] = {
> +static const struct mfd_cell lm3695_devices[] = {
> {
> .name = "ti-lmu-backlight",
> .id= LM3695,
> @@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
> },
> };
>
> -static struct mfd_cell lm3697_devices[] = {
> +static const struct mfd_cell lm3697_devices[] = {
> {
> .name = "ti-lmu-backlight",
> .id= LM3697,
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
On Wed 2018-08-29 11:31:08, Pavel Machek wrote:
> From: Sebastian Reichel
>
> mfd: ti-lmu: constify mfd_cell tables
>
> Add const attribute to all mfd_cell structures.
>
> Signed-off-by: Sebastian Reichel
> Signed-off-by: Pavel Machek
Lee, I guess this is for you to apply. Any news there?
There are more patches ready,
https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v4.19
and it would be good to get them in. (Alternatively, you can just
cherry-pick them from droid4-pending-v4.19).
Thanks,
Pavel
> diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
> index cfb411c..990437e 100644
> --- a/drivers/mfd/ti-lmu.c
> +++ b/drivers/mfd/ti-lmu.c
> @@ -25,7 +25,7 @@
> #include
>
> struct ti_lmu_data {
> - struct mfd_cell *cells;
> + const struct mfd_cell *cells;
> int num_cells;
> unsigned int max_register;
> };
> @@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
> gpio_set_value(lmu->en_gpio, 0);
> }
>
> -static struct mfd_cell lm3532_devices[] = {
> +static const struct mfd_cell lm3532_devices[] = {
> {
> .name = "ti-lmu-backlight",
> .id= LM3532,
> @@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
> .of_compatible = "ti,lm363x-regulator", \
> }\
>
> -static struct mfd_cell lm3631_devices[] = {
> +static const struct mfd_cell lm3631_devices[] = {
> LM363X_REGULATOR(LM3631_BOOST),
> LM363X_REGULATOR(LM3631_LDO_CONT),
> LM363X_REGULATOR(LM3631_LDO_OREF),
> @@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
> },
> };
>
> -static struct mfd_cell lm3632_devices[] = {
> +static const struct mfd_cell lm3632_devices[] = {
> LM363X_REGULATOR(LM3632_BOOST),
> LM363X_REGULATOR(LM3632_LDO_POS),
> LM363X_REGULATOR(LM3632_LDO_NEG),
> @@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
> },
> };
>
> -static struct mfd_cell lm3633_devices[] = {
> +static const struct mfd_cell lm3633_devices[] = {
> {
> .name = "ti-lmu-backlight",
> .id= LM3633,
> @@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
> },
> };
>
> -static struct mfd_cell lm3695_devices[] = {
> +static const struct mfd_cell lm3695_devices[] = {
> {
> .name = "ti-lmu-backlight",
> .id= LM3695,
> @@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
> },
> };
>
> -static struct mfd_cell lm3697_devices[] = {
> +static const struct mfd_cell lm3697_devices[] = {
> {
> .name = "ti-lmu-backlight",
> .id= LM3697,
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
* Pavel Machek [180829 09:35]: > From: Sebastian Reichel > > mfd: ti-lmu: constify mfd_cell tables > > Add const attribute to all mfd_cell structures. Acked-by: Tony Lindgren
Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables
* Pavel Machek [180829 09:35]: > From: Sebastian Reichel > > mfd: ti-lmu: constify mfd_cell tables > > Add const attribute to all mfd_cell structures. Acked-by: Tony Lindgren
[PATCH] mfd: ti-lmu: constify mfd_cell tables
From: Sebastian Reichel
mfd: ti-lmu: constify mfd_cell tables
Add const attribute to all mfd_cell structures.
Signed-off-by: Sebastian Reichel
Signed-off-by: Pavel Machek
diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
index cfb411c..990437e 100644
--- a/drivers/mfd/ti-lmu.c
+++ b/drivers/mfd/ti-lmu.c
@@ -25,7 +25,7 @@
#include
struct ti_lmu_data {
- struct mfd_cell *cells;
+ const struct mfd_cell *cells;
int num_cells;
unsigned int max_register;
};
@@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
gpio_set_value(lmu->en_gpio, 0);
}
-static struct mfd_cell lm3532_devices[] = {
+static const struct mfd_cell lm3532_devices[] = {
{
.name = "ti-lmu-backlight",
.id= LM3532,
@@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
.of_compatible = "ti,lm363x-regulator", \
} \
-static struct mfd_cell lm3631_devices[] = {
+static const struct mfd_cell lm3631_devices[] = {
LM363X_REGULATOR(LM3631_BOOST),
LM363X_REGULATOR(LM3631_LDO_CONT),
LM363X_REGULATOR(LM3631_LDO_OREF),
@@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
},
};
-static struct mfd_cell lm3632_devices[] = {
+static const struct mfd_cell lm3632_devices[] = {
LM363X_REGULATOR(LM3632_BOOST),
LM363X_REGULATOR(LM3632_LDO_POS),
LM363X_REGULATOR(LM3632_LDO_NEG),
@@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
},
};
-static struct mfd_cell lm3633_devices[] = {
+static const struct mfd_cell lm3633_devices[] = {
{
.name = "ti-lmu-backlight",
.id= LM3633,
@@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
},
};
-static struct mfd_cell lm3695_devices[] = {
+static const struct mfd_cell lm3695_devices[] = {
{
.name = "ti-lmu-backlight",
.id= LM3695,
@@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
},
};
-static struct mfd_cell lm3697_devices[] = {
+static const struct mfd_cell lm3697_devices[] = {
{
.name = "ti-lmu-backlight",
.id= LM3697,
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
[PATCH] mfd: ti-lmu: constify mfd_cell tables
From: Sebastian Reichel
mfd: ti-lmu: constify mfd_cell tables
Add const attribute to all mfd_cell structures.
Signed-off-by: Sebastian Reichel
Signed-off-by: Pavel Machek
diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
index cfb411c..990437e 100644
--- a/drivers/mfd/ti-lmu.c
+++ b/drivers/mfd/ti-lmu.c
@@ -25,7 +25,7 @@
#include
struct ti_lmu_data {
- struct mfd_cell *cells;
+ const struct mfd_cell *cells;
int num_cells;
unsigned int max_register;
};
@@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
gpio_set_value(lmu->en_gpio, 0);
}
-static struct mfd_cell lm3532_devices[] = {
+static const struct mfd_cell lm3532_devices[] = {
{
.name = "ti-lmu-backlight",
.id= LM3532,
@@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
.of_compatible = "ti,lm363x-regulator", \
} \
-static struct mfd_cell lm3631_devices[] = {
+static const struct mfd_cell lm3631_devices[] = {
LM363X_REGULATOR(LM3631_BOOST),
LM363X_REGULATOR(LM3631_LDO_CONT),
LM363X_REGULATOR(LM3631_LDO_OREF),
@@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
},
};
-static struct mfd_cell lm3632_devices[] = {
+static const struct mfd_cell lm3632_devices[] = {
LM363X_REGULATOR(LM3632_BOOST),
LM363X_REGULATOR(LM3632_LDO_POS),
LM363X_REGULATOR(LM3632_LDO_NEG),
@@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
},
};
-static struct mfd_cell lm3633_devices[] = {
+static const struct mfd_cell lm3633_devices[] = {
{
.name = "ti-lmu-backlight",
.id= LM3633,
@@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
},
};
-static struct mfd_cell lm3695_devices[] = {
+static const struct mfd_cell lm3695_devices[] = {
{
.name = "ti-lmu-backlight",
.id= LM3695,
@@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
},
};
-static struct mfd_cell lm3697_devices[] = {
+static const struct mfd_cell lm3697_devices[] = {
{
.name = "ti-lmu-backlight",
.id= LM3697,
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
