Re: [PATCH] mlx4: fix build break
On Tuesday 12 February 2008 00:18, Roland Dreier wrote: > Thanks, applied. > > Jack, I thought you guys tested the build on powerpc. How did this > sneak through? > It did not sneak through, because the problem does not exist in the OFED git. The following commit was performed to git://git.openfabrics.org/ofed_1_3/linux-2.6.git on Sept 25, 2007: === commit 4a5709b81dfd249c98271801ddc01decb7acd466 Author: Eli Cohen <[EMAIL PROTECTED]> Date: Tue Sep 25 12:41:30 2007 +0200 add missing include file. ia64 requires it. Signed-off-by: Eli Cohen <[EMAIL PROTECTED]> diff --git a/drivers/net/mlx4/alloc.c b/drivers/net/mlx4/alloc.c index f8d63d3..704a56b 100644 --- a/drivers/net/mlx4/alloc.c +++ b/drivers/net/mlx4/alloc.c @@ -34,6 +34,7 @@ #include #include #include +#include #include "mlx4.h" I guess this just fell through the cracks with regard to posting it to the list. Sorry about that. - Jack -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ofa-general] Re: [PATCH] mlx4: fix build break
Roland Dreier wrote: Thanks, applied. Jack, I thought you guys tested the build on powerpc. How did this sneak through? We OFED on PPC - not clear how this happened We will check our process again Tziporet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mlx4: fix build break
Thanks, applied. Jack, I thought you guys tested the build on powerpc. How did this sneak through? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mlx4: fix build break
Thanks, applied. Jack, I thought you guys tested the build on powerpc. How did this sneak through? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ofa-general] Re: [PATCH] mlx4: fix build break
Roland Dreier wrote: Thanks, applied. Jack, I thought you guys tested the build on powerpc. How did this sneak through? We OFED on PPC - not clear how this happened We will check our process again Tziporet -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mlx4: fix build break
On Tuesday 12 February 2008 00:18, Roland Dreier wrote: Thanks, applied. Jack, I thought you guys tested the build on powerpc. How did this sneak through? It did not sneak through, because the problem does not exist in the OFED git. The following commit was performed to git://git.openfabrics.org/ofed_1_3/linux-2.6.git on Sept 25, 2007: === commit 4a5709b81dfd249c98271801ddc01decb7acd466 Author: Eli Cohen [EMAIL PROTECTED] Date: Tue Sep 25 12:41:30 2007 +0200 add missing include file. ia64 requires it. Signed-off-by: Eli Cohen [EMAIL PROTECTED] diff --git a/drivers/net/mlx4/alloc.c b/drivers/net/mlx4/alloc.c index f8d63d3..704a56b 100644 --- a/drivers/net/mlx4/alloc.c +++ b/drivers/net/mlx4/alloc.c @@ -34,6 +34,7 @@ #include linux/slab.h #include linux/bitmap.h #include linux/dma-mapping.h +#include linux/vmalloc.h #include mlx4.h I guess this just fell through the cracks with regard to posting it to the list. Sorry about that. - Jack -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] mlx4: fix build break
On Fri, Feb 08, 2008 at 03:16:53PM -0800, Roland Dreier wrote: > mlx4_core: For 64-bit systems, vmap() kernel queue buffers Hi, The above patch caused this to pop up on powerpc allyesconfig, looks like a missing include file: drivers/net/mlx4/alloc.c: In function 'mlx4_buf_alloc': drivers/net/mlx4/alloc.c:162: error: implicit declaration of function 'vmap' drivers/net/mlx4/alloc.c:162: error: 'VM_MAP' undeclared (first use in this function) drivers/net/mlx4/alloc.c:162: error: (Each undeclared identifier is reported only once drivers/net/mlx4/alloc.c:162: error: for each function it appears in.) drivers/net/mlx4/alloc.c:162: warning: assignment makes pointer from integer without a cast drivers/net/mlx4/alloc.c: In function 'mlx4_buf_free': drivers/net/mlx4/alloc.c:187: error: implicit declaration of function 'vunmap' Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/mlx4/alloc.c b/drivers/net/mlx4/alloc.c index 521dc03..75ef9d0 100644 --- a/drivers/net/mlx4/alloc.c +++ b/drivers/net/mlx4/alloc.c @@ -34,6 +34,7 @@ #include #include #include +#include #include "mlx4.h" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] mlx4: fix build break
On Fri, Feb 08, 2008 at 03:16:53PM -0800, Roland Dreier wrote: mlx4_core: For 64-bit systems, vmap() kernel queue buffers Hi, The above patch caused this to pop up on powerpc allyesconfig, looks like a missing include file: drivers/net/mlx4/alloc.c: In function 'mlx4_buf_alloc': drivers/net/mlx4/alloc.c:162: error: implicit declaration of function 'vmap' drivers/net/mlx4/alloc.c:162: error: 'VM_MAP' undeclared (first use in this function) drivers/net/mlx4/alloc.c:162: error: (Each undeclared identifier is reported only once drivers/net/mlx4/alloc.c:162: error: for each function it appears in.) drivers/net/mlx4/alloc.c:162: warning: assignment makes pointer from integer without a cast drivers/net/mlx4/alloc.c: In function 'mlx4_buf_free': drivers/net/mlx4/alloc.c:187: error: implicit declaration of function 'vunmap' Signed-off-by: Olof Johansson [EMAIL PROTECTED] diff --git a/drivers/net/mlx4/alloc.c b/drivers/net/mlx4/alloc.c index 521dc03..75ef9d0 100644 --- a/drivers/net/mlx4/alloc.c +++ b/drivers/net/mlx4/alloc.c @@ -34,6 +34,7 @@ #include linux/slab.h #include linux/bitmap.h #include linux/dma-mapping.h +#include linux/vmalloc.h #include mlx4.h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
