Re: [PATCH] mm/gup.c: Corrected document reference path
On 2020-04-30 12:01, Souptick Joarder wrote: Document path Documentation/vm/pin_user_pages.rst is not a correct reference and it should be Documentation/core-api/pin_user_pages.rst. Signed-off-by: Souptick Joarder --- mm/gup.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA diff --git a/mm/gup.c b/mm/gup.c index 7ce796c..4952f12 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2864,10 +2864,10 @@ int get_user_pages_fast(unsigned long start, int nr_pages, * the arguments here are identical. * * FOLL_PIN means that the pages must be released via unpin_user_page(). Please - * see Documentation/vm/pin_user_pages.rst for further details. + * see Documentation/core-api/pin_user_pages.rst for further details. * - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. It - * is NOT intended for Case 2 (RDMA: long-term pins). + * This is intended for Case 1 (DIO) in Documentation/core-api/pin_user_pages.rst. + * It is NOT intended for Case 2 (RDMA: long-term pins). */ int pin_user_pages_fast(unsigned long start, int nr_pages, unsigned int gup_flags, struct page **pages) @@ -2904,10 +2904,10 @@ int pin_user_pages_fast(unsigned long start, int nr_pages, * the arguments here are identical. * * FOLL_PIN means that the pages must be released via unpin_user_page(). Please - * see Documentation/vm/pin_user_pages.rst for details. + * see Documentation/core-api/pin_user_pages.rst for details. * - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. It - * is NOT intended for Case 2 (RDMA: long-term pins). + * This is intended for Case 1 (DIO) in Documentation/core-api/pin_user_pages.rst. + * It is NOT intended for Case 2 (RDMA: long-term pins). */ long pin_user_pages_remote(struct task_struct *tsk, struct mm_struct *mm, unsigned long start, unsigned long nr_pages, @@ -2940,10 +2940,10 @@ long pin_user_pages_remote(struct task_struct *tsk, struct mm_struct *mm, * FOLL_PIN is set. * * FOLL_PIN means that the pages must be released via unpin_user_page(). Please - * see Documentation/vm/pin_user_pages.rst for details. + * see Documentation/core-api/pin_user_pages.rst for details. * - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. It - * is NOT intended for Case 2 (RDMA: long-term pins). + * This is intended for Case 1 (DIO) in Documentation/core-api/pin_user_pages.rst. + * It is NOT intended for Case 2 (RDMA: long-term pins). */ long pin_user_pages(unsigned long start, unsigned long nr_pages, unsigned int gup_flags, struct page **pages,
Re: [PATCH] mm/gup.c: Corrected document reference path
On Fri, May 01, 2020 at 12:31:54AM +0530, Souptick Joarder wrote: > Document path Documentation/vm/pin_user_pages.rst is not a correct > reference and it should be Documentation/core-api/pin_user_pages.rst. > > Signed-off-by: Souptick Joarder Reviewed-by: Ira Weiny > --- > mm/gup.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 7ce796c..4952f12 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2864,10 +2864,10 @@ int get_user_pages_fast(unsigned long start, int > nr_pages, > * the arguments here are identical. > * > * FOLL_PIN means that the pages must be released via unpin_user_page(). > Please > - * see Documentation/vm/pin_user_pages.rst for further details. > + * see Documentation/core-api/pin_user_pages.rst for further details. > * > - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. > It > - * is NOT intended for Case 2 (RDMA: long-term pins). > + * This is intended for Case 1 (DIO) in > Documentation/core-api/pin_user_pages.rst. > + * It is NOT intended for Case 2 (RDMA: long-term pins). > */ > int pin_user_pages_fast(unsigned long start, int nr_pages, > unsigned int gup_flags, struct page **pages) > @@ -2904,10 +2904,10 @@ int pin_user_pages_fast(unsigned long start, int > nr_pages, > * the arguments here are identical. > * > * FOLL_PIN means that the pages must be released via unpin_user_page(). > Please > - * see Documentation/vm/pin_user_pages.rst for details. > + * see Documentation/core-api/pin_user_pages.rst for details. > * > - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. > It > - * is NOT intended for Case 2 (RDMA: long-term pins). > + * This is intended for Case 1 (DIO) in > Documentation/core-api/pin_user_pages.rst. > + * It is NOT intended for Case 2 (RDMA: long-term pins). > */ > long pin_user_pages_remote(struct task_struct *tsk, struct mm_struct *mm, > unsigned long start, unsigned long nr_pages, > @@ -2940,10 +2940,10 @@ long pin_user_pages_remote(struct task_struct *tsk, > struct mm_struct *mm, > * FOLL_PIN is set. > * > * FOLL_PIN means that the pages must be released via unpin_user_page(). > Please > - * see Documentation/vm/pin_user_pages.rst for details. > + * see Documentation/core-api/pin_user_pages.rst for details. > * > - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. > It > - * is NOT intended for Case 2 (RDMA: long-term pins). > + * This is intended for Case 1 (DIO) in > Documentation/core-api/pin_user_pages.rst. > + * It is NOT intended for Case 2 (RDMA: long-term pins). > */ > long pin_user_pages(unsigned long start, unsigned long nr_pages, > unsigned int gup_flags, struct page **pages, > -- > 1.9.1 > >
[PATCH] mm/gup.c: Corrected document reference path
Document path Documentation/vm/pin_user_pages.rst is not a correct reference and it should be Documentation/core-api/pin_user_pages.rst. Signed-off-by: Souptick Joarder --- mm/gup.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 7ce796c..4952f12 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2864,10 +2864,10 @@ int get_user_pages_fast(unsigned long start, int nr_pages, * the arguments here are identical. * * FOLL_PIN means that the pages must be released via unpin_user_page(). Please - * see Documentation/vm/pin_user_pages.rst for further details. + * see Documentation/core-api/pin_user_pages.rst for further details. * - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. It - * is NOT intended for Case 2 (RDMA: long-term pins). + * This is intended for Case 1 (DIO) in Documentation/core-api/pin_user_pages.rst. + * It is NOT intended for Case 2 (RDMA: long-term pins). */ int pin_user_pages_fast(unsigned long start, int nr_pages, unsigned int gup_flags, struct page **pages) @@ -2904,10 +2904,10 @@ int pin_user_pages_fast(unsigned long start, int nr_pages, * the arguments here are identical. * * FOLL_PIN means that the pages must be released via unpin_user_page(). Please - * see Documentation/vm/pin_user_pages.rst for details. + * see Documentation/core-api/pin_user_pages.rst for details. * - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. It - * is NOT intended for Case 2 (RDMA: long-term pins). + * This is intended for Case 1 (DIO) in Documentation/core-api/pin_user_pages.rst. + * It is NOT intended for Case 2 (RDMA: long-term pins). */ long pin_user_pages_remote(struct task_struct *tsk, struct mm_struct *mm, unsigned long start, unsigned long nr_pages, @@ -2940,10 +2940,10 @@ long pin_user_pages_remote(struct task_struct *tsk, struct mm_struct *mm, * FOLL_PIN is set. * * FOLL_PIN means that the pages must be released via unpin_user_page(). Please - * see Documentation/vm/pin_user_pages.rst for details. + * see Documentation/core-api/pin_user_pages.rst for details. * - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. It - * is NOT intended for Case 2 (RDMA: long-term pins). + * This is intended for Case 1 (DIO) in Documentation/core-api/pin_user_pages.rst. + * It is NOT intended for Case 2 (RDMA: long-term pins). */ long pin_user_pages(unsigned long start, unsigned long nr_pages, unsigned int gup_flags, struct page **pages, -- 1.9.1
