Re: [PATCH] mm/slab: minor coding style tweaks

2021-02-10 Thread David Rientjes
On Tue, 9 Feb 2021, Zhiyuan Dai wrote:

> Fixed some coding style issues, improve code reading.
> This patch adds whitespace to clearly separate the parameters.
> 
> Signed-off-by: Zhiyuan Dai 

Acked-by: David Rientjes 


[PATCH] mm/slab: minor coding style tweaks

2021-02-08 Thread Zhiyuan Dai
Fixed some coding style issues, improve code reading.
This patch adds whitespace to clearly separate the parameters.

Signed-off-by: Zhiyuan Dai 
---
 mm/slab.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index d7c8da9..30bba30 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -272,7 +272,7 @@ static void kmem_cache_node_init(struct kmem_cache_node 
*parent)
 #defineSTATS_DEC_ACTIVE(x) ((x)->num_active--)
 #defineSTATS_INC_ALLOCED(x)((x)->num_allocations++)
 #defineSTATS_INC_GROWN(x)  ((x)->grown++)
-#defineSTATS_ADD_REAPED(x,y)   ((x)->reaped += (y))
+#defineSTATS_ADD_REAPED(x, y)  ((x)->reaped += (y))
 #defineSTATS_SET_HIGH(x)   
\
do {\
if ((x)->num_active > (x)->high_mark)   \
@@ -296,7 +296,7 @@ static void kmem_cache_node_init(struct kmem_cache_node 
*parent)
 #defineSTATS_DEC_ACTIVE(x) do { } while (0)
 #defineSTATS_INC_ALLOCED(x)do { } while (0)
 #defineSTATS_INC_GROWN(x)  do { } while (0)
-#defineSTATS_ADD_REAPED(x,y)   do { (void)(y); } while (0)
+#defineSTATS_ADD_REAPED(x, y)  do { (void)(y); } while (0)
 #defineSTATS_SET_HIGH(x)   do { } while (0)
 #defineSTATS_INC_ERR(x)do { } while (0)
 #defineSTATS_INC_NODEALLOCS(x) do { } while (0)
@@ -332,7 +332,7 @@ static int obj_offset(struct kmem_cache *cachep)
 static unsigned long long *dbg_redzone1(struct kmem_cache *cachep, void *objp)
 {
BUG_ON(!(cachep->flags & SLAB_RED_ZONE));
-   return (unsigned long long*) (objp + obj_offset(cachep) -
+   return (unsigned long long *) (objp + obj_offset(cachep) -
  sizeof(unsigned long long));
 }
 
@@ -580,7 +580,7 @@ static int transfer_objects(struct array_cache *to,
if (!nr)
return 0;
 
-   memcpy(to->entry + to->avail, from->entry + from->avail -nr,
+   memcpy(to->entry + to->avail, from->entry + from->avail - nr,
sizeof(void *) *nr);
 
from->avail -= nr;
@@ -2738,7 +2738,7 @@ static void *cache_free_debugcheck(struct kmem_cache 
*cachep, void *objp,
 
 #else
 #define kfree_debugcheck(x) do { } while(0)
-#define cache_free_debugcheck(x,objp,z) (objp)
+#define cache_free_debugcheck(x, objp, z) (objp)
 #endif
 
 static inline void fixup_objfreelist_debug(struct kmem_cache *cachep,
@@ -3025,7 +3025,7 @@ static void *cache_alloc_debugcheck_after(struct 
kmem_cache *cachep,
return objp;
 }
 #else
-#define cache_alloc_debugcheck_after(a,b,objp,d) (objp)
+#define cache_alloc_debugcheck_after(a, b, objp, d) (objp)
 #endif
 
 static inline void *cache_alloc(struct kmem_cache *cachep, gfp_t flags)
-- 
1.8.3.1