Re: [PATCH] mm: remove redundant assignment of entry

2019-09-16 Thread Wei Yang 
On Mon, Sep 16, 2019 at 10:15:16PM +0100, Will Deacon wrote:
>On Sat, Sep 14, 2019 at 12:03:26AM +, Wei Yang wrote:
>> On Mon, Jul 08, 2019 at 04:27:40PM +0800, Wei Yang wrote:
>> >Since ptent will not be changed after previous assignment of entry, it
>> >is not necessary to do the assignment again.
>> >
>> 
>> Sounds this one is lost in the time line :-)
>
>Don't think so -- looks like it's in linux-next [1] via akpm to me.
>

Ah, thanks. I may miss some message.

>Will
>
>[1] 
>https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b47011719e5c05aa9dc78fe76a7e46075f422a45

-- 
Wei Yang
Help you, Help me

Re: [PATCH] mm: remove redundant assignment of entry

2019-09-16 Thread Will Deacon 
On Sat, Sep 14, 2019 at 12:03:26AM +, Wei Yang wrote:
> On Mon, Jul 08, 2019 at 04:27:40PM +0800, Wei Yang wrote:
> >Since ptent will not be changed after previous assignment of entry, it
> >is not necessary to do the assignment again.
> >
> 
> Sounds this one is lost in the time line :-)

Don't think so -- looks like it's in linux-next [1] via akpm to me.

Will

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b47011719e5c05aa9dc78fe76a7e46075f422a45

Re: [PATCH] mm: remove redundant assignment of entry

2019-09-13 Thread Wei Yang 
On Mon, Jul 08, 2019 at 04:27:40PM +0800, Wei Yang wrote:
>Since ptent will not be changed after previous assignment of entry, it
>is not necessary to do the assignment again.
>

Sounds this one is lost in the time line :-)

>Signed-off-by: Wei Yang 
>---
> mm/memory.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/mm/memory.c b/mm/memory.c
>index ddf20bd0c317..d108bb979a08 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -1127,7 +1127,6 @@ static unsigned long zap_pte_range(struct mmu_gather 
>*tlb,
>   if (unlikely(details))
>   continue;
> 
>-  entry = pte_to_swp_entry(ptent);
>   if (!non_swap_entry(entry))
>   rss[MM_SWAPENTS]--;
>   else if (is_migration_entry(entry)) {
>-- 
>2.17.1

-- 
Wei Yang
Help you, Help me

Re: [PATCH] mm: remove redundant assignment of entry

2019-07-08 Thread Matthew Wilcox 
On Mon, Jul 08, 2019 at 04:27:40PM +0800, Wei Yang wrote:
> Since ptent will not be changed after previous assignment of entry, it
> is not necessary to do the assignment again.
> 
> Signed-off-by: Wei Yang 

Acked-by: Matthew Wilcox (Oracle)

[PATCH] mm: remove redundant assignment of entry

2019-07-08 Thread Wei Yang 
Since ptent will not be changed after previous assignment of entry, it
is not necessary to do the assignment again.

Signed-off-by: Wei Yang 
---
 mm/memory.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index ddf20bd0c317..d108bb979a08 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1127,7 +1127,6 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
if (unlikely(details))
continue;
 
-   entry = pte_to_swp_entry(ptent);
if (!non_swap_entry(entry))
rss[MM_SWAPENTS]--;
else if (is_migration_entry(entry)) {
-- 
2.17.1