Re: [PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

[Boris Brezillon]

On Wed, 27 Sep 2017 14:49:17 +0200
Richard Genoud  wrote:

> When calculating the size needed by struct atmel_pmecc_user *user,
> the dmu and delta buffer sizes were forgotten.
> This lead to a memory corruption (especially with a large ecc_strength).
> 
> Link: http://lkml.kernel.org/r/1506503157.3016.5.ca...@gmail.com
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> Cc: Nicolas Ferre 
> Cc: sta...@vger.kernel.org
> Reported-by: Richard Genoud 
> Pointed-at-by: Boris Brezillon 
> Signed-off-by: Richard Genoud 

Applied.

Thanks,

Boris

> ---
>  drivers/mtd/nand/atmel/pmecc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
> index 146af8218314..8268636675ef 100644
> --- a/drivers/mtd/nand/atmel/pmecc.c
> +++ b/drivers/mtd/nand/atmel/pmecc.c
> @@ -363,7 +363,7 @@ atmel_pmecc_create_user(struct atmel_pmecc *pmecc,
>   size += (req->ecc.strength + 1) * sizeof(u16);
>   /* Reserve space for mu, dmu and delta. */
>   size = ALIGN(size, sizeof(s32));
> - size += (req->ecc.strength + 1) * sizeof(s32);
> + size += (req->ecc.strength + 1) * sizeof(s32) * 3;
>  
>   user = kzalloc(size, GFP_KERNEL);
>   if (!user)
> 
> __
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

[Boris Brezillon]

On Wed, 27 Sep 2017 14:49:17 +0200
Richard Genoud  wrote:

> When calculating the size needed by struct atmel_pmecc_user *user,
> the dmu and delta buffer sizes were forgotten.
> This lead to a memory corruption (especially with a large ecc_strength).
> 
> Link: http://lkml.kernel.org/r/1506503157.3016.5.ca...@gmail.com
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> Cc: Nicolas Ferre 
> Cc: sta...@vger.kernel.org
> Reported-by: Richard Genoud 
> Pointed-at-by: Boris Brezillon 
> Signed-off-by: Richard Genoud 

Applied.

Thanks,

Boris

> ---
>  drivers/mtd/nand/atmel/pmecc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
> index 146af8218314..8268636675ef 100644
> --- a/drivers/mtd/nand/atmel/pmecc.c
> +++ b/drivers/mtd/nand/atmel/pmecc.c
> @@ -363,7 +363,7 @@ atmel_pmecc_create_user(struct atmel_pmecc *pmecc,
>   size += (req->ecc.strength + 1) * sizeof(u16);
>   /* Reserve space for mu, dmu and delta. */
>   size = ALIGN(size, sizeof(s32));
> - size += (req->ecc.strength + 1) * sizeof(s32);
> + size += (req->ecc.strength + 1) * sizeof(s32) * 3;
>  
>   user = kzalloc(size, GFP_KERNEL);
>   if (!user)
> 
> __
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

[Nicolas Ferre]

On 27/09/2017 at 14:49, Richard Genoud wrote:
> When calculating the size needed by struct atmel_pmecc_user *user,
> the dmu and delta buffer sizes were forgotten.
> This lead to a memory corruption (especially with a large ecc_strength).
> 
> Link: http://lkml.kernel.org/r/1506503157.3016.5.ca...@gmail.com
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> Cc: Nicolas Ferre 

Yes:
Reviewed-by: Nicolas Ferre 
Thanks Richard and Boris for this quick fix!

Regards,
  Nicolas

> Cc: sta...@vger.kernel.org
> Reported-by: Richard Genoud 
> Pointed-at-by: Boris Brezillon 
> Signed-off-by: Richard Genoud 
> ---
>  drivers/mtd/nand/atmel/pmecc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
> index 146af8218314..8268636675ef 100644
> --- a/drivers/mtd/nand/atmel/pmecc.c
> +++ b/drivers/mtd/nand/atmel/pmecc.c
> @@ -363,7 +363,7 @@ atmel_pmecc_create_user(struct atmel_pmecc *pmecc,
>   size += (req->ecc.strength + 1) * sizeof(u16);
>   /* Reserve space for mu, dmu and delta. */
>   size = ALIGN(size, sizeof(s32));
> - size += (req->ecc.strength + 1) * sizeof(s32);
> + size += (req->ecc.strength + 1) * sizeof(s32) * 3;
>  
>   user = kzalloc(size, GFP_KERNEL);
>   if (!user)
> 


-- 
Nicolas Ferre

Re: [PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

[Nicolas Ferre]

On 27/09/2017 at 14:49, Richard Genoud wrote:
> When calculating the size needed by struct atmel_pmecc_user *user,
> the dmu and delta buffer sizes were forgotten.
> This lead to a memory corruption (especially with a large ecc_strength).
> 
> Link: http://lkml.kernel.org/r/1506503157.3016.5.ca...@gmail.com
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> Cc: Nicolas Ferre 

Yes:
Reviewed-by: Nicolas Ferre 
Thanks Richard and Boris for this quick fix!

Regards,
  Nicolas

> Cc: sta...@vger.kernel.org
> Reported-by: Richard Genoud 
> Pointed-at-by: Boris Brezillon 
> Signed-off-by: Richard Genoud 
> ---
>  drivers/mtd/nand/atmel/pmecc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
> index 146af8218314..8268636675ef 100644
> --- a/drivers/mtd/nand/atmel/pmecc.c
> +++ b/drivers/mtd/nand/atmel/pmecc.c
> @@ -363,7 +363,7 @@ atmel_pmecc_create_user(struct atmel_pmecc *pmecc,
>   size += (req->ecc.strength + 1) * sizeof(u16);
>   /* Reserve space for mu, dmu and delta. */
>   size = ALIGN(size, sizeof(s32));
> - size += (req->ecc.strength + 1) * sizeof(s32);
> + size += (req->ecc.strength + 1) * sizeof(s32) * 3;
>  
>   user = kzalloc(size, GFP_KERNEL);
>   if (!user)
> 


-- 
Nicolas Ferre

[PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

[Richard Genoud]

When calculating the size needed by struct atmel_pmecc_user *user,
the dmu and delta buffer sizes were forgotten.
This lead to a memory corruption (especially with a large ecc_strength).

Link: http://lkml.kernel.org/r/1506503157.3016.5.ca...@gmail.com
Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
Cc: Nicolas Ferre 
Cc: sta...@vger.kernel.org
Reported-by: Richard Genoud 
Pointed-at-by: Boris Brezillon 
Signed-off-by: Richard Genoud 
---
 drivers/mtd/nand/atmel/pmecc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
index 146af8218314..8268636675ef 100644
--- a/drivers/mtd/nand/atmel/pmecc.c
+++ b/drivers/mtd/nand/atmel/pmecc.c
@@ -363,7 +363,7 @@ atmel_pmecc_create_user(struct atmel_pmecc *pmecc,
size += (req->ecc.strength + 1) * sizeof(u16);
/* Reserve space for mu, dmu and delta. */
size = ALIGN(size, sizeof(s32));
-   size += (req->ecc.strength + 1) * sizeof(s32);
+   size += (req->ecc.strength + 1) * sizeof(s32) * 3;
 
user = kzalloc(size, GFP_KERNEL);
if (!user)

[PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

[Richard Genoud]

When calculating the size needed by struct atmel_pmecc_user *user,
the dmu and delta buffer sizes were forgotten.
This lead to a memory corruption (especially with a large ecc_strength).

Link: http://lkml.kernel.org/r/1506503157.3016.5.ca...@gmail.com
Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
Cc: Nicolas Ferre 
Cc: sta...@vger.kernel.org
Reported-by: Richard Genoud 
Pointed-at-by: Boris Brezillon 
Signed-off-by: Richard Genoud 
---
 drivers/mtd/nand/atmel/pmecc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
index 146af8218314..8268636675ef 100644
--- a/drivers/mtd/nand/atmel/pmecc.c
+++ b/drivers/mtd/nand/atmel/pmecc.c
@@ -363,7 +363,7 @@ atmel_pmecc_create_user(struct atmel_pmecc *pmecc,
size += (req->ecc.strength + 1) * sizeof(u16);
/* Reserve space for mu, dmu and delta. */
size = ALIGN(size, sizeof(s32));
-   size += (req->ecc.strength + 1) * sizeof(s32);
+   size += (req->ecc.strength + 1) * sizeof(s32) * 3;
 
user = kzalloc(size, GFP_KERNEL);
if (!user)