Re: [PATCH] net: appletalk: remove cops support
On Wed, Oct 4, 2023, at 20:52, Jakub Kicinski wrote: > On Wed, 27 Sep 2023 11:00:30 +0200 Greg Kroah-Hartman wrote: >> The COPS Appletalk support is very old, never said to actually work >> properly, and the firmware code for the devices are under a very suspect >> license. Remove it all to clear up the license issue, if it is still >> needed and actually used by anyone, we can add it back later once the >> license is cleared up. > > Nice, Doug and Arnd also mentioned this in the past so let me add > them to the CC as I apply this... Yes, definitely, thanks Greg for getting this done. I think every time this came up we concluded that it can be removed, we just never finished the job. Acked-by: Arnd Bergmann Link: https://lore.kernel.org/netdev/e490dd0c-a65d-4acf-89c6-c06cb48ec...@app.fastmail.com/ Link: https://lore.kernel.org/netdev/9cac4fbd-9557-b0b8-54fa-93f0290a6...@schmorgal.com/ Semi-related: Since this removes one of the two callers of the .ndo_do_ioctl() callback, I've had a new look at that bit as well and ended up with a refresh of the missing bits of [1], which I'll submit next. Arnd [1] https://lore.kernel.org/lkml/20201106221743.3271965-1-a...@kernel.org/
Re: [PATCH] net: appletalk: remove cops support
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 27 Sep 2023 11:00:30 +0200 you wrote: > The COPS Appletalk support is very old, never said to actually work > properly, and the firmware code for the devices are under a very suspect > license. Remove it all to clear up the license issue, if it is still > needed and actually used by anyone, we can add it back later once the > license is cleared up. > > Reported-by: Prarit Bhargava > Cc: Christoph Hellwig > Cc: Vitaly Kuznetsov > Cc: jsch...@samba.org > Signed-off-by: Greg Kroah-Hartman > > [...] Here is the summary with links: - net: appletalk: remove cops support https://git.kernel.org/netdev/net-next/c/00f3696f7555 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] net: appletalk: remove cops support
On Wed, 27 Sep 2023 11:00:30 +0200 Greg Kroah-Hartman wrote: > The COPS Appletalk support is very old, never said to actually work > properly, and the firmware code for the devices are under a very suspect > license. Remove it all to clear up the license issue, if it is still > needed and actually used by anyone, we can add it back later once the > license is cleared up. Nice, Doug and Arnd also mentioned this in the past so let me add them to the CC as I apply this...
Re: [PATCH] net: appletalk: remove cops support
Greg Kroah-Hartman writes: > The COPS Appletalk support is very old, never said to actually work > properly, and the firmware code for the devices are under a very suspect > license. Remove it all to clear up the license issue, if it is still > needed and actually used by anyone, we can add it back later once the > license is cleared up. > > Reported-by: Prarit Bhargava > Cc: Christoph Hellwig > Cc: Vitaly Kuznetsov FWIW, Reviewed-by: Vitaly Kuznetsov > Cc: jsch...@samba.org > Signed-off-by: Greg Kroah-Hartman > --- > .../device_drivers/appletalk/cops.rst | 80 -- > .../device_drivers/appletalk/index.rst| 18 - > .../networking/device_drivers/index.rst |1 - > drivers/net/Space.c |6 - > drivers/net/appletalk/Kconfig | 30 - > drivers/net/appletalk/Makefile|1 - > drivers/net/appletalk/cops.c | 1005 - > drivers/net/appletalk/cops.h | 61 - > drivers/net/appletalk/cops_ffdrv.h| 532 - > drivers/net/appletalk/cops_ltdrv.h| 241 > include/net/Space.h |1 - > 11 files changed, 1976 deletions(-) > delete mode 100644 Documentation/networking/device_drivers/appletalk/cops.rst > delete mode 100644 > Documentation/networking/device_drivers/appletalk/index.rst > delete mode 100644 drivers/net/appletalk/cops.c > delete mode 100644 drivers/net/appletalk/cops.h > delete mode 100644 drivers/net/appletalk/cops_ffdrv.h > delete mode 100644 drivers/net/appletalk/cops_ltdrv.h > > diff --git a/Documentation/networking/device_drivers/appletalk/cops.rst > b/Documentation/networking/device_drivers/appletalk/cops.rst > deleted file mode 100644 > index 964ba80599a9.. > --- a/Documentation/networking/device_drivers/appletalk/cops.rst > +++ /dev/null > @@ -1,80 +0,0 @@ > -.. SPDX-License-Identifier: GPL-2.0 > - > - > -The COPS LocalTalk Linux driver (cops.c) > - > - > -By Jay Schulist > - > -This driver has two modes and they are: Dayna mode and Tangent mode. > -Each mode corresponds with the type of card. It has been found > -that there are 2 main types of cards and all other cards are > -the same and just have different names or only have minor differences > -such as more IO ports. As this driver is tested it will > -become more clear exactly what cards are supported. > - > -Right now these cards are known to work with the COPS driver. The > -LT-200 cards work in a somewhat more limited capacity than the > -DL200 cards, which work very well and are in use by many people. > - > -TANGENT driver mode: > - - Tangent ATB-II, Novell NL-1000, Daystar Digital LT-200 > - > -DAYNA driver mode: > - - Dayna DL2000/DaynaTalk PC (Half Length), COPS LT-95, > - - Farallon PhoneNET PC III, Farallon PhoneNET PC II > - > -Other cards possibly supported mode unknown though: > - - Dayna DL2000 (Full length) > - > -The COPS driver defaults to using Dayna mode. To change the driver's > -mode if you built a driver with dual support use board_type=1 or > -board_type=2 for Dayna or Tangent with insmod. > - > -Operation/loading of the driver > -=== > - > -Use modprobe like this: /sbin/modprobe cops.o (IO #) (IRQ #) > -If you do not specify any options the driver will try and use the IO = 0x240, > -IRQ = 5. As of right now I would only use IRQ 5 for the card, if autoprobing. > - > -To load multiple COPS driver Localtalk cards you can do one of the > following:: > - > - insmod cops io=0x240 irq=5 > - insmod -o cops2 cops io=0x260 irq=3 > - > -Or in lilo.conf put something like this:: > - > - append="ether=5,0x240,lt0 ether=3,0x260,lt1" > - > -Then bring up the interface with ifconfig. It will look something like this:: > - > - lt0 Link encap:UNSPEC HWaddr > 00-00-00-00-00-00-00-F7-00-00-00-00-00-00-00-00 > - inet addr:192.168.1.2 Bcast:192.168.1.255 Mask:255.255.255.0 > - UP BROADCAST RUNNING NOARP MULTICAST MTU:600 Metric:1 > - RX packets:0 errors:0 dropped:0 overruns:0 frame:0 > - TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 coll:0 > - > -Netatalk Configuration > -== > - > -You will need to configure atalkd with something like the following to make > -it work with the cops.c driver. > - > -* For single LTalk card use:: > - > -dummy -seed -phase 2 -net 2000 -addr 2000.10 -zone "1033" > -lt0 -seed -phase 1 -net 1000 -addr 1000.50 -zone "1033" > - > -* For multiple cards, Ethernet and LocalTalk:: > - > -eth0 -seed -phase 2 -net 3000 -addr 3000.20 -zone "1033" > -lt0 -seed -phase 1 -net 1000 -addr 1000.50 -zone "1033" > - > -* For multiple LocalTalk cards, and an Ethernet card. > - > -* Order seems to matter here, Ethernet last:: > - > -lt0 -seed -phase 1 -net 1000 -addr 1000.10
Re: [PATCH] net: appletalk: remove cops support
On 9/27/23 05:26, Christoph Hellwig wrote: On Wed, Sep 27, 2023 at 11:00:30AM +0200, Greg Kroah-Hartman wrote: The COPS Appletalk support is very old, never said to actually work properly, and the firmware code for the devices are under a very suspect license. Remove it all to clear up the license issue, if it is still needed and actually used by anyone, we can add it back later once the license is cleared up. Looks good: Acked-by: Christoph Hellwig Ditto. Acked-by: Prarit Bhargava P.
Re: [PATCH] net: appletalk: remove cops support
On Wed, Sep 27, 2023 at 11:00:30AM +0200, Greg Kroah-Hartman wrote: > The COPS Appletalk support is very old, never said to actually work > properly, and the firmware code for the devices are under a very suspect > license. Remove it all to clear up the license issue, if it is still > needed and actually used by anyone, we can add it back later once the > license is cleared up. Looks good: Acked-by: Christoph Hellwig
[PATCH] net: appletalk: remove cops support
The COPS Appletalk support is very old, never said to actually work properly, and the firmware code for the devices are under a very suspect license. Remove it all to clear up the license issue, if it is still needed and actually used by anyone, we can add it back later once the license is cleared up. Reported-by: Prarit Bhargava Cc: Christoph Hellwig Cc: Vitaly Kuznetsov Cc: jsch...@samba.org Signed-off-by: Greg Kroah-Hartman --- .../device_drivers/appletalk/cops.rst | 80 -- .../device_drivers/appletalk/index.rst| 18 - .../networking/device_drivers/index.rst |1 - drivers/net/Space.c |6 - drivers/net/appletalk/Kconfig | 30 - drivers/net/appletalk/Makefile|1 - drivers/net/appletalk/cops.c | 1005 - drivers/net/appletalk/cops.h | 61 - drivers/net/appletalk/cops_ffdrv.h| 532 - drivers/net/appletalk/cops_ltdrv.h| 241 include/net/Space.h |1 - 11 files changed, 1976 deletions(-) delete mode 100644 Documentation/networking/device_drivers/appletalk/cops.rst delete mode 100644 Documentation/networking/device_drivers/appletalk/index.rst delete mode 100644 drivers/net/appletalk/cops.c delete mode 100644 drivers/net/appletalk/cops.h delete mode 100644 drivers/net/appletalk/cops_ffdrv.h delete mode 100644 drivers/net/appletalk/cops_ltdrv.h diff --git a/Documentation/networking/device_drivers/appletalk/cops.rst b/Documentation/networking/device_drivers/appletalk/cops.rst deleted file mode 100644 index 964ba80599a9.. --- a/Documentation/networking/device_drivers/appletalk/cops.rst +++ /dev/null @@ -1,80 +0,0 @@ -.. SPDX-License-Identifier: GPL-2.0 - - -The COPS LocalTalk Linux driver (cops.c) - - -By Jay Schulist - -This driver has two modes and they are: Dayna mode and Tangent mode. -Each mode corresponds with the type of card. It has been found -that there are 2 main types of cards and all other cards are -the same and just have different names or only have minor differences -such as more IO ports. As this driver is tested it will -become more clear exactly what cards are supported. - -Right now these cards are known to work with the COPS driver. The -LT-200 cards work in a somewhat more limited capacity than the -DL200 cards, which work very well and are in use by many people. - -TANGENT driver mode: - - Tangent ATB-II, Novell NL-1000, Daystar Digital LT-200 - -DAYNA driver mode: - - Dayna DL2000/DaynaTalk PC (Half Length), COPS LT-95, - - Farallon PhoneNET PC III, Farallon PhoneNET PC II - -Other cards possibly supported mode unknown though: - - Dayna DL2000 (Full length) - -The COPS driver defaults to using Dayna mode. To change the driver's -mode if you built a driver with dual support use board_type=1 or -board_type=2 for Dayna or Tangent with insmod. - -Operation/loading of the driver -=== - -Use modprobe like this:/sbin/modprobe cops.o (IO #) (IRQ #) -If you do not specify any options the driver will try and use the IO = 0x240, -IRQ = 5. As of right now I would only use IRQ 5 for the card, if autoprobing. - -To load multiple COPS driver Localtalk cards you can do one of the following:: - - insmod cops io=0x240 irq=5 - insmod -o cops2 cops io=0x260 irq=3 - -Or in lilo.conf put something like this:: - - append="ether=5,0x240,lt0 ether=3,0x260,lt1" - -Then bring up the interface with ifconfig. It will look something like this:: - - lt0 Link encap:UNSPEC HWaddr 00-00-00-00-00-00-00-F7-00-00-00-00-00-00-00-00 - inet addr:192.168.1.2 Bcast:192.168.1.255 Mask:255.255.255.0 - UP BROADCAST RUNNING NOARP MULTICAST MTU:600 Metric:1 - RX packets:0 errors:0 dropped:0 overruns:0 frame:0 - TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 coll:0 - -Netatalk Configuration -== - -You will need to configure atalkd with something like the following to make -it work with the cops.c driver. - -* For single LTalk card use:: - -dummy -seed -phase 2 -net 2000 -addr 2000.10 -zone "1033" -lt0 -seed -phase 1 -net 1000 -addr 1000.50 -zone "1033" - -* For multiple cards, Ethernet and LocalTalk:: - -eth0 -seed -phase 2 -net 3000 -addr 3000.20 -zone "1033" -lt0 -seed -phase 1 -net 1000 -addr 1000.50 -zone "1033" - -* For multiple LocalTalk cards, and an Ethernet card. - -* Order seems to matter here, Ethernet last:: - -lt0 -seed -phase 1 -net 1000 -addr 1000.10 -zone "LocalTalk1" -lt1 -seed -phase 1 -net 2000 -addr 2000.20 -zone "LocalTalk2" -eth0 -seed -phase 2 -net 3000 -addr 3000.30 -zone "EtherTalk" diff --git a/Documentation/networking/device_drivers/appletalk/index.rst
