Re: [PATCH] net: ethernet: dec: tulip: Random spelling fixes throughout the file pnic2.c

2021-03-11 Thread Randy Dunlap
On 3/11/21 11:05 PM, Bhaskar Chowdhury wrote:
> 
> Random spelling fixes throughout the file.
> 
> Signed-off-by: Bhaskar Chowdhury 
> ---
>  drivers/net/ethernet/dec/tulip/pnic2.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/dec/tulip/pnic2.c 
> b/drivers/net/ethernet/dec/tulip/pnic2.c
> index 412adaa7fdf8..04daffb8db2a 100644
> --- a/drivers/net/ethernet/dec/tulip/pnic2.c
> +++ b/drivers/net/ethernet/dec/tulip/pnic2.c
> @@ -107,7 +107,7 @@ void pnic2_start_nway(struct net_device *dev)
>   */
>   csr14 = (ioread32(ioaddr + CSR14) & 0xfff0ee39);
> 
> -/* bit 17 - advetise 100baseTx-FD */
> +/* bit 17 - advertise 100baseTx-FD */

OK above. But:
https://en.wikipedia.org/wiki/Autonegotiation

>  if (tp->sym_advertise & 0x0100) csr14 |= 0x0002;
> 
>  /* bit 16 - advertise 100baseTx-HD */
> @@ -116,7 +116,7 @@ void pnic2_start_nway(struct net_device *dev)
>  /* bit 6 - advertise 10baseT-HD */
>  if (tp->sym_advertise & 0x0020) csr14 |= 0x0040;
> 
> -/* Now set bit 12 Link Test Enable, Bit 7 Autonegotiation Enable
> +/* Now set bit 12 Link Test Enable, Bit 7 Auto negotiation Enable
>   * and bit 0 Don't PowerDown 10baseT
>   */
>  csr14 |= 0x1184;
> @@ -157,7 +157,7 @@ void pnic2_start_nway(struct net_device *dev)
>  /* all set up so now force the negotiation to begin */
> 
>  /* read in current values and mask off all but the
> -  * Autonegotiation bits 14:12.  Writing a 001 to those bits
> +  * Auto negotiation bits 14:12.  Writing a 001 to those bits
>   * should start the autonegotiation
>   */
>  csr12 = (ioread32(ioaddr + CSR12) & 0x8fff);
> @@ -290,7 +290,7 @@ void pnic2_lnk_change(struct net_device *dev, int csr5)
>   csr14 = (ioread32(ioaddr + CSR14) & 0xff7f);
>  iowrite32(csr14,ioaddr + CSR14);
> 
> -/* what should we do when autonegotiate fails?
> +/* what should we do when auto negotiate fails?
>   * should we try again or default to baseline
>   * case.  I just don't know.
>   *
> --


-- 
~Randy



[PATCH] net: ethernet: dec: tulip: Random spelling fixes throughout the file pnic2.c

2021-03-11 Thread Bhaskar Chowdhury


Random spelling fixes throughout the file.

Signed-off-by: Bhaskar Chowdhury 
---
 drivers/net/ethernet/dec/tulip/pnic2.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/dec/tulip/pnic2.c 
b/drivers/net/ethernet/dec/tulip/pnic2.c
index 412adaa7fdf8..04daffb8db2a 100644
--- a/drivers/net/ethernet/dec/tulip/pnic2.c
+++ b/drivers/net/ethernet/dec/tulip/pnic2.c
@@ -107,7 +107,7 @@ void pnic2_start_nway(struct net_device *dev)
  */
csr14 = (ioread32(ioaddr + CSR14) & 0xfff0ee39);

-/* bit 17 - advetise 100baseTx-FD */
+/* bit 17 - advertise 100baseTx-FD */
 if (tp->sym_advertise & 0x0100) csr14 |= 0x0002;

 /* bit 16 - advertise 100baseTx-HD */
@@ -116,7 +116,7 @@ void pnic2_start_nway(struct net_device *dev)
 /* bit 6 - advertise 10baseT-HD */
 if (tp->sym_advertise & 0x0020) csr14 |= 0x0040;

-/* Now set bit 12 Link Test Enable, Bit 7 Autonegotiation Enable
+/* Now set bit 12 Link Test Enable, Bit 7 Auto negotiation Enable
  * and bit 0 Don't PowerDown 10baseT
  */
 csr14 |= 0x1184;
@@ -157,7 +157,7 @@ void pnic2_start_nway(struct net_device *dev)
 /* all set up so now force the negotiation to begin */

 /* read in current values and mask off all but the
-* Autonegotiation bits 14:12.  Writing a 001 to those bits
+* Auto negotiation bits 14:12.  Writing a 001 to those bits
  * should start the autonegotiation
  */
 csr12 = (ioread32(ioaddr + CSR12) & 0x8fff);
@@ -290,7 +290,7 @@ void pnic2_lnk_change(struct net_device *dev, int csr5)
csr14 = (ioread32(ioaddr + CSR14) & 0xff7f);
 iowrite32(csr14,ioaddr + CSR14);

-/* what should we do when autonegotiate fails?
+/* what should we do when auto negotiate fails?
  * should we try again or default to baseline
  * case.  I just don't know.
  *
--
2.26.2