Re: [PATCH] nvme-pci: use standard block status symbolic names to check return value

[Baolin Wang]

On Wed, Jul 08, 2020 at 07:09:00AM +0200, Christoph Hellwig wrote:
> On Wed, Jul 08, 2020 at 10:18:01AM +0800, Baolin Wang wrote:
> > It's better to use the same symbol as the return to check return value,
> > and will always work in the unlikely event that the defines are reordered.
> > 
> > Suggested-by: Keith Busch 
> > Signed-off-by: Baolin Wang 
> 
> I'm really not sure this is worth it.  When designing the blk_status_t
> type keeping 0 as was a deliberate design decision.

OK. But there are some places use the BLK_STS_OK to validate, and some
places not in this driver, so I think we should keep code consistent?

Re: [PATCH] nvme-pci: use standard block status symbolic names to check return value

[Christoph Hellwig]

On Wed, Jul 08, 2020 at 10:18:01AM +0800, Baolin Wang wrote:
> It's better to use the same symbol as the return to check return value,
> and will always work in the unlikely event that the defines are reordered.
> 
> Suggested-by: Keith Busch 
> Signed-off-by: Baolin Wang 

I'm really not sure this is worth it.  When designing the blk_status_t
type keeping 0 as was a deliberate design decision. 

[PATCH] nvme-pci: use standard block status symbolic names to check return value

[Baolin Wang]

It's better to use the same symbol as the return to check return value,
and will always work in the unlikely event that the defines are reordered.

Suggested-by: Keith Busch 
Signed-off-by: Baolin Wang 
---
 drivers/nvme/host/pci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1ac0717..45cb59c 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -873,18 +873,18 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx 
*hctx,
return BLK_STS_IOERR;
 
ret = nvme_setup_cmd(ns, req, );
-   if (ret)
+   if (ret != BLK_STS_OK)
return ret;
 
if (blk_rq_nr_phys_segments(req)) {
ret = nvme_map_data(dev, req, );
-   if (ret)
+   if (ret != BLK_STS_OK)
goto out_free_cmd;
}
 
if (blk_integrity_rq(req)) {
ret = nvme_map_metadata(dev, req, );
-   if (ret)
+   if (ret != BLK_STS_OK)
goto out_unmap_data;
}
 
-- 
1.8.3.1