Re: [PATCH] of: dma.c: fix memory leakage
On Wed, Feb 13, 2013 at 12:26:23PM +0100, Cong Ding wrote: > > > > You need to send this to whomever is working on DMA bindings. > > > Thank you bob, I added Vinod the the receiver list. > > I have moved the of/dma.c to dma/of-dma.c, can you regenerate this patch and > > resend to me > Sorry Vinod, I didn't manage to get this commit from either linux-next tree or > slave-dma tree, and the last commit by you for of/dma.c file is on Jan 7. Did > you have any hints for me to get the latest version dma/of-dma.c? AH my bad, seems i have not pushed it out :( Pushed now... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of: dma.c: fix memory leakage
On Tue, Feb 12, 2013 at 09:40:25AM -0800, Vinod Koul wrote: > On Tue, Jan 22, 2013 at 10:10:53AM +, Cong Ding wrote: > > On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote: > > > On 01/19/2013 07:06 AM, Cong Ding wrote: > > > > The memory allocated to ofdma might be a leakage when error occurs. > > > > > > > > Signed-off-by: Cong Ding > > > > > > You need to send this to whomever is working on DMA bindings. > > Thank you bob, I added Vinod the the receiver list. > I have moved the of/dma.c to dma/of-dma.c, can you regenerate this patch and > resend to me Sorry Vinod, I didn't manage to get this commit from either linux-next tree or slave-dma tree, and the last commit by you for of/dma.c file is on Jan 7. Did you have any hints for me to get the latest version dma/of-dma.c? - cong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of: dma.c: fix memory leakage
On Tue, Feb 12, 2013 at 09:40:25AM -0800, Vinod Koul wrote: On Tue, Jan 22, 2013 at 10:10:53AM +, Cong Ding wrote: On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote: On 01/19/2013 07:06 AM, Cong Ding wrote: The memory allocated to ofdma might be a leakage when error occurs. Signed-off-by: Cong Ding ding...@gmail.com You need to send this to whomever is working on DMA bindings. Thank you bob, I added Vinod the the receiver list. I have moved the of/dma.c to dma/of-dma.c, can you regenerate this patch and resend to me Sorry Vinod, I didn't manage to get this commit from either linux-next tree or slave-dma tree, and the last commit by you for of/dma.c file is on Jan 7. Did you have any hints for me to get the latest version dma/of-dma.c? - cong -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of: dma.c: fix memory leakage
On Wed, Feb 13, 2013 at 12:26:23PM +0100, Cong Ding wrote: You need to send this to whomever is working on DMA bindings. Thank you bob, I added Vinod the the receiver list. I have moved the of/dma.c to dma/of-dma.c, can you regenerate this patch and resend to me Sorry Vinod, I didn't manage to get this commit from either linux-next tree or slave-dma tree, and the last commit by you for of/dma.c file is on Jan 7. Did you have any hints for me to get the latest version dma/of-dma.c? AH my bad, seems i have not pushed it out :( Pushed now... -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of: dma.c: fix memory leakage
On Tue, Jan 22, 2013 at 10:10:53AM +, Cong Ding wrote: > On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote: > > On 01/19/2013 07:06 AM, Cong Ding wrote: > > > The memory allocated to ofdma might be a leakage when error occurs. > > > > > > Signed-off-by: Cong Ding > > > > You need to send this to whomever is working on DMA bindings. > Thank you bob, I added Vinod the the receiver list. I have moved the of/dma.c to dma/of-dma.c, can you regenerate this patch and resend to me -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of: dma.c: fix memory leakage
On Tue, Jan 22, 2013 at 10:10:53AM +, Cong Ding wrote: On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote: On 01/19/2013 07:06 AM, Cong Ding wrote: The memory allocated to ofdma might be a leakage when error occurs. Signed-off-by: Cong Ding ding...@gmail.com You need to send this to whomever is working on DMA bindings. Thank you bob, I added Vinod the the receiver list. I have moved the of/dma.c to dma/of-dma.c, can you regenerate this patch and resend to me -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of: dma.c: fix memory leakage
On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote:
> On 01/19/2013 07:06 AM, Cong Ding wrote:
> > The memory allocated to ofdma might be a leakage when error occurs.
> >
> > Signed-off-by: Cong Ding
>
> You need to send this to whomever is working on DMA bindings.
Thank you bob, I added Vinod the the receiver list.
- cong
>
> > ---
> > drivers/of/dma.c |1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/of/dma.c b/drivers/of/dma.c
> > index 59631b2..583e50e3 100644
> > --- a/drivers/of/dma.c
> > +++ b/drivers/of/dma.c
> > @@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
> > if (!nbcells) {
> > pr_err("%s: #dma-cells property is missing or invalid\n",
> >__func__);
> > + kfree(ofdma);
> > return -EINVAL;
> > }
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of: dma.c: fix memory leakage
On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote:
On 01/19/2013 07:06 AM, Cong Ding wrote:
The memory allocated to ofdma might be a leakage when error occurs.
Signed-off-by: Cong Ding ding...@gmail.com
You need to send this to whomever is working on DMA bindings.
Thank you bob, I added Vinod the the receiver list.
- cong
---
drivers/of/dma.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/dma.c b/drivers/of/dma.c
index 59631b2..583e50e3 100644
--- a/drivers/of/dma.c
+++ b/drivers/of/dma.c
@@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
if (!nbcells) {
pr_err(%s: #dma-cells property is missing or invalid\n,
__func__);
+ kfree(ofdma);
return -EINVAL;
}
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of: dma.c: fix memory leakage
On 01/19/2013 07:06 AM, Cong Ding wrote:
> The memory allocated to ofdma might be a leakage when error occurs.
>
> Signed-off-by: Cong Ding
You need to send this to whomever is working on DMA bindings.
Rob
> ---
> drivers/of/dma.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/dma.c b/drivers/of/dma.c
> index 59631b2..583e50e3 100644
> --- a/drivers/of/dma.c
> +++ b/drivers/of/dma.c
> @@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
> if (!nbcells) {
> pr_err("%s: #dma-cells property is missing or invalid\n",
> __func__);
> + kfree(ofdma);
> return -EINVAL;
> }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] of: dma.c: fix memory leakage
On 01/19/2013 07:06 AM, Cong Ding wrote:
The memory allocated to ofdma might be a leakage when error occurs.
Signed-off-by: Cong Ding ding...@gmail.com
You need to send this to whomever is working on DMA bindings.
Rob
---
drivers/of/dma.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/dma.c b/drivers/of/dma.c
index 59631b2..583e50e3 100644
--- a/drivers/of/dma.c
+++ b/drivers/of/dma.c
@@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
if (!nbcells) {
pr_err(%s: #dma-cells property is missing or invalid\n,
__func__);
+ kfree(ofdma);
return -EINVAL;
}
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] of: dma.c: fix memory leakage
The memory allocated to ofdma might be a leakage when error occurs.
Signed-off-by: Cong Ding
---
drivers/of/dma.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/dma.c b/drivers/of/dma.c
index 59631b2..583e50e3 100644
--- a/drivers/of/dma.c
+++ b/drivers/of/dma.c
@@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
if (!nbcells) {
pr_err("%s: #dma-cells property is missing or invalid\n",
__func__);
+ kfree(ofdma);
return -EINVAL;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] of: dma.c: fix memory leakage
The memory allocated to ofdma might be a leakage when error occurs.
Signed-off-by: Cong Ding ding...@gmail.com
---
drivers/of/dma.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/dma.c b/drivers/of/dma.c
index 59631b2..583e50e3 100644
--- a/drivers/of/dma.c
+++ b/drivers/of/dma.c
@@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
if (!nbcells) {
pr_err(%s: #dma-cells property is missing or invalid\n,
__func__);
+ kfree(ofdma);
return -EINVAL;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
