Re: [PATCH] os_dep: Replace rcu_dereference() with rcu_access_pointer()
On Sun, Aug 17, 2014 at 04:39:16PM +0300, Andreea-Cristina Bernat wrote:
> The "rcu_dereference()" call is used directly in a condition.
> Since its return value is never dereferenced it is recommended to use
> "rcu_access_pointer()" instead of "rcu_dereference()".
> Therefore, this patch makes the replacement.
>
> The following Coccinelle semantic patch was used:
> @@
> @@
>
> (
> if(
> (<+...
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> |
> while(
> (<+...
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> )
>
> Signed-off-by: Andreea-Cristina Bernat
> ---
> drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This also doesn't apply :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] os_dep: Replace rcu_dereference() with rcu_access_pointer()
On Sun, Aug 17, 2014 at 04:39:16PM +0300, Andreea-Cristina Bernat wrote:
The rcu_dereference() call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
rcu_access_pointer() instead of rcu_dereference().
Therefore, this patch makes the replacement.
The following Coccinelle semantic patch was used:
@@
@@
(
if(
(+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+)) {...}
|
while(
(+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+)) {...}
)
Signed-off-by: Andreea-Cristina Bernat bernat@gmail.com
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This also doesn't apply :(
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] os_dep: Replace rcu_dereference() with rcu_access_pointer()
The "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes the replacement.
The following Coccinelle semantic patch was used:
@@
@@
(
if(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
|
while(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
)
Signed-off-by: Andreea-Cristina Bernat
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 0e0c32d..4bb76e5 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -1010,7 +1010,7 @@ void netdev_br_init(struct net_device *netdev)
rcu_read_lock();
- if (rcu_dereference(adapter->pnetdev->rx_handler_data)) {
+ if (rcu_access_pointer(adapter->pnetdev->rx_handler_data)) {
struct net_device *br_netdev;
struct net *devnet = NULL;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] os_dep: Replace rcu_dereference() with rcu_access_pointer()
The rcu_dereference() call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
rcu_access_pointer() instead of rcu_dereference().
Therefore, this patch makes the replacement.
The following Coccinelle semantic patch was used:
@@
@@
(
if(
(+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+)) {...}
|
while(
(+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+)) {...}
)
Signed-off-by: Andreea-Cristina Bernat bernat@gmail.com
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 0e0c32d..4bb76e5 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -1010,7 +1010,7 @@ void netdev_br_init(struct net_device *netdev)
rcu_read_lock();
- if (rcu_dereference(adapter-pnetdev-rx_handler_data)) {
+ if (rcu_access_pointer(adapter-pnetdev-rx_handler_data)) {
struct net_device *br_netdev;
struct net *devnet = NULL;
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
