Re: [PATCH] pci: iproc: fix PCIE_IPROC in Kconfig
Hi Bjorn, On 3/24/2015 5:28 PM, Bjorn Helgaas wrote: > On Tue, Mar 24, 2015 at 12:33 AM, Ray Jui wrote: >> Make PCIE_IPROC depending on both OF and ARM and default to be disabled, >> so it cannot be accidentally enabled by other platforms >> >> PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly >> it's enabled by PCIE_IPROC_PLTFM driver >> >> Signed-off-by: Ray Jui >> >> drivers/pci/host/Kconfig |2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig >> index feccd0d..963b507 100644 >> --- a/drivers/pci/host/Kconfig >> +++ b/drivers/pci/host/Kconfig >> @@ -108,6 +108,8 @@ config PCI_VERSATILE >> >> config PCIE_IPROC >> tristate "Broadcom iProc PCIe controller" >> + depends on OF && ARM >> + default n >> help >> This enables the iProc PCIe core controller support for Broadcom's >> iProc family of SoCs. An appropriate bus interface driver also >> needs > > What pattern are you following? There must be other drivers with > similar front-end bus driver schemes, and I'd rather copy their > Kconfig descriptions than invent something new. I'm not aware of other drivers using a similar model to support different front-end bus interfaces. Note this is requested by Arnd Bergmann to support a normal platform bus interface and a BCMA bus interface, which is quite unique. PCIE_DW may be close in a way in terms of how the core code are retained in PCIE_DW driver with PCI_EXYNOS, PCI_IMX6, and etc. to take care of SoC specific things. Note PCIE_DW currently has no Kconfig descriptions. > > With CONFIG_PCIE_IPROC_PLTFM, can we spell out "PLATFORM"? Doesn't > seem like there's anything to gain by abbreviating it. Sure. I'll submit a new patch series, which will contain this patch, and another patch on top, to change from CONFIG_PCIE_IPROC_PLTFM to CONFIG_PCIE_IPROC_PLATFORM. > > Bjorn > Thanks, Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pci: iproc: fix PCIE_IPROC in Kconfig
On Tue, Mar 24, 2015 at 12:33 AM, Ray Jui wrote: > Make PCIE_IPROC depending on both OF and ARM and default to be disabled, > so it cannot be accidentally enabled by other platforms > > PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly > it's enabled by PCIE_IPROC_PLTFM driver > > Signed-off-by: Ray Jui > --- > drivers/pci/host/Kconfig |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > index feccd0d..963b507 100644 > --- a/drivers/pci/host/Kconfig > +++ b/drivers/pci/host/Kconfig > @@ -108,6 +108,8 @@ config PCI_VERSATILE > > config PCIE_IPROC > tristate "Broadcom iProc PCIe controller" > + depends on OF && ARM > + default n > help > This enables the iProc PCIe core controller support for Broadcom's > iProc family of SoCs. An appropriate bus interface driver also needs What pattern are you following? There must be other drivers with similar front-end bus driver schemes, and I'd rather copy their Kconfig descriptions than invent something new. With CONFIG_PCIE_IPROC_PLTFM, can we spell out "PLATFORM"? Doesn't seem like there's anything to gain by abbreviating it. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] pci: iproc: fix PCIE_IPROC in Kconfig
Make PCIE_IPROC depending on both OF and ARM and default to be disabled, so it cannot be accidentally enabled by other platforms PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly it's enabled by PCIE_IPROC_PLTFM driver Signed-off-by: Ray Jui --- drivers/pci/host/Kconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index feccd0d..963b507 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -108,6 +108,8 @@ config PCI_VERSATILE config PCIE_IPROC tristate "Broadcom iProc PCIe controller" + depends on OF && ARM + default n help This enables the iProc PCIe core controller support for Broadcom's iProc family of SoCs. An appropriate bus interface driver also needs -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
