Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-24 Thread Kishon Vijay Abraham I 
Greg,

On Thursday 24 August 2017 05:00 AM, Greg Kroah-Hartman wrote:
> On Wed, Aug 23, 2017 at 07:50:46PM +0530, Kishon Vijay Abraham I wrote:
>> Greg,
>>
>> On Wednesday 23 August 2017 07:09 PM, Arnd Bergmann wrote:
>>> Casting between an 'int' and a pointer causes a warning on
>>> 64-bit architectures in compile-testing this driver:
>>>
>>> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
>>> drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to 
>>> integer of different size [-Werror=pointer-to-int-cast]
>>>
>>> This changes the code to cast to uintptr_t instead. This is
>>> guaranteed to do what we want on all architectures and avoids
>>> the warning.
>>>
>>> Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
>>> Signed-off-by: Arnd Bergmann 
>>
>> Can you pick this patch to fix the compiler warning.
> 
> Can you resend it to me in a format that I can apply it in?

sent them now.

Thanks
Kishon

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-24 Thread Kishon Vijay Abraham I 
Greg,

On Thursday 24 August 2017 05:00 AM, Greg Kroah-Hartman wrote:
> On Wed, Aug 23, 2017 at 07:50:46PM +0530, Kishon Vijay Abraham I wrote:
>> Greg,
>>
>> On Wednesday 23 August 2017 07:09 PM, Arnd Bergmann wrote:
>>> Casting between an 'int' and a pointer causes a warning on
>>> 64-bit architectures in compile-testing this driver:
>>>
>>> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
>>> drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to 
>>> integer of different size [-Werror=pointer-to-int-cast]
>>>
>>> This changes the code to cast to uintptr_t instead. This is
>>> guaranteed to do what we want on all architectures and avoids
>>> the warning.
>>>
>>> Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
>>> Signed-off-by: Arnd Bergmann 
>>
>> Can you pick this patch to fix the compiler warning.
> 
> Can you resend it to me in a format that I can apply it in?

sent them now.

Thanks
Kishon

[PATCH] phy: ralink: fix 64-bit build warning

2017-08-24 Thread Kishon Vijay Abraham I 
From: Arnd Bergmann 

Casting between an 'int' and a pointer causes a warning on
64-bit architectures in compile-testing this driver:

drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to
integer of different size [-Werror=pointer-to-int-cast]

This changes the code to cast to uintptr_t instead. This is
guaranteed to do what we want on all architectures and avoids
the warning.

Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
Acked-by: John Crispin 
Tested-by Harvey Hunt 
Reviewed-by Harvey Hunt 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Kishon Vijay Abraham I 
---
 drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
b/drivers/phy/ralink/phy-ralink-usb.c
index d19088c0ce5c..4fea31f8ac1c 100644
--- a/drivers/phy/ralink/phy-ralink-usb.c
+++ b/drivers/phy/ralink/phy-ralink-usb.c
@@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
 static const struct of_device_id ralink_usb_phy_of_match[] = {
{
.compatible = "ralink,rt3352-usbphy",
-   .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
- RT_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
+   RT_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7620-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7628-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN) },
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN) },
{ },
 };
 MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
@@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
*pdev)
if (!phy)
return -ENOMEM;
 
-   phy->clk = (u32) match->data;
+   phy->clk = (uintptr_t)match->data;
phy->base = NULL;
 
phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, 
"ralink,sysctl");
-- 
2.11.0

[PATCH] phy: ralink: fix 64-bit build warning

2017-08-24 Thread Kishon Vijay Abraham I 
From: Arnd Bergmann 

Casting between an 'int' and a pointer causes a warning on
64-bit architectures in compile-testing this driver:

drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to
integer of different size [-Werror=pointer-to-int-cast]

This changes the code to cast to uintptr_t instead. This is
guaranteed to do what we want on all architectures and avoids
the warning.

Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
Acked-by: John Crispin 
Tested-by Harvey Hunt 
Reviewed-by Harvey Hunt 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Kishon Vijay Abraham I 
---
 drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
b/drivers/phy/ralink/phy-ralink-usb.c
index d19088c0ce5c..4fea31f8ac1c 100644
--- a/drivers/phy/ralink/phy-ralink-usb.c
+++ b/drivers/phy/ralink/phy-ralink-usb.c
@@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
 static const struct of_device_id ralink_usb_phy_of_match[] = {
{
.compatible = "ralink,rt3352-usbphy",
-   .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
- RT_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
+   RT_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7620-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7628-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN) },
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN) },
{ },
 };
 MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
@@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
*pdev)
if (!phy)
return -ENOMEM;
 
-   phy->clk = (u32) match->data;
+   phy->clk = (uintptr_t)match->data;
phy->base = NULL;
 
phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, 
"ralink,sysctl");
-- 
2.11.0

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Greg Kroah-Hartman 
On Wed, Aug 23, 2017 at 07:50:46PM +0530, Kishon Vijay Abraham I wrote:
> Greg,
> 
> On Wednesday 23 August 2017 07:09 PM, Arnd Bergmann wrote:
> > Casting between an 'int' and a pointer causes a warning on
> > 64-bit architectures in compile-testing this driver:
> > 
> > drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> > drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to 
> > integer of different size [-Werror=pointer-to-int-cast]
> > 
> > This changes the code to cast to uintptr_t instead. This is
> > guaranteed to do what we want on all architectures and avoids
> > the warning.
> > 
> > Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
> > Signed-off-by: Arnd Bergmann 
> 
> Can you pick this patch to fix the compiler warning.

Can you resend it to me in a format that I can apply it in?

thanks,

greg k-h

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Greg Kroah-Hartman 
On Wed, Aug 23, 2017 at 07:50:46PM +0530, Kishon Vijay Abraham I wrote:
> Greg,
> 
> On Wednesday 23 August 2017 07:09 PM, Arnd Bergmann wrote:
> > Casting between an 'int' and a pointer causes a warning on
> > 64-bit architectures in compile-testing this driver:
> > 
> > drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> > drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to 
> > integer of different size [-Werror=pointer-to-int-cast]
> > 
> > This changes the code to cast to uintptr_t instead. This is
> > guaranteed to do what we want on all architectures and avoids
> > the warning.
> > 
> > Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
> > Signed-off-by: Arnd Bergmann 
> 
> Can you pick this patch to fix the compiler warning.

Can you resend it to me in a format that I can apply it in?

thanks,

greg k-h

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Kishon Vijay Abraham I 
Greg,

On Wednesday 23 August 2017 07:09 PM, Arnd Bergmann wrote:
> Casting between an 'int' and a pointer causes a warning on
> 64-bit architectures in compile-testing this driver:
> 
> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to 
> integer of different size [-Werror=pointer-to-int-cast]
> 
> This changes the code to cast to uintptr_t instead. This is
> guaranteed to do what we want on all architectures and avoids
> the warning.
> 
> Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
> Signed-off-by: Arnd Bergmann 

Can you pick this patch to fix the compiler warning.

Thanks
Kishon
> ---
>  drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
> b/drivers/phy/ralink/phy-ralink-usb.c
> index d19088c0ce5c..4fea31f8ac1c 100644
> --- a/drivers/phy/ralink/phy-ralink-usb.c
> +++ b/drivers/phy/ralink/phy-ralink-usb.c
> @@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
>  static const struct of_device_id ralink_usb_phy_of_match[] = {
>   {
>   .compatible = "ralink,rt3352-usbphy",
> - .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
> -   RT_CLKCFG1_UPHY0_CLK_EN)
> + .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
> + RT_CLKCFG1_UPHY0_CLK_EN)
>   },
>   {
>   .compatible = "mediatek,mt7620-usbphy",
> - .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
> -   MT7620_CLKCFG1_UPHY0_CLK_EN)
> + .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
> + MT7620_CLKCFG1_UPHY0_CLK_EN)
>   },
>   {
>   .compatible = "mediatek,mt7628-usbphy",
> - .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
> -   MT7620_CLKCFG1_UPHY0_CLK_EN) },
> + .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
> + MT7620_CLKCFG1_UPHY0_CLK_EN) },
>   { },
>  };
>  MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
> @@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
> *pdev)
>   if (!phy)
>   return -ENOMEM;
>  
> - phy->clk = (u32) match->data;
> + phy->clk = (uintptr_t)match->data;
>   phy->base = NULL;
>  
>   phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, 
> "ralink,sysctl");
>

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Kishon Vijay Abraham I 
Greg,

On Wednesday 23 August 2017 07:09 PM, Arnd Bergmann wrote:
> Casting between an 'int' and a pointer causes a warning on
> 64-bit architectures in compile-testing this driver:
> 
> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to 
> integer of different size [-Werror=pointer-to-int-cast]
> 
> This changes the code to cast to uintptr_t instead. This is
> guaranteed to do what we want on all architectures and avoids
> the warning.
> 
> Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
> Signed-off-by: Arnd Bergmann 

Can you pick this patch to fix the compiler warning.

Thanks
Kishon
> ---
>  drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
> b/drivers/phy/ralink/phy-ralink-usb.c
> index d19088c0ce5c..4fea31f8ac1c 100644
> --- a/drivers/phy/ralink/phy-ralink-usb.c
> +++ b/drivers/phy/ralink/phy-ralink-usb.c
> @@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
>  static const struct of_device_id ralink_usb_phy_of_match[] = {
>   {
>   .compatible = "ralink,rt3352-usbphy",
> - .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
> -   RT_CLKCFG1_UPHY0_CLK_EN)
> + .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
> + RT_CLKCFG1_UPHY0_CLK_EN)
>   },
>   {
>   .compatible = "mediatek,mt7620-usbphy",
> - .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
> -   MT7620_CLKCFG1_UPHY0_CLK_EN)
> + .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
> + MT7620_CLKCFG1_UPHY0_CLK_EN)
>   },
>   {
>   .compatible = "mediatek,mt7628-usbphy",
> - .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
> -   MT7620_CLKCFG1_UPHY0_CLK_EN) },
> + .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
> + MT7620_CLKCFG1_UPHY0_CLK_EN) },
>   { },
>  };
>  MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
> @@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
> *pdev)
>   if (!phy)
>   return -ENOMEM;
>  
> - phy->clk = (u32) match->data;
> + phy->clk = (uintptr_t)match->data;
>   phy->base = NULL;
>  
>   phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, 
> "ralink,sysctl");
>

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Harvey Hunt 

Hi Arnd,

On 23/08/17 14:39, Arnd Bergmann wrote:

Casting between an 'int' and a pointer causes a warning on
64-bit architectures in compile-testing this driver:

drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer 
of different size [-Werror=pointer-to-int-cast]

This changes the code to cast to uintptr_t instead. This is
guaranteed to do what we want on all architectures and avoids
the warning.

Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
Signed-off-by: Arnd Bergmann 
---
  drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
  1 file changed, 7 insertions(+), 7 deletions(-)

[...]

Thanks for fixing this - it was on my TODO list.

Tested-by Harvey Hunt 
Reviewed-by Harvey Hunt 

Thanks,

Harvey

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Harvey Hunt 

Hi Arnd,

On 23/08/17 14:39, Arnd Bergmann wrote:

Casting between an 'int' and a pointer causes a warning on
64-bit architectures in compile-testing this driver:

drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer 
of different size [-Werror=pointer-to-int-cast]

This changes the code to cast to uintptr_t instead. This is
guaranteed to do what we want on all architectures and avoids
the warning.

Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
Signed-off-by: Arnd Bergmann 
---
  drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
  1 file changed, 7 insertions(+), 7 deletions(-)

[...]

Thanks for fixing this - it was on my TODO list.

Tested-by Harvey Hunt 
Reviewed-by Harvey Hunt 

Thanks,

Harvey

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Kishon Vijay Abraham I 


On Wednesday 23 August 2017 07:09 PM, Arnd Bergmann wrote:
> Casting between an 'int' and a pointer causes a warning on
> 64-bit architectures in compile-testing this driver:
> 
> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to 
> integer of different size [-Werror=pointer-to-int-cast]
> 
> This changes the code to cast to uintptr_t instead. This is
> guaranteed to do what we want on all architectures and avoids
> the warning.
> 
> Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
> Signed-off-by: Arnd Bergmann 

Acked-by: Kishon Vijay Abraham I 
> ---
>  drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
> b/drivers/phy/ralink/phy-ralink-usb.c
> index d19088c0ce5c..4fea31f8ac1c 100644
> --- a/drivers/phy/ralink/phy-ralink-usb.c
> +++ b/drivers/phy/ralink/phy-ralink-usb.c
> @@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
>  static const struct of_device_id ralink_usb_phy_of_match[] = {
>   {
>   .compatible = "ralink,rt3352-usbphy",
> - .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
> -   RT_CLKCFG1_UPHY0_CLK_EN)
> + .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
> + RT_CLKCFG1_UPHY0_CLK_EN)
>   },
>   {
>   .compatible = "mediatek,mt7620-usbphy",
> - .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
> -   MT7620_CLKCFG1_UPHY0_CLK_EN)
> + .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
> + MT7620_CLKCFG1_UPHY0_CLK_EN)
>   },
>   {
>   .compatible = "mediatek,mt7628-usbphy",
> - .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
> -   MT7620_CLKCFG1_UPHY0_CLK_EN) },
> + .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
> + MT7620_CLKCFG1_UPHY0_CLK_EN) },
>   { },
>  };
>  MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
> @@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
> *pdev)
>   if (!phy)
>   return -ENOMEM;
>  
> - phy->clk = (u32) match->data;
> + phy->clk = (uintptr_t)match->data;
>   phy->base = NULL;
>  
>   phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, 
> "ralink,sysctl");
>

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Kishon Vijay Abraham I 


On Wednesday 23 August 2017 07:09 PM, Arnd Bergmann wrote:
> Casting between an 'int' and a pointer causes a warning on
> 64-bit architectures in compile-testing this driver:
> 
> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to 
> integer of different size [-Werror=pointer-to-int-cast]
> 
> This changes the code to cast to uintptr_t instead. This is
> guaranteed to do what we want on all architectures and avoids
> the warning.
> 
> Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
> Signed-off-by: Arnd Bergmann 

Acked-by: Kishon Vijay Abraham I 
> ---
>  drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
> b/drivers/phy/ralink/phy-ralink-usb.c
> index d19088c0ce5c..4fea31f8ac1c 100644
> --- a/drivers/phy/ralink/phy-ralink-usb.c
> +++ b/drivers/phy/ralink/phy-ralink-usb.c
> @@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
>  static const struct of_device_id ralink_usb_phy_of_match[] = {
>   {
>   .compatible = "ralink,rt3352-usbphy",
> - .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
> -   RT_CLKCFG1_UPHY0_CLK_EN)
> + .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
> + RT_CLKCFG1_UPHY0_CLK_EN)
>   },
>   {
>   .compatible = "mediatek,mt7620-usbphy",
> - .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
> -   MT7620_CLKCFG1_UPHY0_CLK_EN)
> + .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
> + MT7620_CLKCFG1_UPHY0_CLK_EN)
>   },
>   {
>   .compatible = "mediatek,mt7628-usbphy",
> - .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
> -   MT7620_CLKCFG1_UPHY0_CLK_EN) },
> + .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
> + MT7620_CLKCFG1_UPHY0_CLK_EN) },
>   { },
>  };
>  MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
> @@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
> *pdev)
>   if (!phy)
>   return -ENOMEM;
>  
> - phy->clk = (u32) match->data;
> + phy->clk = (uintptr_t)match->data;
>   phy->base = NULL;
>  
>   phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, 
> "ralink,sysctl");
>

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread John Crispin 



On 23/08/17 15:39, Arnd Bergmann wrote:

Casting between an 'int' and a pointer causes a warning on
64-bit architectures in compile-testing this driver:

drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer 
of different size [-Werror=pointer-to-int-cast]

This changes the code to cast to uintptr_t instead. This is
guaranteed to do what we want on all architectures and avoids
the warning.

Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
Signed-off-by: Arnd Bergmann 

Acked-by: John Crispin 

gregkh: can you fold this into the commit sitting inside usb-next ?




---
  drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
b/drivers/phy/ralink/phy-ralink-usb.c
index d19088c0ce5c..4fea31f8ac1c 100644
--- a/drivers/phy/ralink/phy-ralink-usb.c
+++ b/drivers/phy/ralink/phy-ralink-usb.c
@@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
  static const struct of_device_id ralink_usb_phy_of_match[] = {
{
.compatible = "ralink,rt3352-usbphy",
-   .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
- RT_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
+   RT_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7620-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7628-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN) },
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN) },
{ },
  };
  MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
@@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
*pdev)
if (!phy)
return -ENOMEM;
  
-	phy->clk = (u32) match->data;

+   phy->clk = (uintptr_t)match->data;
phy->base = NULL;
  
  	phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, "ralink,sysctl");

Re: [PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread John Crispin 



On 23/08/17 15:39, Arnd Bergmann wrote:

Casting between an 'int' and a pointer causes a warning on
64-bit architectures in compile-testing this driver:

drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer 
of different size [-Werror=pointer-to-int-cast]

This changes the code to cast to uintptr_t instead. This is
guaranteed to do what we want on all architectures and avoids
the warning.

Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
Signed-off-by: Arnd Bergmann 

Acked-by: John Crispin 

gregkh: can you fold this into the commit sitting inside usb-next ?




---
  drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
b/drivers/phy/ralink/phy-ralink-usb.c
index d19088c0ce5c..4fea31f8ac1c 100644
--- a/drivers/phy/ralink/phy-ralink-usb.c
+++ b/drivers/phy/ralink/phy-ralink-usb.c
@@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
  static const struct of_device_id ralink_usb_phy_of_match[] = {
{
.compatible = "ralink,rt3352-usbphy",
-   .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
- RT_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
+   RT_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7620-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7628-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN) },
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN) },
{ },
  };
  MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
@@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
*pdev)
if (!phy)
return -ENOMEM;
  
-	phy->clk = (u32) match->data;

+   phy->clk = (uintptr_t)match->data;
phy->base = NULL;
  
  	phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, "ralink,sysctl");

[PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Arnd Bergmann 
Casting between an 'int' and a pointer causes a warning on
64-bit architectures in compile-testing this driver:

drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer 
of different size [-Werror=pointer-to-int-cast]

This changes the code to cast to uintptr_t instead. This is
guaranteed to do what we want on all architectures and avoids
the warning.

Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
Signed-off-by: Arnd Bergmann 
---
 drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
b/drivers/phy/ralink/phy-ralink-usb.c
index d19088c0ce5c..4fea31f8ac1c 100644
--- a/drivers/phy/ralink/phy-ralink-usb.c
+++ b/drivers/phy/ralink/phy-ralink-usb.c
@@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
 static const struct of_device_id ralink_usb_phy_of_match[] = {
{
.compatible = "ralink,rt3352-usbphy",
-   .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
- RT_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
+   RT_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7620-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7628-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN) },
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN) },
{ },
 };
 MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
@@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
*pdev)
if (!phy)
return -ENOMEM;
 
-   phy->clk = (u32) match->data;
+   phy->clk = (uintptr_t)match->data;
phy->base = NULL;
 
phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, 
"ralink,sysctl");
-- 
2.9.0

[PATCH] phy: ralink: fix 64-bit build warning

2017-08-23 Thread Arnd Bergmann 
Casting between an 'int' and a pointer causes a warning on
64-bit architectures in compile-testing this driver:

drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer 
of different size [-Werror=pointer-to-int-cast]

This changes the code to cast to uintptr_t instead. This is
guaranteed to do what we want on all architectures and avoids
the warning.

Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
Signed-off-by: Arnd Bergmann 
---
 drivers/phy/ralink/phy-ralink-usb.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/phy/ralink/phy-ralink-usb.c 
b/drivers/phy/ralink/phy-ralink-usb.c
index d19088c0ce5c..4fea31f8ac1c 100644
--- a/drivers/phy/ralink/phy-ralink-usb.c
+++ b/drivers/phy/ralink/phy-ralink-usb.c
@@ -160,18 +160,18 @@ static struct phy_ops ralink_usb_phy_ops = {
 static const struct of_device_id ralink_usb_phy_of_match[] = {
{
.compatible = "ralink,rt3352-usbphy",
-   .data = (void *) (RT_CLKCFG1_UPHY1_CLK_EN |
- RT_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(RT_CLKCFG1_UPHY1_CLK_EN |
+   RT_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7620-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN)
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN)
},
{
.compatible = "mediatek,mt7628-usbphy",
-   .data = (void *) (MT7620_CLKCFG1_UPHY1_CLK_EN |
- MT7620_CLKCFG1_UPHY0_CLK_EN) },
+   .data = (void *)(uintptr_t)(MT7620_CLKCFG1_UPHY1_CLK_EN |
+   MT7620_CLKCFG1_UPHY0_CLK_EN) },
{ },
 };
 MODULE_DEVICE_TABLE(of, ralink_usb_phy_of_match);
@@ -192,7 +192,7 @@ static int ralink_usb_phy_probe(struct platform_device 
*pdev)
if (!phy)
return -ENOMEM;
 
-   phy->clk = (u32) match->data;
+   phy->clk = (uintptr_t)match->data;
phy->base = NULL;
 
phy->sysctl = syscon_regmap_lookup_by_phandle(dev->of_node, 
"ralink,sysctl");
-- 
2.9.0