Re: [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe()

[Linus Walleij]

On Wed, Dec 27, 2017 at 10:10 PM, SF Markus Elfring
 wrote:

> From: Markus Elfring 
> Date: Wed, 27 Dec 2017 22:04:22 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring 

Patch applied with Björn's ACK.

Yours,
Linus Walleij

Re: [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe()

[Linus Walleij]

On Wed, Dec 27, 2017 at 10:10 PM, SF Markus Elfring
 wrote:

> From: Markus Elfring 
> Date: Wed, 27 Dec 2017 22:04:22 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring 

Patch applied with Björn's ACK.

Yours,
Linus Walleij

Re: [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe()

[Bjorn Andersson]

On Wed 27 Dec 13:10 PST 2017, SF Markus Elfring wrote:

> From: Markus Elfring 
> Date: Wed, 27 Dec 2017 22:04:22 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 

Thank's Markus,

Acked-by: Bjorn Andersson 

Regards,
Bjorn

> ---
>  drivers/pinctrl/qcom/pinctrl-msm.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c 
> b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 7a960590ecaa..495432f3341b 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -898,10 +898,9 @@ int msm_pinctrl_probe(struct platform_device *pdev,
>   int ret;
>  
>   pctrl = devm_kzalloc(>dev, sizeof(*pctrl), GFP_KERNEL);
> - if (!pctrl) {
> - dev_err(>dev, "Can't allocate msm_pinctrl\n");
> + if (!pctrl)
>   return -ENOMEM;
> - }
> +
>   pctrl->dev = >dev;
>   pctrl->soc = soc_data;
>   pctrl->chip = msm_gpio_template;
> -- 
> 2.15.1
> 

Re: [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe()

[Bjorn Andersson]

On Wed 27 Dec 13:10 PST 2017, SF Markus Elfring wrote:

> From: Markus Elfring 
> Date: Wed, 27 Dec 2017 22:04:22 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 

Thank's Markus,

Acked-by: Bjorn Andersson 

Regards,
Bjorn

> ---
>  drivers/pinctrl/qcom/pinctrl-msm.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c 
> b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 7a960590ecaa..495432f3341b 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -898,10 +898,9 @@ int msm_pinctrl_probe(struct platform_device *pdev,
>   int ret;
>  
>   pctrl = devm_kzalloc(>dev, sizeof(*pctrl), GFP_KERNEL);
> - if (!pctrl) {
> - dev_err(>dev, "Can't allocate msm_pinctrl\n");
> + if (!pctrl)
>   return -ENOMEM;
> - }
> +
>   pctrl->dev = >dev;
>   pctrl->soc = soc_data;
>   pctrl->chip = msm_gpio_template;
> -- 
> 2.15.1
> 

[PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe()

[SF Markus Elfring]

From: Markus Elfring 
Date: Wed, 27 Dec 2017 22:04:22 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/pinctrl/qcom/pinctrl-msm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c 
b/drivers/pinctrl/qcom/pinctrl-msm.c
index 7a960590ecaa..495432f3341b 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -898,10 +898,9 @@ int msm_pinctrl_probe(struct platform_device *pdev,
int ret;
 
pctrl = devm_kzalloc(>dev, sizeof(*pctrl), GFP_KERNEL);
-   if (!pctrl) {
-   dev_err(>dev, "Can't allocate msm_pinctrl\n");
+   if (!pctrl)
return -ENOMEM;
-   }
+
pctrl->dev = >dev;
pctrl->soc = soc_data;
pctrl->chip = msm_gpio_template;
-- 
2.15.1

[PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe()

[SF Markus Elfring]

From: Markus Elfring 
Date: Wed, 27 Dec 2017 22:04:22 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/pinctrl/qcom/pinctrl-msm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c 
b/drivers/pinctrl/qcom/pinctrl-msm.c
index 7a960590ecaa..495432f3341b 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -898,10 +898,9 @@ int msm_pinctrl_probe(struct platform_device *pdev,
int ret;
 
pctrl = devm_kzalloc(>dev, sizeof(*pctrl), GFP_KERNEL);
-   if (!pctrl) {
-   dev_err(>dev, "Can't allocate msm_pinctrl\n");
+   if (!pctrl)
return -ENOMEM;
-   }
+
pctrl->dev = >dev;
pctrl->soc = soc_data;
pctrl->chip = msm_gpio_template;
-- 
2.15.1