Re: [PATCH] platform/chrome: cros_ec_typec: Decouple partner removal

[Benson Leung]

Hi Prashant,

On Tue, 2 Feb 2021 14:40:01 -0800, Prashant Malani wrote:
> Currently, we return if there is no partner present when
> !PD_CTRL_RESP_ENABLED_CONNECTED, without proceeding further. This ties
> partner removal to cable removal, whereas the two should be independent.
> 
> Update the check to remove a partner if one was registered, but continue
> after that instead of returning.

Applied to for-kernelci, thanks!

[1/1] platform/chrome: cros_ec_typec: Decouple partner removal
  commit: d9f12f9e6c3695c32e681e9d266c4dc1c9016f66

Best regards,
-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org


signature.asc
Description: PGP signature

[PATCH] platform/chrome: cros_ec_typec: Decouple partner removal

[Prashant Malani]

Currently, we return if there is no partner present when
!PD_CTRL_RESP_ENABLED_CONNECTED, without proceeding further. This ties
partner removal to cable removal, whereas the two should be independent.

Update the check to remove a partner if one was registered, but continue
after that instead of returning.

Signed-off-by: Prashant Malani 
---
 drivers/platform/chrome/cros_ec_typec.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c 
b/drivers/platform/chrome/cros_ec_typec.c
index e724a5eaef1c..91b8fc1fd7f3 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -638,9 +638,8 @@ static void cros_typec_set_port_params_v1(struct 
cros_typec_data *typec,
 "Failed to register partner on port: %d\n",
 port_num);
} else {
-   if (!typec->ports[port_num]->partner)
-   return;
-   cros_typec_remove_partner(typec, port_num);
+   if (typec->ports[port_num]->partner)
+   cros_typec_remove_partner(typec, port_num);
 
if (typec->ports[port_num]->cable)
cros_typec_remove_cable(typec, port_num);
-- 
2.30.0.365.g02bc693789-goog