Re: [PATCH] pps: hide more configuration symbols behind CONFIG_PPS

2013-01-08 Thread Richard Cochran
On Tue, Jan 08, 2013 at 01:59:22PM +0100, Florian Fainelli wrote:
> This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if
> CONFIG_PPS is not selected, such that we are not prompted for these
> configuration options if CONFIG_PPS is not set.
> 
> Signed-off-by: Florian Fainelli 
> ---
>  drivers/pps/Kconfig |4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
> index 982d16b..dc19fb4 100644
> --- a/drivers/pps/Kconfig
> +++ b/drivers/pps/Kconfig
> @@ -21,6 +21,8 @@ config PPS
> To compile this driver as a module, choose M here: the module
> will be called pps_core.ko.
>  
> +if PPS
> +

If you add this "if" ...

>  config PPS_DEBUG
>   bool "PPS debugging messages"
>   depends on PPS

... then you should delete this redundant "depends".

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] pps: hide more configuration symbols behind CONFIG_PPS

2013-01-08 Thread Florian Fainelli
This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if
CONFIG_PPS is not selected, such that we are not prompted for these
configuration options if CONFIG_PPS is not set.

Signed-off-by: Florian Fainelli 
---
 drivers/pps/Kconfig |4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
index 982d16b..dc19fb4 100644
--- a/drivers/pps/Kconfig
+++ b/drivers/pps/Kconfig
@@ -21,6 +21,8 @@ config PPS
  To compile this driver as a module, choose M here: the module
  will be called pps_core.ko.
 
+if PPS
+
 config PPS_DEBUG
bool "PPS debugging messages"
depends on PPS
@@ -38,6 +40,8 @@ config NTP_PPS
 
  It doesn't work on tickless systems at the moment.
 
+endif
+
 source drivers/pps/clients/Kconfig
 
 source drivers/pps/generators/Kconfig
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] pps: hide more configuration symbols behind CONFIG_PPS

2013-01-08 Thread Florian Fainelli
This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if
CONFIG_PPS is not selected, such that we are not prompted for these
configuration options if CONFIG_PPS is not set.

Signed-off-by: Florian Fainelli flor...@openwrt.org
---
 drivers/pps/Kconfig |4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
index 982d16b..dc19fb4 100644
--- a/drivers/pps/Kconfig
+++ b/drivers/pps/Kconfig
@@ -21,6 +21,8 @@ config PPS
  To compile this driver as a module, choose M here: the module
  will be called pps_core.ko.
 
+if PPS
+
 config PPS_DEBUG
bool PPS debugging messages
depends on PPS
@@ -38,6 +40,8 @@ config NTP_PPS
 
  It doesn't work on tickless systems at the moment.
 
+endif
+
 source drivers/pps/clients/Kconfig
 
 source drivers/pps/generators/Kconfig
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] pps: hide more configuration symbols behind CONFIG_PPS

2013-01-08 Thread Richard Cochran
On Tue, Jan 08, 2013 at 01:59:22PM +0100, Florian Fainelli wrote:
 This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if
 CONFIG_PPS is not selected, such that we are not prompted for these
 configuration options if CONFIG_PPS is not set.
 
 Signed-off-by: Florian Fainelli flor...@openwrt.org
 ---
  drivers/pps/Kconfig |4 
  1 file changed, 4 insertions(+)
 
 diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
 index 982d16b..dc19fb4 100644
 --- a/drivers/pps/Kconfig
 +++ b/drivers/pps/Kconfig
 @@ -21,6 +21,8 @@ config PPS
 To compile this driver as a module, choose M here: the module
 will be called pps_core.ko.
  
 +if PPS
 +

If you add this if ...

  config PPS_DEBUG
   bool PPS debugging messages
   depends on PPS

... then you should delete this redundant depends.

Thanks,
Richard
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/