Re: [PATCH] qla2xxx: fix a potential NULL pointer dereference

2019-10-09 Thread Martin K. Petersen 


Allen,

> alloc_workqueue is not checked for errors and as a result,
> a potential NULL dereference could occur.

Applied to 5.4/scsi-fixes, thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] qla2xxx: fix a potential NULL pointer dereference

2019-10-03 Thread Martin Wilck 
On Wed, 2019-09-18 at 22:06 +0530, Allen Pais wrote:
> alloc_workqueue is not checked for errors and as a result,
> a potential NULL dereference could occur.
> 
> Signed-off-by: Allen Pais 
> ---
>  drivers/scsi/qla2xxx/qla_os.c | 4 
>  1 file changed, 4 insertions(+)

Reviewed-by: Martin Wilck

Re: [PATCH] qla2xxx: fix a potential NULL pointer dereference

2019-10-03 Thread Martin K. Petersen 


> alloc_workqueue is not checked for errors and as a result,
> a potential NULL dereference could occur.

Himanshu: Please review!

-- 
Martin K. Petersen  Oracle Linux Engineering

[PATCH] qla2xxx: fix a potential NULL pointer dereference

2019-09-18 Thread Allen Pais 
alloc_workqueue is not checked for errors and as a result,
a potential NULL dereference could occur.

Signed-off-by: Allen Pais 
---
 drivers/scsi/qla2xxx/qla_os.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 98e60a3..31714c9 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -3232,6 +3232,10 @@ static void qla2x00_iocb_work_fn(struct work_struct 
*work)
req->req_q_in, req->req_q_out, rsp->rsp_q_in, rsp->rsp_q_out);
 
ha->wq = alloc_workqueue("qla2xxx_wq", 0, 0);
+   if (unlikely(!ha->wq)) {
+   ret = -ENOMEM;
+   goto probe_failed;
+   }
 
if (ha->isp_ops->initialize_adapter(base_vha)) {
ql_log(ql_log_fatal, base_vha, 0x00d6,
-- 
1.9.1