Re: [PATCH] regulator: as3711: Fix checking if no platform initialization data

2013-02-13 Thread Mark Brown
On Wed, Feb 13, 2013 at 09:34:48AM +0800, Axel Lin wrote:
> To skip registering regulator if no platform initialization data,
> we should check reg_data rather than ri->desc.name.

Applied, thanks.


signature.asc
Description: Digital signature


Re: [PATCH] regulator: as3711: Fix checking if no platform initialization data

2013-02-13 Thread Guennadi Liakhovetski
On Wed, 13 Feb 2013, Axel Lin wrote:

> To skip registering regulator if no platform initialization data,
> we should check reg_data rather than ri->desc.name.
> 
> Signed-off-by: Axel Lin 

Acked-by: Guennadi Liakhovetski 

Thanks
Guennadi

> ---
>  drivers/regulator/as3711-regulator.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/as3711-regulator.c 
> b/drivers/regulator/as3711-regulator.c
> index 2f1341d..f0ba8c4 100644
> --- a/drivers/regulator/as3711-regulator.c
> +++ b/drivers/regulator/as3711-regulator.c
> @@ -303,7 +303,7 @@ static int as3711_regulator_probe(struct platform_device 
> *pdev)
>   reg_data = pdata ? pdata->init_data[id] : NULL;
>  
>   /* No need to register if there is no regulator data */
> - if (!ri->desc.name)
> + if (!reg_data)
>   continue;
>  
>   reg = [id];
> -- 
> 1.7.9.5
> 
> 
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] regulator: as3711: Fix checking if no platform initialization data

2013-02-13 Thread Guennadi Liakhovetski
On Wed, 13 Feb 2013, Axel Lin wrote:

 To skip registering regulator if no platform initialization data,
 we should check reg_data rather than ri-desc.name.
 
 Signed-off-by: Axel Lin axel@ingics.com

Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

Thanks
Guennadi

 ---
  drivers/regulator/as3711-regulator.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/regulator/as3711-regulator.c 
 b/drivers/regulator/as3711-regulator.c
 index 2f1341d..f0ba8c4 100644
 --- a/drivers/regulator/as3711-regulator.c
 +++ b/drivers/regulator/as3711-regulator.c
 @@ -303,7 +303,7 @@ static int as3711_regulator_probe(struct platform_device 
 *pdev)
   reg_data = pdata ? pdata-init_data[id] : NULL;
  
   /* No need to register if there is no regulator data */
 - if (!ri-desc.name)
 + if (!reg_data)
   continue;
  
   reg = regs[id];
 -- 
 1.7.9.5
 
 
 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] regulator: as3711: Fix checking if no platform initialization data

2013-02-13 Thread Mark Brown
On Wed, Feb 13, 2013 at 09:34:48AM +0800, Axel Lin wrote:
 To skip registering regulator if no platform initialization data,
 we should check reg_data rather than ri-desc.name.

Applied, thanks.


signature.asc
Description: Digital signature


[PATCH] regulator: as3711: Fix checking if no platform initialization data

2013-02-12 Thread Axel Lin
To skip registering regulator if no platform initialization data,
we should check reg_data rather than ri->desc.name.

Signed-off-by: Axel Lin 
---
 drivers/regulator/as3711-regulator.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/as3711-regulator.c 
b/drivers/regulator/as3711-regulator.c
index 2f1341d..f0ba8c4 100644
--- a/drivers/regulator/as3711-regulator.c
+++ b/drivers/regulator/as3711-regulator.c
@@ -303,7 +303,7 @@ static int as3711_regulator_probe(struct platform_device 
*pdev)
reg_data = pdata ? pdata->init_data[id] : NULL;
 
/* No need to register if there is no regulator data */
-   if (!ri->desc.name)
+   if (!reg_data)
continue;
 
reg = [id];
-- 
1.7.9.5



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] regulator: as3711: Fix checking if no platform initialization data

2013-02-12 Thread Axel Lin
To skip registering regulator if no platform initialization data,
we should check reg_data rather than ri-desc.name.

Signed-off-by: Axel Lin axel@ingics.com
---
 drivers/regulator/as3711-regulator.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/as3711-regulator.c 
b/drivers/regulator/as3711-regulator.c
index 2f1341d..f0ba8c4 100644
--- a/drivers/regulator/as3711-regulator.c
+++ b/drivers/regulator/as3711-regulator.c
@@ -303,7 +303,7 @@ static int as3711_regulator_probe(struct platform_device 
*pdev)
reg_data = pdata ? pdata-init_data[id] : NULL;
 
/* No need to register if there is no regulator data */
-   if (!ri-desc.name)
+   if (!reg_data)
continue;
 
reg = regs[id];
-- 
1.7.9.5



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/