Re: [PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases
On 08/10/2018 01:05 PM, Douglas Anderson wrote: > No functional change here but it can make the code more readable to > have breaks in the "default" case even though it's the last case. > Let's add them. > > Signed-off-by: Douglas Anderson > --- > > drivers/regulator/qcom-rpmh-regulator.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/regulator/qcom-rpmh-regulator.c > b/drivers/regulator/qcom-rpmh-regulator.c > index 9f27daebd8c8..b8434e521d72 100644 > --- a/drivers/regulator/qcom-rpmh-regulator.c > +++ b/drivers/regulator/qcom-rpmh-regulator.c > @@ -504,6 +504,7 @@ static unsigned int > rpmh_regulator_pmic4_ldo_of_map_mode(unsigned int rpmh_mode) > break; > default: > mode = REGULATOR_MODE_INVALID; > + break; > } > > return mode; > @@ -537,6 +538,7 @@ rpmh_regulator_pmic4_smps_of_map_mode(unsigned int > rpmh_mode) > break; > default: > mode = REGULATOR_MODE_INVALID; > + break; > } > > return mode; > @@ -566,6 +568,7 @@ static unsigned int > rpmh_regulator_pmic4_bob_of_map_mode(unsigned int rpmh_mode) > break; > default: > mode = REGULATOR_MODE_INVALID; > + break; > } > > return mode; Reviewed-by: David Collins -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases
On 08/10/2018 01:05 PM, Douglas Anderson wrote: > No functional change here but it can make the code more readable to > have breaks in the "default" case even though it's the last case. > Let's add them. > > Signed-off-by: Douglas Anderson > --- > > drivers/regulator/qcom-rpmh-regulator.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/regulator/qcom-rpmh-regulator.c > b/drivers/regulator/qcom-rpmh-regulator.c > index 9f27daebd8c8..b8434e521d72 100644 > --- a/drivers/regulator/qcom-rpmh-regulator.c > +++ b/drivers/regulator/qcom-rpmh-regulator.c > @@ -504,6 +504,7 @@ static unsigned int > rpmh_regulator_pmic4_ldo_of_map_mode(unsigned int rpmh_mode) > break; > default: > mode = REGULATOR_MODE_INVALID; > + break; > } > > return mode; > @@ -537,6 +538,7 @@ rpmh_regulator_pmic4_smps_of_map_mode(unsigned int > rpmh_mode) > break; > default: > mode = REGULATOR_MODE_INVALID; > + break; > } > > return mode; > @@ -566,6 +568,7 @@ static unsigned int > rpmh_regulator_pmic4_bob_of_map_mode(unsigned int rpmh_mode) > break; > default: > mode = REGULATOR_MODE_INVALID; > + break; > } > > return mode; Reviewed-by: David Collins -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
[PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases
No functional change here but it can make the code more readable to have breaks in the "default" case even though it's the last case. Let's add them. Signed-off-by: Douglas Anderson --- drivers/regulator/qcom-rpmh-regulator.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c index 9f27daebd8c8..b8434e521d72 100644 --- a/drivers/regulator/qcom-rpmh-regulator.c +++ b/drivers/regulator/qcom-rpmh-regulator.c @@ -504,6 +504,7 @@ static unsigned int rpmh_regulator_pmic4_ldo_of_map_mode(unsigned int rpmh_mode) break; default: mode = REGULATOR_MODE_INVALID; + break; } return mode; @@ -537,6 +538,7 @@ rpmh_regulator_pmic4_smps_of_map_mode(unsigned int rpmh_mode) break; default: mode = REGULATOR_MODE_INVALID; + break; } return mode; @@ -566,6 +568,7 @@ static unsigned int rpmh_regulator_pmic4_bob_of_map_mode(unsigned int rpmh_mode) break; default: mode = REGULATOR_MODE_INVALID; + break; } return mode; -- 2.18.0.597.ga71716f1ad-goog
[PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases
No functional change here but it can make the code more readable to have breaks in the "default" case even though it's the last case. Let's add them. Signed-off-by: Douglas Anderson --- drivers/regulator/qcom-rpmh-regulator.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c index 9f27daebd8c8..b8434e521d72 100644 --- a/drivers/regulator/qcom-rpmh-regulator.c +++ b/drivers/regulator/qcom-rpmh-regulator.c @@ -504,6 +504,7 @@ static unsigned int rpmh_regulator_pmic4_ldo_of_map_mode(unsigned int rpmh_mode) break; default: mode = REGULATOR_MODE_INVALID; + break; } return mode; @@ -537,6 +538,7 @@ rpmh_regulator_pmic4_smps_of_map_mode(unsigned int rpmh_mode) break; default: mode = REGULATOR_MODE_INVALID; + break; } return mode; @@ -566,6 +568,7 @@ static unsigned int rpmh_regulator_pmic4_bob_of_map_mode(unsigned int rpmh_mode) break; default: mode = REGULATOR_MODE_INVALID; + break; } return mode; -- 2.18.0.597.ga71716f1ad-goog
