Re: [PATCH] regulator: tps6586x: (cosmetic) simplify a conditional
On Mon, Feb 25, 2013 at 12:34:09PM +0100, Guennadi Liakhovetski wrote: > of_node_put() is called on either branch of a conditional, simplify the > code by only calling it once. Applied, thanks. signature.asc Description: Digital signature
Re: [PATCH] regulator: tps6586x: (cosmetic) simplify a conditional
On Mon, Feb 25, 2013 at 12:34:09PM +0100, Guennadi Liakhovetski wrote: of_node_put() is called on either branch of a conditional, simplify the code by only calling it once. Applied, thanks. signature.asc Description: Digital signature
[PATCH] regulator: tps6586x: (cosmetic) simplify a conditional
of_node_put() is called on either branch of a conditional, simplify the
code by only calling it once.
Signed-off-by: Guennadi Liakhovetski
---
drivers/regulator/tps6586x-regulator.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/tps6586x-regulator.c
b/drivers/regulator/tps6586x-regulator.c
index f86da67..1471ead 100644
--- a/drivers/regulator/tps6586x-regulator.c
+++ b/drivers/regulator/tps6586x-regulator.c
@@ -338,14 +338,12 @@ static struct tps6586x_platform_data
*tps6586x_parse_regulator_dt(
}
err = of_regulator_match(>dev, regs, tps6586x_matches, num);
+ of_node_put(regs);
if (err < 0) {
dev_err(>dev, "Regulator match failed, e %d\n", err);
- of_node_put(regs);
return NULL;
}
- of_node_put(regs);
-
pdata = devm_kzalloc(>dev, sizeof(*pdata), GFP_KERNEL);
if (!pdata) {
dev_err(>dev, "Memory alloction failed\n");
--
1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] regulator: tps6586x: (cosmetic) simplify a conditional
of_node_put() is called on either branch of a conditional, simplify the
code by only calling it once.
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
drivers/regulator/tps6586x-regulator.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/tps6586x-regulator.c
b/drivers/regulator/tps6586x-regulator.c
index f86da67..1471ead 100644
--- a/drivers/regulator/tps6586x-regulator.c
+++ b/drivers/regulator/tps6586x-regulator.c
@@ -338,14 +338,12 @@ static struct tps6586x_platform_data
*tps6586x_parse_regulator_dt(
}
err = of_regulator_match(pdev-dev, regs, tps6586x_matches, num);
+ of_node_put(regs);
if (err 0) {
dev_err(pdev-dev, Regulator match failed, e %d\n, err);
- of_node_put(regs);
return NULL;
}
- of_node_put(regs);
-
pdata = devm_kzalloc(pdev-dev, sizeof(*pdata), GFP_KERNEL);
if (!pdata) {
dev_err(pdev-dev, Memory alloction failed\n);
--
1.7.2.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
