Re: [PATCH] regulators: max8998.c: use dev_err() instead of printk()

2013-02-28 Thread Mark Brown
On Sat, Feb 23, 2013 at 12:52:35AM -0300, Thiago Farina wrote:
> Fixes the following checkpatch warning:
> 
> WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  
> to printk(KERN_ERR ...

Applied, thanks (and discarded the previous version as it's subsumed in
there).


signature.asc
Description: Digital signature


[PATCH] regulators: max8998.c: use dev_err() instead of printk()

2013-02-22 Thread Thiago Farina
Fixes the following checkpatch warning:

WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  
to printk(KERN_ERR ...

Signed-off-by: Thiago Farina 
---
 drivers/regulator/max8998.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c
index b588f07..a57a1b1 100644
--- a/drivers/regulator/max8998.c
+++ b/drivers/regulator/max8998.c
@@ -665,14 +665,16 @@ static int max8998_pmic_probe(struct platform_device 
*pdev)
gpio_is_valid(pdata->buck1_set2)) {
/* Check if SET1 is not equal to 0 */
if (!pdata->buck1_set1) {
-   printk(KERN_ERR "MAX8998 SET1 GPIO defined as 0 !\n");
+   dev_err(&pdev->dev,
+   "MAX8998 SET1 GPIO defined as 0 !\n");
WARN_ON(!pdata->buck1_set1);
ret = -EIO;
goto err_out;
}
/* Check if SET2 is not equal to 0 */
if (!pdata->buck1_set2) {
-   printk(KERN_ERR "MAX8998 SET2 GPIO defined as 0 !\n");
+   dev_err(&pdev->dev,
+   "MAX8998 SET2 GPIO defined as 0 !\n");
WARN_ON(!pdata->buck1_set2);
ret = -EIO;
goto err_out;
@@ -738,7 +740,8 @@ static int max8998_pmic_probe(struct platform_device *pdev)
if (gpio_is_valid(pdata->buck2_set3)) {
/* Check if SET3 is not equal to 0 */
if (!pdata->buck2_set3) {
-   printk(KERN_ERR "MAX8998 SET3 GPIO defined as 0 !\n");
+   dev_err(&pdev->dev,
+   "MAX8998 SET3 GPIO defined as 0 !\n");
WARN_ON(!pdata->buck2_set3);
ret = -EIO;
goto err_out;
-- 
1.8.1.151.g32238ae

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/