Re: [PATCH] rtl8xxxu: prevent leaking urb

2019-10-01 Thread Kalle Valo 
Navid Emamdoost  wrote:

> In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb
> should be released.
> 
> Signed-off-by: Navid Emamdoost 
> Reviewed-by: Chris Chiu 

Patch applied to wireless-drivers-next.git, thanks.

a2cdd07488e6 rtl8xxxu: prevent leaking urb

-- 
https://patchwork.kernel.org/patch/11153733/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] rtl8xxxu: prevent leaking urb

2019-09-20 Thread Chris Chiu 
On Fri, Sep 20, 2019 at 11:01 AM Navid Emamdoost
 wrote:
>
> In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb
> should be released.
>
> Signed-off-by: Navid Emamdoost 
Reviewed-by: Chris Chiu 


> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -5443,6 +5443,7 @@ static int rtl8xxxu_submit_int_urb(struct ieee80211_hw 
> *hw)
> ret = usb_submit_urb(urb, GFP_KERNEL);
> if (ret) {
> usb_unanchor_urb(urb);
> +   usb_free_urb(urb);
> goto error;
> }
You're right. There's a usb_alloc_urb in the beginning of this
function and should be
handled after submit failure.

Chris

[PATCH] rtl8xxxu: prevent leaking urb

2019-09-19 Thread Navid Emamdoost 
In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb
should be released.

Signed-off-by: Navid Emamdoost 
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c 
b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 8136e268b4e6..4a559c37e208 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -5443,6 +5443,7 @@ static int rtl8xxxu_submit_int_urb(struct ieee80211_hw 
*hw)
ret = usb_submit_urb(urb, GFP_KERNEL);
if (ret) {
usb_unanchor_urb(urb);
+   usb_free_urb(urb);
goto error;
}
 
-- 
2.17.1