Re: [PATCH] s390/vmur: fix build warning
On Tue, Dec 22, 2015 at 06:58:50AM +, Al Viro wrote: > On Tue, Dec 22, 2015 at 12:23:51PM +0530, Sudip Mukherjee wrote: > > The helper no_seek_end_llseek() was added but now newpos is not required > > and as a result we are getting build warning of unused variable. > > Mind if I simply fold that into the commit in question? No problem at all. Please fold them together. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] s390/vmur: fix build warning
On Tue, Dec 22, 2015 at 12:23:51PM +0530, Sudip Mukherjee wrote: > The helper no_seek_end_llseek() was added but now newpos is not required > and as a result we are getting build warning of unused variable. Mind if I simply fold that into the commit in question? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] s390/vmur: fix build warning
The helper no_seek_end_llseek() was added but now newpos is not required
and as a result we are getting build warning of unused variable.
Fixes: fb1d259e480c ("new helpers: no_seek_end_llseek{,_size}()")
Cc: Al Viro
Signed-off-by: Sudip Mukherjee
---
drivers/s390/char/vmur.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/s390/char/vmur.c b/drivers/s390/char/vmur.c
index a532e54..6c30e93a 100644
--- a/drivers/s390/char/vmur.c
+++ b/drivers/s390/char/vmur.c
@@ -782,8 +782,6 @@ static int ur_release(struct inode *inode, struct file
*file)
static loff_t ur_llseek(struct file *file, loff_t offset, int whence)
{
- loff_t newpos;
-
if ((file->f_flags & O_ACCMODE) != O_RDONLY)
return -ESPIPE; /* seek allowed only for reader */
if (offset % PAGE_SIZE)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] s390/vmur: fix build warning
The helper no_seek_end_llseek() was added but now newpos is not required
and as a result we are getting build warning of unused variable.
Fixes: fb1d259e480c ("new helpers: no_seek_end_llseek{,_size}()")
Cc: Al Viro
Signed-off-by: Sudip Mukherjee
---
drivers/s390/char/vmur.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/s390/char/vmur.c b/drivers/s390/char/vmur.c
index a532e54..6c30e93a 100644
--- a/drivers/s390/char/vmur.c
+++ b/drivers/s390/char/vmur.c
@@ -782,8 +782,6 @@ static int ur_release(struct inode *inode, struct file
*file)
static loff_t ur_llseek(struct file *file, loff_t offset, int whence)
{
- loff_t newpos;
-
if ((file->f_flags & O_ACCMODE) != O_RDONLY)
return -ESPIPE; /* seek allowed only for reader */
if (offset % PAGE_SIZE)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] s390/vmur: fix build warning
On Tue, Dec 22, 2015 at 06:58:50AM +, Al Viro wrote: > On Tue, Dec 22, 2015 at 12:23:51PM +0530, Sudip Mukherjee wrote: > > The helper no_seek_end_llseek() was added but now newpos is not required > > and as a result we are getting build warning of unused variable. > > Mind if I simply fold that into the commit in question? No problem at all. Please fold them together. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] s390/vmur: fix build warning
On Tue, Dec 22, 2015 at 12:23:51PM +0530, Sudip Mukherjee wrote: > The helper no_seek_end_llseek() was added but now newpos is not required > and as a result we are getting build warning of unused variable. Mind if I simply fold that into the commit in question? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
