Re: [PATCH] samples/seccomp: fix 32-bit build
* Kees Cook wrote: > On Mon, Jan 7, 2019 at 3:16 PM Tycho Andersen wrote: > > > > Both the .o and the actual executable need to be built with -m32 in order > > to link correctly. > > > > Signed-off-by: Tycho Andersen > > Reported-by: Ingo Molnar > > Fixes: fec7b6690541 ("samples: add an example of seccomp user trap") > > Reviewed-by: Kees Cook > > > --- > > I guess x86 can pick this up directly? Not sure where it should go > > exactly. > > Ingo, can you snag this? (It's a more direct path, otherwise I can > take it via seccomp, which will go through my tree then James's > tree...) Sure - applied it to x86/urgent. Thanks, Ingo
Re: [PATCH] samples/seccomp: fix 32-bit build
On Mon, Jan 7, 2019 at 3:16 PM Tycho Andersen wrote: > > Both the .o and the actual executable need to be built with -m32 in order > to link correctly. > > Signed-off-by: Tycho Andersen > Reported-by: Ingo Molnar > Fixes: fec7b6690541 ("samples: add an example of seccomp user trap") Reviewed-by: Kees Cook > --- > I guess x86 can pick this up directly? Not sure where it should go > exactly. Ingo, can you snag this? (It's a more direct path, otherwise I can take it via seccomp, which will go through my tree then James's tree...) -Kees > --- > samples/seccomp/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/samples/seccomp/Makefile b/samples/seccomp/Makefile > index 4920903c8009..fb43a814d4c0 100644 > --- a/samples/seccomp/Makefile > +++ b/samples/seccomp/Makefile > @@ -34,6 +34,7 @@ HOSTCFLAGS_bpf-direct.o += $(MFLAG) > HOSTCFLAGS_dropper.o += $(MFLAG) > HOSTCFLAGS_bpf-helper.o += $(MFLAG) > HOSTCFLAGS_bpf-fancy.o += $(MFLAG) > +HOSTCFLAGS_user-trap.o += $(MFLAG) > HOSTLDLIBS_bpf-direct += $(MFLAG) > HOSTLDLIBS_bpf-fancy += $(MFLAG) > HOSTLDLIBS_dropper += $(MFLAG) > -- > 2.19.1 > -- Kees Cook
[PATCH] samples/seccomp: fix 32-bit build
Both the .o and the actual executable need to be built with -m32 in order to link correctly. Signed-off-by: Tycho Andersen Reported-by: Ingo Molnar Fixes: fec7b6690541 ("samples: add an example of seccomp user trap") --- I guess x86 can pick this up directly? Not sure where it should go exactly. --- samples/seccomp/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/samples/seccomp/Makefile b/samples/seccomp/Makefile index 4920903c8009..fb43a814d4c0 100644 --- a/samples/seccomp/Makefile +++ b/samples/seccomp/Makefile @@ -34,6 +34,7 @@ HOSTCFLAGS_bpf-direct.o += $(MFLAG) HOSTCFLAGS_dropper.o += $(MFLAG) HOSTCFLAGS_bpf-helper.o += $(MFLAG) HOSTCFLAGS_bpf-fancy.o += $(MFLAG) +HOSTCFLAGS_user-trap.o += $(MFLAG) HOSTLDLIBS_bpf-direct += $(MFLAG) HOSTLDLIBS_bpf-fancy += $(MFLAG) HOSTLDLIBS_dropper += $(MFLAG) -- 2.19.1