Re: [PATCH] sbp-target: Delete an error message for a failed memory allocation in three functions

[Chris Boot]

On 10/12/2017 19:10, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sun, 10 Dec 2017 19:54:11 +0100
> 
> Omit an extra message for a memory allocation failure in these functions.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 
[snip]

Looks good to me.

Acked-by: Chris Boot 

Thanks,
Chris

-- 
Chris Boot
bo...@boo.tc

Re: [PATCH] sbp-target: Delete an error message for a failed memory allocation in three functions

[Chris Boot]

On 10/12/2017 19:10, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sun, 10 Dec 2017 19:54:11 +0100
> 
> Omit an extra message for a memory allocation failure in these functions.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 
[snip]

Looks good to me.

Acked-by: Chris Boot 

Thanks,
Chris

-- 
Chris Boot
bo...@boo.tc

[PATCH] sbp-target: Delete an error message for a failed memory allocation in three functions

[SF Markus Elfring]

From: Markus Elfring 
Date: Sun, 10 Dec 2017 19:54:11 +0100

Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/target/sbp/sbp_target.c | 13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
index e5c3e5f827d0..fb1003921d85 100644
--- a/drivers/target/sbp/sbp_target.c
+++ b/drivers/target/sbp/sbp_target.c
@@ -201,10 +201,9 @@ static struct sbp_session *sbp_session_create(
snprintf(guid_str, sizeof(guid_str), "%016llx", guid);
 
sess = kmalloc(sizeof(*sess), GFP_KERNEL);
-   if (!sess) {
-   pr_err("failed to allocate session descriptor\n");
+   if (!sess)
return ERR_PTR(-ENOMEM);
-   }
+
spin_lock_init(>lock);
INIT_LIST_HEAD(>login_list);
INIT_DELAYED_WORK(>maint_work, session_maintenance_work);
@@ -2029,10 +2028,8 @@ static struct se_portal_group *sbp_make_tpg(
}
 
tpg = kzalloc(sizeof(*tpg), GFP_KERNEL);
-   if (!tpg) {
-   pr_err("Unable to allocate struct sbp_tpg\n");
+   if (!tpg)
return ERR_PTR(-ENOMEM);
-   }
 
tpg->tport = tport;
tpg->tport_tpgt = tpgt;
@@ -2088,10 +2085,8 @@ static struct se_wwn *sbp_make_tport(
return ERR_PTR(-EINVAL);
 
tport = kzalloc(sizeof(*tport), GFP_KERNEL);
-   if (!tport) {
-   pr_err("Unable to allocate struct sbp_tport\n");
+   if (!tport)
return ERR_PTR(-ENOMEM);
-   }
 
tport->guid = guid;
sbp_format_wwn(tport->tport_name, SBP_NAMELEN, guid);
-- 
2.15.1

[PATCH] sbp-target: Delete an error message for a failed memory allocation in three functions

[SF Markus Elfring]

From: Markus Elfring 
Date: Sun, 10 Dec 2017 19:54:11 +0100

Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/target/sbp/sbp_target.c | 13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
index e5c3e5f827d0..fb1003921d85 100644
--- a/drivers/target/sbp/sbp_target.c
+++ b/drivers/target/sbp/sbp_target.c
@@ -201,10 +201,9 @@ static struct sbp_session *sbp_session_create(
snprintf(guid_str, sizeof(guid_str), "%016llx", guid);
 
sess = kmalloc(sizeof(*sess), GFP_KERNEL);
-   if (!sess) {
-   pr_err("failed to allocate session descriptor\n");
+   if (!sess)
return ERR_PTR(-ENOMEM);
-   }
+
spin_lock_init(>lock);
INIT_LIST_HEAD(>login_list);
INIT_DELAYED_WORK(>maint_work, session_maintenance_work);
@@ -2029,10 +2028,8 @@ static struct se_portal_group *sbp_make_tpg(
}
 
tpg = kzalloc(sizeof(*tpg), GFP_KERNEL);
-   if (!tpg) {
-   pr_err("Unable to allocate struct sbp_tpg\n");
+   if (!tpg)
return ERR_PTR(-ENOMEM);
-   }
 
tpg->tport = tport;
tpg->tport_tpgt = tpgt;
@@ -2088,10 +2085,8 @@ static struct se_wwn *sbp_make_tport(
return ERR_PTR(-EINVAL);
 
tport = kzalloc(sizeof(*tport), GFP_KERNEL);
-   if (!tport) {
-   pr_err("Unable to allocate struct sbp_tport\n");
+   if (!tport)
return ERR_PTR(-ENOMEM);
-   }
 
tport->guid = guid;
sbp_format_wwn(tport->tport_name, SBP_NAMELEN, guid);
-- 
2.15.1