Re: [PATCH] scsi: message: fusion: remove useless variable

[Martin K. Petersen]

On Mon, 12 Apr 2021 13:59:06 +0800, Jiapeng Chong wrote:

> Fix the following gcc warning:
> 
> drivers/message/fusion/mptsas.c:783:14: warning: variable ‘vtarget’ set
> but not used [-Wunused-but-set-variable].

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: message: fusion: remove useless variable
  https://git.kernel.org/mkp/scsi/c/cf17ff267880

-- 
Martin K. Petersen  Oracle Linux Engineering

[PATCH] scsi: message: fusion: remove useless variable

[Jiapeng Chong]

Fix the following gcc warning:

drivers/message/fusion/mptsas.c:783:14: warning: variable ‘vtarget’ set
but not used [-Wunused-but-set-variable].

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
---
 drivers/message/fusion/mptsas.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
index 5eb0b33..c54e823 100644
--- a/drivers/message/fusion/mptsas.c
+++ b/drivers/message/fusion/mptsas.c
@@ -780,13 +780,11 @@ static inline MPT_ADAPTER *rphy_to_ioc(struct sas_rphy 
*rphy)
 mptsas_add_device_component_starget(MPT_ADAPTER *ioc,
struct scsi_target *starget)
 {
-   VirtTarget  *vtarget;
struct sas_rphy *rphy;
struct mptsas_phyinfo   *phy_info = NULL;
struct mptsas_enclosure enclosure_info;
 
rphy = dev_to_rphy(starget->dev.parent);
-   vtarget = starget->hostdata;
phy_info = mptsas_find_phyinfo_by_sas_address(ioc,
rphy->identify.sas_address);
if (!phy_info)
-- 
1.8.3.1

[PATCH] scsi: message: fusion: Remove useless variable

[Jiapeng Chong]

Fix the following gcc warning:

drivers/message/fusion/mptbase.c:3087:9: warning: variable ‘status’ set
but not used [-Wunused-but-set-variable].

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
---
 drivers/message/fusion/mptbase.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index 549797d..f37ea06 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -3084,7 +3084,7 @@ static int mpt_remove_dead_ioc_func(void *arg)
int  req_sz;
int  reply_sz;
int  sz;
-   u32  status, vv;
+   u32  vv;
u8   shiftFactor=1;
 
/* IOC *must* NOT be in RESET state! */
@@ -3142,7 +3142,6 @@ static int mpt_remove_dead_ioc_func(void *arg)
facts->IOCExceptions = le16_to_cpu(facts->IOCExceptions);
facts->IOCStatus = le16_to_cpu(facts->IOCStatus);
facts->IOCLogInfo = le32_to_cpu(facts->IOCLogInfo);
-   status = le16_to_cpu(facts->IOCStatus) & MPI_IOCSTATUS_MASK;
/* CHECKME! IOCStatus, IOCLogInfo */
 
facts->ReplyQueueDepth = le16_to_cpu(facts->ReplyQueueDepth);
-- 
1.8.3.1