Re: [PATCH] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context

2021-03-18 Thread Martin K. Petersen 
On Sat, 20 Feb 2021 10:39:51 +0100, Christophe JAILLET wrote:

> 'mpt3sas_get_port_by_id()' can be called when a spinlock is hold. So use
> GFP_ATOMIC instead of GFP_KERNEL when allocating memory.
> 
> Issue spotted by call_kern.cocci:
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
> mpt3sas_get_port_by_id called on line 7125 inside lock on line 7123 but uses 
> GFP_KERNEL
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
> mpt3sas_get_port_by_id called on line 6842 inside lock on line 6839 but uses 
> GFP_KERNEL
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
> mpt3sas_get_port_by_id called on line 6854 inside lock on line 6851 but uses 
> GFP_KERNEL
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
> mpt3sas_get_port_by_id called on line 7706 inside lock on line 7702 but uses 
> GFP_KERNEL
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
> mpt3sas_get_port_by_id called on line 10260 inside lock on line 10256 but 
> uses GFP_KERNEL

Applied to 5.12/scsi-fixes, thanks!

[1/1] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context
  https://git.kernel.org/mkp/scsi/c/a50bd6461690

-- 
Martin K. Petersen  Oracle Linux Engineering

[PATCH] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context

2021-02-20 Thread Christophe JAILLET 
'mpt3sas_get_port_by_id()' can be called when a spinlock is hold. So use
GFP_ATOMIC instead of GFP_KERNEL when allocating memory.

Issue spotted by call_kern.cocci:
./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
mpt3sas_get_port_by_id called on line 7125 inside lock on line 7123 but uses 
GFP_KERNEL
./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
mpt3sas_get_port_by_id called on line 6842 inside lock on line 6839 but uses 
GFP_KERNEL
./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
mpt3sas_get_port_by_id called on line 6854 inside lock on line 6851 but uses 
GFP_KERNEL
./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
mpt3sas_get_port_by_id called on line 7706 inside lock on line 7702 but uses 
GFP_KERNEL
./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function 
mpt3sas_get_port_by_id called on line 10260 inside lock on line 10256 but uses 
GFP_KERNEL

Fixes: 324c122fc0a4 ("scsi: mpt3sas: Add module parameter multipath_on_hba")
Signed-off-by: Christophe JAILLET 
---
 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c 
b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index ffca03064797..6aa6de729187 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -413,7 +413,7 @@ mpt3sas_get_port_by_id(struct MPT3SAS_ADAPTER *ioc,
 * And add this object to port_table_list.
 */
if (!ioc->multipath_on_hba) {
-   port = kzalloc(sizeof(struct hba_port), GFP_KERNEL);
+   port = kzalloc(sizeof(struct hba_port), GFP_ATOMIC);
if (!port)
return NULL;
 
-- 
2.27.0