Re: [PATCH] soc: imx8m: Make imx8m_dsp_ops static

2020-04-28 Thread chentao (AS) 
Thanks a lot, i will resend v2 and add  Mark Brown broo...@kernel.org  
alsa-de...@alsa-project.org


On 2020/4/29 0:42, Daniel Baluta wrote:

On Sat, Apr 25, 2020 at 11:03 AM ChenTao  wrote:

Fix the following warning:

sound/soc/sof/imx/imx8m.c:95:20: warning:
symbol 'imx8m_dsp_ops' was not declared. Should it be static?

Reported-by: Hulk Robot 
Signed-off-by: ChenTao 

Reviewed-by: Daniel Baluta 

Can you please resend (picking Acked-by/Reviewed-by tags) and
as Kai said add:

To: Mark Brown (broo...@kernel.org
Cc: alsa-de...@alsa-project.org
.

Re: [PATCH] soc: imx8m: Make imx8m_dsp_ops static

2020-04-28 Thread Daniel Baluta 
On Sat, Apr 25, 2020 at 11:03 AM ChenTao  wrote:
>
> Fix the following warning:
>
> sound/soc/sof/imx/imx8m.c:95:20: warning:
> symbol 'imx8m_dsp_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot 
> Signed-off-by: ChenTao 

Reviewed-by: Daniel Baluta 

Can you please resend (picking Acked-by/Reviewed-by tags) and
as Kai said add:

To: Mark Brown (broo...@kernel.org
Cc: alsa-de...@alsa-project.org

Re: [PATCH] soc: imx8m: Make imx8m_dsp_ops static

2020-04-28 Thread Kai Vehmanen 
Hi,

[+Daniel]

On Sat, 25 Apr 2020, ChenTao wrote:

> Fix the following warning:
> 
> sound/soc/sof/imx/imx8m.c:95:20: warning:
> symbol 'imx8m_dsp_ops' was not declared. Should it be static?

yes, this was missed in the initial version of this driver. Ok to go with 
this:

Acked-by: Kai Vehmanen 

You did not send a copy of the patch to Mark Brown (broo...@kernel.org). 
Can you resend with him in the loop, so he can pick the patch up to ALSA 
ASoC tree. Also please copy the ALSA list (alsa-de...@alsa-project.org).

Br, Kai