Re: [PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe
On Tue, Jun 18, 2019 at 02:54:10PM +0300, Dan Carpenter wrote: > The devm_ioremap_resource() function doesn't return NULL, it returns > error pointers. > > Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources") > Signed-off-by: Dan Carpenter > Reviewed-by: Linus Walleij Applied, thanks! -Olof
[PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe
The devm_ioremap_resource() function doesn't return NULL, it returns error pointers. Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources") Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij --- drivers/soc/ixp4xx/ixp4xx-npe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ixp4xx/ixp4xx-npe.c b/drivers/soc/ixp4xx/ixp4xx-npe.c index bc10e3194809..ec90b44fa0cd 100644 --- a/drivers/soc/ixp4xx/ixp4xx-npe.c +++ b/drivers/soc/ixp4xx/ixp4xx-npe.c @@ -695,8 +695,8 @@ static int ixp4xx_npe_probe(struct platform_device *pdev) continue; /* NPE already disabled or not present */ } npe->regs = devm_ioremap_resource(dev, res); - if (!npe->regs) - return -ENOMEM; + if (IS_ERR(npe->regs)) + return PTR_ERR(npe->regs); if (npe_reset(npe)) { dev_info(dev, "NPE%d at 0x%08x-0x%08x does not reset\n", -- 2.20.1
Re: [PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe
On Thu, Jun 13, 2019 at 9:02 AM Dan Carpenter wrote: > The devm_ioremap_resource() function doesn't return NULL, it returns > error pointers. > > Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources") > Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Can you please collect my review and send this to the ARM SoC maintainers a...@kernel.org since they are collecting a few other IXP4xx fixes? Yours, Linus Walleij
[PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe
The devm_ioremap_resource() function doesn't return NULL, it returns error pointers. Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources") Signed-off-by: Dan Carpenter --- drivers/soc/ixp4xx/ixp4xx-npe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ixp4xx/ixp4xx-npe.c b/drivers/soc/ixp4xx/ixp4xx-npe.c index bc10e3194809..ec90b44fa0cd 100644 --- a/drivers/soc/ixp4xx/ixp4xx-npe.c +++ b/drivers/soc/ixp4xx/ixp4xx-npe.c @@ -695,8 +695,8 @@ static int ixp4xx_npe_probe(struct platform_device *pdev) continue; /* NPE already disabled or not present */ } npe->regs = devm_ioremap_resource(dev, res); - if (!npe->regs) - return -ENOMEM; + if (IS_ERR(npe->regs)) + return PTR_ERR(npe->regs); if (npe_reset(npe)) { dev_info(dev, "NPE%d at 0x%08x-0x%08x does not reset\n", -- 2.20.1