Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Mon, Aug 31, 2015 at 08:46:46AM -0500, Michael Welling wrote: > On Mon, Aug 31, 2015 at 09:53:55AM +0100, Mark Brown wrote: > > On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote: > > > The patch is currently sitting in linux-next. > > > Not sure why it wasn't merged with 4.2.0-rc8. > > You didn't indicate that it was a bug fix for Linus rather than a fix > > for recent development :( Ah, actually it did get applied as a fix - it's just that I didn't send a pull request before v4.3 got released. Looking at what's there I wasn't comfortable with the volume of fixes that arrived and never got round to picking out those that were most urgent. Sorry, these things do happen from time to time I'm afraid especially when I'm travelling, if something is urgent it's good to verify around -rc6 or so. > Sorry, I did not know that it was my responsibility. > How do I indicate this for future reference? > The patch that Sebastian sent said the following: > " > Michael also tested the patch, but have not explicitly written an > Tested-By, so you may want to wait for feedback from him. The patch > should be sent for 4.2-rc, which introduced the regression. > " That's not in the changelog which is all I have after the patch is applied (and what I was looking at since I just pulled the commit up by ID). If something is in Linus' tree it's often helpful to say "...introduced in v4.2-rc1" or similar in the changelog. Though in this case it wasn't the issue. signature.asc Description: Digital signature
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Mon, Aug 31, 2015 at 09:53:55AM +0100, Mark Brown wrote: > On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote: > > > The patch is currently sitting in linux-next. > > > Not sure why it wasn't merged with 4.2.0-rc8. > > You didn't indicate that it was a bug fix for Linus rather than a fix > for recent development :( Sorry, I did not know that it was my responsibility. How do I indicate this for future reference? The patch that Sebastian sent said the following: " Michael also tested the patch, but have not explicitly written an Tested-By, so you may want to wait for feedback from him. The patch should be sent for 4.2-rc, which introduced the regression. " -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote: > The patch is currently sitting in linux-next. > Not sure why it wasn't merged with 4.2.0-rc8. You didn't indicate that it was a bug fix for Linus rather than a fix for recent development :( signature.asc Description: Digital signature
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote: > The patch is currently sitting in linux-next. > Not sure why it wasn't merged with 4.2.0-rc8. You didn't indicate that it was a bug fix for Linus rather than a fix for recent development :( signature.asc Description: Digital signature
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Mon, Aug 31, 2015 at 08:46:46AM -0500, Michael Welling wrote: > On Mon, Aug 31, 2015 at 09:53:55AM +0100, Mark Brown wrote: > > On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote: > > > The patch is currently sitting in linux-next. > > > Not sure why it wasn't merged with 4.2.0-rc8. > > You didn't indicate that it was a bug fix for Linus rather than a fix > > for recent development :( Ah, actually it did get applied as a fix - it's just that I didn't send a pull request before v4.3 got released. Looking at what's there I wasn't comfortable with the volume of fixes that arrived and never got round to picking out those that were most urgent. Sorry, these things do happen from time to time I'm afraid especially when I'm travelling, if something is urgent it's good to verify around -rc6 or so. > Sorry, I did not know that it was my responsibility. > How do I indicate this for future reference? > The patch that Sebastian sent said the following: > " > Michael also tested the patch, but have not explicitly written an > Tested-By, so you may want to wait for feedback from him. The patch > should be sent for 4.2-rc, which introduced the regression. > " That's not in the changelog which is all I have after the patch is applied (and what I was looking at since I just pulled the commit up by ID). If something is in Linus' tree it's often helpful to say "...introduced in v4.2-rc1" or similar in the changelog. Though in this case it wasn't the issue. signature.asc Description: Digital signature
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Mon, Aug 31, 2015 at 09:53:55AM +0100, Mark Brown wrote: > On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote: > > > The patch is currently sitting in linux-next. > > > Not sure why it wasn't merged with 4.2.0-rc8. > > You didn't indicate that it was a bug fix for Linus rather than a fix > for recent development :( Sorry, I did not know that it was my responsibility. How do I indicate this for future reference? The patch that Sebastian sent said the following: " Michael also tested the patch, but have not explicitly written an Tested-By, so you may want to wait for feedback from him. The patch should be sent for 4.2-rc, which introduced the regression. " -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Sun, Aug 30, 2015 at 05:45:21PM +0300, Jarkko Nikula wrote: > Hi > > On 07/24/2015 07:39 PM, Mark Brown wrote: > > On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: > >> Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without > >> runtime power management requested. Thus the below kernel oops may be > >> generated if a device is accessed after the runtime power management > >> timeout. This patch fixes the problem by requesting runtime power > >> management in omap2_mcspi_set_cs(). > >> > >> [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) > >> at 0xfa09802c > >> [ 13.940490] pgd = cfb38000 > >> [ 13.946594] [fa09802c] *pgd=48011452(bad) > >> [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM > >> [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt > >> [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 > >> [ 13.971801] Hardware name: Nokia RX-51 board > >> [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 > >> [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c > >> [ 13.991485] LR is at spi_set_cs+0x5c/0x60 > > > > Please don't paste entire backtraces into commit messages, they are very > > large and almost entirely noise (for example in this case the entire > > explanation is in the commit message itself). If you feel a backtrace > > helps clarify things then please present an *edited* highlight of the > > relevant sections. > > present > > > Is there update to this patch? I don't see such in 4.2.0-rc8+. I hit > this same issue on Nokia N900 WLAN (CONFIG_WL1251=m and > CONFIG_WL1251_SPI=m) and googling lead to this patch which made the WLAN > working. > > If you are going to resend this, please feel free to add my tested by: > > Tested-by: Jarkko Nikula The patch is currently sitting in linux-next. Not sure why it wasn't merged with 4.2.0-rc8. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
Hi On 07/24/2015 07:39 PM, Mark Brown wrote: > On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: >> Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without >> runtime power management requested. Thus the below kernel oops may be >> generated if a device is accessed after the runtime power management >> timeout. This patch fixes the problem by requesting runtime power >> management in omap2_mcspi_set_cs(). >> >> [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at >> 0xfa09802c >> [ 13.940490] pgd = cfb38000 >> [ 13.946594] [fa09802c] *pgd=48011452(bad) >> [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM >> [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt >> [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 >> [ 13.971801] Hardware name: Nokia RX-51 board >> [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 >> [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c >> [ 13.991485] LR is at spi_set_cs+0x5c/0x60 > > Please don't paste entire backtraces into commit messages, they are very > large and almost entirely noise (for example in this case the entire > explanation is in the commit message itself). If you feel a backtrace > helps clarify things then please present an *edited* highlight of the > relevant sections. > present > Is there update to this patch? I don't see such in 4.2.0-rc8+. I hit this same issue on Nokia N900 WLAN (CONFIG_WL1251=m and CONFIG_WL1251_SPI=m) and googling lead to this patch which made the WLAN working. If you are going to resend this, please feel free to add my tested by: Tested-by: Jarkko Nikula -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
Hi On 07/24/2015 07:39 PM, Mark Brown wrote: On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without runtime power management requested. Thus the below kernel oops may be generated if a device is accessed after the runtime power management timeout. This patch fixes the problem by requesting runtime power management in omap2_mcspi_set_cs(). [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09802c [ 13.940490] pgd = cfb38000 [ 13.946594] [fa09802c] *pgd=48011452(bad) [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 [ 13.971801] Hardware name: Nokia RX-51 board [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c [ 13.991485] LR is at spi_set_cs+0x5c/0x60 Please don't paste entire backtraces into commit messages, they are very large and almost entirely noise (for example in this case the entire explanation is in the commit message itself). If you feel a backtrace helps clarify things then please present an *edited* highlight of the relevant sections. present Is there update to this patch? I don't see such in 4.2.0-rc8+. I hit this same issue on Nokia N900 WLAN (CONFIG_WL1251=m and CONFIG_WL1251_SPI=m) and googling lead to this patch which made the WLAN working. If you are going to resend this, please feel free to add my tested by: Tested-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Sun, Aug 30, 2015 at 05:45:21PM +0300, Jarkko Nikula wrote: Hi On 07/24/2015 07:39 PM, Mark Brown wrote: On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without runtime power management requested. Thus the below kernel oops may be generated if a device is accessed after the runtime power management timeout. This patch fixes the problem by requesting runtime power management in omap2_mcspi_set_cs(). [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09802c [ 13.940490] pgd = cfb38000 [ 13.946594] [fa09802c] *pgd=48011452(bad) [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 [ 13.971801] Hardware name: Nokia RX-51 board [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c [ 13.991485] LR is at spi_set_cs+0x5c/0x60 Please don't paste entire backtraces into commit messages, they are very large and almost entirely noise (for example in this case the entire explanation is in the commit message itself). If you feel a backtrace helps clarify things then please present an *edited* highlight of the relevant sections. present Is there update to this patch? I don't see such in 4.2.0-rc8+. I hit this same issue on Nokia N900 WLAN (CONFIG_WL1251=m and CONFIG_WL1251_SPI=m) and googling lead to this patch which made the WLAN working. If you are going to resend this, please feel free to add my tested by: Tested-by: Jarkko Nikula jarkko.nik...@bitmer.com The patch is currently sitting in linux-next. Not sure why it wasn't merged with 4.2.0-rc8. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: > Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without > runtime power management requested. Thus the below kernel oops may be > generated if a device is accessed after the runtime power management > timeout. This patch fixes the problem by requesting runtime power > management in omap2_mcspi_set_cs(). > > [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at > 0xfa09802c > [ 13.940490] pgd = cfb38000 > [ 13.946594] [fa09802c] *pgd=48011452(bad) > [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM > [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt > [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 > [ 13.971801] Hardware name: Nokia RX-51 board > [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 > [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c > [ 13.991485] LR is at spi_set_cs+0x5c/0x60 Please don't paste entire backtraces into commit messages, they are very large and almost entirely noise (for example in this case the entire explanation is in the commit message itself). If you feel a backtrace helps clarify things then please present an *edited* highlight of the relevant sections. present signature.asc Description: Digital signature
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without runtime power management requested. Thus the below kernel oops may be generated if a device is accessed after the runtime power management timeout. This patch fixes the problem by requesting runtime power management in omap2_mcspi_set_cs(). [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09802c [ 13.940490] pgd = cfb38000 [ 13.946594] [fa09802c] *pgd=48011452(bad) [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 [ 13.971801] Hardware name: Nokia RX-51 board [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c [ 13.991485] LR is at spi_set_cs+0x5c/0x60 Please don't paste entire backtraces into commit messages, they are very large and almost entirely noise (for example in this case the entire explanation is in the commit message itself). If you feel a backtrace helps clarify things then please present an *edited* highlight of the relevant sections. present signature.asc Description: Digital signature
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: > Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without > runtime power management requested. Thus the below kernel oops may be > generated if a device is accessed after the runtime power management > timeout. This patch fixes the problem by requesting runtime power > management in omap2_mcspi_set_cs(). > > [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at > 0xfa09802c > [ 13.940490] pgd = cfb38000 > [ 13.946594] [fa09802c] *pgd=48011452(bad) > [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM > [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt > [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 > [ 13.971801] Hardware name: Nokia RX-51 board > [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 > [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c > [ 13.991485] LR is at spi_set_cs+0x5c/0x60 > [ 13.997985] pc : []lr : []psr: 2013 > [ 13.997985] sp : cb1f3dd0 ip : 0001 fp : 0004 > [ 14.011260] r10: cfce5be8 r9 : 0fff r8 : c0654f98 > [ 14.017913] r7 : r6 : r5 : r4 : > [ 14.024505] r3 : 200103dc r2 : fa098000 r1 : 0001 r0 : cf09bc00 > [ 14.031036] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment > user > [ 14.037689] Control: 10c5387d Table: 8fb38019 DAC: 0015 > [ 14.044403] Process modprobe (pid: 183, stack limit = 0xcb1f2210) > [ 14.051300] Stack: (0xcb1f3dd0 to 0xcb1f4000) > [ 14.058105] 3dc0: cf09bc00 c02bafa4 > cf09bc00 cf09bc00 > [ 14.065277] 3de0: bf013444 bf01254c cf0e2230 cf0e2230 0001 c0654f98 > 0fff 0fff > [ 14.072570] 3e00: 0008 0002 0118 1f40 0031 cf09bc00 > ffed bf013444 > [ 14.080078] 3e20: 0031 c0654f98 cb1f2000 c02bb5c0 > cf09bc00 > [ 14.087738] 3e40: bf013454 c027a2f4 cf09bc00 bf013454 bf013454 > c027a594 > [ 14.095367] 3e60: cf09bc00 cf09bc34 c027a60c bf013454 cb1f3e80 > c027a5ac c0278ec8 > [ 14.102935] 3e80: cf972c4c cf09d630 bf013454 bf013454 cbb55300 c06848d8 > c0279c84 > [ 14.110473] 3ea0: bf01327c bf01327d bf013454 cb889180 > c0654f98 c027b0c8 > [ 14.117980] 3ec0: bf015000 cb889180 c00095b0 0040003e cfe6a080 > 0040003f > [ 14.125457] 3ee0: 0008 cfcf9000 cb1f2000 6013 0040003e cbf1bbc0 > 0001 > [ 14.132843] 3f00: bf0134cc cb1f2000 bf0134c0 cb1f3f58 c04352d0 > cf801f00 00d0 > [ 14.140136] 3f20: bf0134c0 bf0134c0 416c cb889040 0080 c000ebe4 > cb1f2000 c0089f68 > [ 14.147308] 3f40: bf0134c0 cbf1bc00 001a9193 416c 001f8d20 c008ab30 > d0b1 416c > [ 14.154571] 3f60: d0b1267c d0b1252b d0b13514 16c0 1ad0 > > [ 14.161865] 3f80: 001f 0020 0017 0014 0012 > 00201208 > [ 14.169097] 3fa0: c000ea60 00201208 001f8d20 416c > 001a9193 > [ 14.176177] 3fc0: 00201208 0080 00208c20 001a9193 > bee09e98 > [ 14.183197] 3fe0: b6f742b4 bee09ae4 000153f0 93e4 6010 001f8d20 > 72757463 69665f65 > [ 14.190277] [] (omap2_mcspi_set_cs) from [] > (spi_set_cs+0x5c/0x60) > [ 14.197479] [] (spi_set_cs) from [] > (spi_setup+0xd4/0x10c) > [ 14.204833] [] (spi_setup) from [] > (tsc2005_probe+0x104/0x484 [tsc2005]) > [ 14.212249] [] (tsc2005_probe [tsc2005]) from [] > (spi_drv_probe+0x50/0x6c) > [ 14.219818] [] (spi_drv_probe) from [] > (really_probe+0xd4/0x230) > [ 14.227478] [] (really_probe) from [] > (driver_probe_device+0x30/0x48) > [ 14.235290] [] (driver_probe_device) from [] > (__driver_attach+0x60/0x84) > [ 14.243286] [] (__driver_attach) from [] > (bus_for_each_dev+0x50/0x84) > [ 14.251281] [] (bus_for_each_dev) from [] > (bus_add_driver+0xcc/0x1e0) > [ 14.259246] [] (bus_add_driver) from [] > (driver_register+0x9c/0xe0) > [ 14.267272] [] (driver_register) from [] > (do_one_initcall+0x100/0x1b0) > [ 14.275421] [] (do_one_initcall) from [] > (do_init_module+0x58/0x1bc) > [ 14.283477] [] (do_init_module) from [] > (SyS_init_module+0x54/0x64) > [ 14.291412] [] (SyS_init_module) from [] > (ret_fast_syscall+0x0/0x3c) > [ 14.299407] Code: e5823018 e5902188 e5922000 e582302c (e592302c) > [ 14.307403] ---[ end trace d21553dcaefcb5ac ]--- > > Reported-By: Pali Rohár > Fixes: ddcad7e9068eb (spi: omap2-mcspi: Fix native cs with new set_cs) > Tested-By: Pavel Machek > Signed-off-by: Sebastian Reichel > --- > Hi Mark, > > Previous discussion about this patch happened in the following thread: > > https://lkml.org/lkml/2015/7/11/98 > > Michael also tested the patch, but have not explicitly written an > Tested-By, so you may want to wait for feedback from him. The patch >
[PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without runtime power management requested. Thus the below kernel oops may be generated if a device is accessed after the runtime power management timeout. This patch fixes the problem by requesting runtime power management in omap2_mcspi_set_cs(). [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09802c [ 13.940490] pgd = cfb38000 [ 13.946594] [fa09802c] *pgd=48011452(bad) [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 [ 13.971801] Hardware name: Nokia RX-51 board [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c [ 13.991485] LR is at spi_set_cs+0x5c/0x60 [ 13.997985] pc : []lr : []psr: 2013 [ 13.997985] sp : cb1f3dd0 ip : 0001 fp : 0004 [ 14.011260] r10: cfce5be8 r9 : 0fff r8 : c0654f98 [ 14.017913] r7 : r6 : r5 : r4 : [ 14.024505] r3 : 200103dc r2 : fa098000 r1 : 0001 r0 : cf09bc00 [ 14.031036] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 14.037689] Control: 10c5387d Table: 8fb38019 DAC: 0015 [ 14.044403] Process modprobe (pid: 183, stack limit = 0xcb1f2210) [ 14.051300] Stack: (0xcb1f3dd0 to 0xcb1f4000) [ 14.058105] 3dc0: cf09bc00 c02bafa4 cf09bc00 cf09bc00 [ 14.065277] 3de0: bf013444 bf01254c cf0e2230 cf0e2230 0001 c0654f98 0fff 0fff [ 14.072570] 3e00: 0008 0002 0118 1f40 0031 cf09bc00 ffed bf013444 [ 14.080078] 3e20: 0031 c0654f98 cb1f2000 c02bb5c0 cf09bc00 [ 14.087738] 3e40: bf013454 c027a2f4 cf09bc00 bf013454 bf013454 c027a594 [ 14.095367] 3e60: cf09bc00 cf09bc34 c027a60c bf013454 cb1f3e80 c027a5ac c0278ec8 [ 14.102935] 3e80: cf972c4c cf09d630 bf013454 bf013454 cbb55300 c06848d8 c0279c84 [ 14.110473] 3ea0: bf01327c bf01327d bf013454 cb889180 c0654f98 c027b0c8 [ 14.117980] 3ec0: bf015000 cb889180 c00095b0 0040003e cfe6a080 0040003f [ 14.125457] 3ee0: 0008 cfcf9000 cb1f2000 6013 0040003e cbf1bbc0 0001 [ 14.132843] 3f00: bf0134cc cb1f2000 bf0134c0 cb1f3f58 c04352d0 cf801f00 00d0 [ 14.140136] 3f20: bf0134c0 bf0134c0 416c cb889040 0080 c000ebe4 cb1f2000 c0089f68 [ 14.147308] 3f40: bf0134c0 cbf1bc00 001a9193 416c 001f8d20 c008ab30 d0b1 416c [ 14.154571] 3f60: d0b1267c d0b1252b d0b13514 16c0 1ad0 [ 14.161865] 3f80: 001f 0020 0017 0014 0012 00201208 [ 14.169097] 3fa0: c000ea60 00201208 001f8d20 416c 001a9193 [ 14.176177] 3fc0: 00201208 0080 00208c20 001a9193 bee09e98 [ 14.183197] 3fe0: b6f742b4 bee09ae4 000153f0 93e4 6010 001f8d20 72757463 69665f65 [ 14.190277] [] (omap2_mcspi_set_cs) from [] (spi_set_cs+0x5c/0x60) [ 14.197479] [] (spi_set_cs) from [] (spi_setup+0xd4/0x10c) [ 14.204833] [] (spi_setup) from [] (tsc2005_probe+0x104/0x484 [tsc2005]) [ 14.212249] [] (tsc2005_probe [tsc2005]) from [] (spi_drv_probe+0x50/0x6c) [ 14.219818] [] (spi_drv_probe) from [] (really_probe+0xd4/0x230) [ 14.227478] [] (really_probe) from [] (driver_probe_device+0x30/0x48) [ 14.235290] [] (driver_probe_device) from [] (__driver_attach+0x60/0x84) [ 14.243286] [] (__driver_attach) from [] (bus_for_each_dev+0x50/0x84) [ 14.251281] [] (bus_for_each_dev) from [] (bus_add_driver+0xcc/0x1e0) [ 14.259246] [] (bus_add_driver) from [] (driver_register+0x9c/0xe0) [ 14.267272] [] (driver_register) from [] (do_one_initcall+0x100/0x1b0) [ 14.275421] [] (do_one_initcall) from [] (do_init_module+0x58/0x1bc) [ 14.283477] [] (do_init_module) from [] (SyS_init_module+0x54/0x64) [ 14.291412] [] (SyS_init_module) from [] (ret_fast_syscall+0x0/0x3c) [ 14.299407] Code: e5823018 e5902188 e5922000 e582302c (e592302c) [ 14.307403] ---[ end trace d21553dcaefcb5ac ]--- Reported-By: Pali Rohár Fixes: ddcad7e9068eb (spi: omap2-mcspi: Fix native cs with new set_cs) Tested-By: Pavel Machek Signed-off-by: Sebastian Reichel --- Hi Mark, Previous discussion about this patch happened in the following thread: https://lkml.org/lkml/2015/7/11/98 Michael also tested the patch, but have not explicitly written an Tested-By, so you may want to wait for feedback from him. The patch should be sent for 4.2-rc, which introduced the regression. -- Sebastian --- drivers/spi/spi-omap2-mcspi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 5867384..3d09e0b 100644 ---
[PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without runtime power management requested. Thus the below kernel oops may be generated if a device is accessed after the runtime power management timeout. This patch fixes the problem by requesting runtime power management in omap2_mcspi_set_cs(). [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09802c [ 13.940490] pgd = cfb38000 [ 13.946594] [fa09802c] *pgd=48011452(bad) [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 [ 13.971801] Hardware name: Nokia RX-51 board [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c [ 13.991485] LR is at spi_set_cs+0x5c/0x60 [ 13.997985] pc : [c02bd3ac]lr : [c02baecc]psr: 2013 [ 13.997985] sp : cb1f3dd0 ip : 0001 fp : 0004 [ 14.011260] r10: cfce5be8 r9 : 0fff r8 : c0654f98 [ 14.017913] r7 : r6 : r5 : r4 : [ 14.024505] r3 : 200103dc r2 : fa098000 r1 : 0001 r0 : cf09bc00 [ 14.031036] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 14.037689] Control: 10c5387d Table: 8fb38019 DAC: 0015 [ 14.044403] Process modprobe (pid: 183, stack limit = 0xcb1f2210) [ 14.051300] Stack: (0xcb1f3dd0 to 0xcb1f4000) [ 14.058105] 3dc0: cf09bc00 c02bafa4 cf09bc00 cf09bc00 [ 14.065277] 3de0: bf013444 bf01254c cf0e2230 cf0e2230 0001 c0654f98 0fff 0fff [ 14.072570] 3e00: 0008 0002 0118 1f40 0031 cf09bc00 ffed bf013444 [ 14.080078] 3e20: 0031 c0654f98 cb1f2000 c02bb5c0 cf09bc00 [ 14.087738] 3e40: bf013454 c027a2f4 cf09bc00 bf013454 bf013454 c027a594 [ 14.095367] 3e60: cf09bc00 cf09bc34 c027a60c bf013454 cb1f3e80 c027a5ac c0278ec8 [ 14.102935] 3e80: cf972c4c cf09d630 bf013454 bf013454 cbb55300 c06848d8 c0279c84 [ 14.110473] 3ea0: bf01327c bf01327d bf013454 cb889180 c0654f98 c027b0c8 [ 14.117980] 3ec0: bf015000 cb889180 c00095b0 0040003e cfe6a080 0040003f [ 14.125457] 3ee0: 0008 cfcf9000 cb1f2000 6013 0040003e cbf1bbc0 0001 [ 14.132843] 3f00: bf0134cc cb1f2000 bf0134c0 cb1f3f58 c04352d0 cf801f00 00d0 [ 14.140136] 3f20: bf0134c0 bf0134c0 416c cb889040 0080 c000ebe4 cb1f2000 c0089f68 [ 14.147308] 3f40: bf0134c0 cbf1bc00 001a9193 416c 001f8d20 c008ab30 d0b1 416c [ 14.154571] 3f60: d0b1267c d0b1252b d0b13514 16c0 1ad0 [ 14.161865] 3f80: 001f 0020 0017 0014 0012 00201208 [ 14.169097] 3fa0: c000ea60 00201208 001f8d20 416c 001a9193 [ 14.176177] 3fc0: 00201208 0080 00208c20 001a9193 bee09e98 [ 14.183197] 3fe0: b6f742b4 bee09ae4 000153f0 93e4 6010 001f8d20 72757463 69665f65 [ 14.190277] [c02bd3ac] (omap2_mcspi_set_cs) from [c02baecc] (spi_set_cs+0x5c/0x60) [ 14.197479] [c02baecc] (spi_set_cs) from [c02bafa4] (spi_setup+0xd4/0x10c) [ 14.204833] [c02bafa4] (spi_setup) from [bf01254c] (tsc2005_probe+0x104/0x484 [tsc2005]) [ 14.212249] [bf01254c] (tsc2005_probe [tsc2005]) from [c02bb5c0] (spi_drv_probe+0x50/0x6c) [ 14.219818] [c02bb5c0] (spi_drv_probe) from [c027a2f4] (really_probe+0xd4/0x230) [ 14.227478] [c027a2f4] (really_probe) from [c027a594] (driver_probe_device+0x30/0x48) [ 14.235290] [c027a594] (driver_probe_device) from [c027a60c] (__driver_attach+0x60/0x84) [ 14.243286] [c027a60c] (__driver_attach) from [c0278ec8] (bus_for_each_dev+0x50/0x84) [ 14.251281] [c0278ec8] (bus_for_each_dev) from [c0279c84] (bus_add_driver+0xcc/0x1e0) [ 14.259246] [c0279c84] (bus_add_driver) from [c027b0c8] (driver_register+0x9c/0xe0) [ 14.267272] [c027b0c8] (driver_register) from [c00095b0] (do_one_initcall+0x100/0x1b0) [ 14.275421] [c00095b0] (do_one_initcall) from [c0089f68] (do_init_module+0x58/0x1bc) [ 14.283477] [c0089f68] (do_init_module) from [c008ab30] (SyS_init_module+0x54/0x64) [ 14.291412] [c008ab30] (SyS_init_module) from [c000ea60] (ret_fast_syscall+0x0/0x3c) [ 14.299407] Code: e5823018 e5902188 e5922000 e582302c (e592302c) [ 14.307403] ---[ end trace d21553dcaefcb5ac ]--- Reported-By: Pali Rohár pali.ro...@gmail.com Fixes: ddcad7e9068eb (spi: omap2-mcspi: Fix native cs with new set_cs) Tested-By: Pavel Machek pa...@ucw.cz Signed-off-by: Sebastian Reichel s...@kernel.org --- Hi Mark, Previous discussion about this patch happened in the following thread: https://lkml.org/lkml/2015/7/11/98 Michael also tested the patch, but have not explicitly written an Tested-By, so you may want to wait for feedback from him. The patch
Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()
On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without runtime power management requested. Thus the below kernel oops may be generated if a device is accessed after the runtime power management timeout. This patch fixes the problem by requesting runtime power management in omap2_mcspi_set_cs(). [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09802c [ 13.940490] pgd = cfb38000 [ 13.946594] [fa09802c] *pgd=48011452(bad) [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 [ 13.971801] Hardware name: Nokia RX-51 board [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c [ 13.991485] LR is at spi_set_cs+0x5c/0x60 [ 13.997985] pc : [c02bd3ac]lr : [c02baecc]psr: 2013 [ 13.997985] sp : cb1f3dd0 ip : 0001 fp : 0004 [ 14.011260] r10: cfce5be8 r9 : 0fff r8 : c0654f98 [ 14.017913] r7 : r6 : r5 : r4 : [ 14.024505] r3 : 200103dc r2 : fa098000 r1 : 0001 r0 : cf09bc00 [ 14.031036] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 14.037689] Control: 10c5387d Table: 8fb38019 DAC: 0015 [ 14.044403] Process modprobe (pid: 183, stack limit = 0xcb1f2210) [ 14.051300] Stack: (0xcb1f3dd0 to 0xcb1f4000) [ 14.058105] 3dc0: cf09bc00 c02bafa4 cf09bc00 cf09bc00 [ 14.065277] 3de0: bf013444 bf01254c cf0e2230 cf0e2230 0001 c0654f98 0fff 0fff [ 14.072570] 3e00: 0008 0002 0118 1f40 0031 cf09bc00 ffed bf013444 [ 14.080078] 3e20: 0031 c0654f98 cb1f2000 c02bb5c0 cf09bc00 [ 14.087738] 3e40: bf013454 c027a2f4 cf09bc00 bf013454 bf013454 c027a594 [ 14.095367] 3e60: cf09bc00 cf09bc34 c027a60c bf013454 cb1f3e80 c027a5ac c0278ec8 [ 14.102935] 3e80: cf972c4c cf09d630 bf013454 bf013454 cbb55300 c06848d8 c0279c84 [ 14.110473] 3ea0: bf01327c bf01327d bf013454 cb889180 c0654f98 c027b0c8 [ 14.117980] 3ec0: bf015000 cb889180 c00095b0 0040003e cfe6a080 0040003f [ 14.125457] 3ee0: 0008 cfcf9000 cb1f2000 6013 0040003e cbf1bbc0 0001 [ 14.132843] 3f00: bf0134cc cb1f2000 bf0134c0 cb1f3f58 c04352d0 cf801f00 00d0 [ 14.140136] 3f20: bf0134c0 bf0134c0 416c cb889040 0080 c000ebe4 cb1f2000 c0089f68 [ 14.147308] 3f40: bf0134c0 cbf1bc00 001a9193 416c 001f8d20 c008ab30 d0b1 416c [ 14.154571] 3f60: d0b1267c d0b1252b d0b13514 16c0 1ad0 [ 14.161865] 3f80: 001f 0020 0017 0014 0012 00201208 [ 14.169097] 3fa0: c000ea60 00201208 001f8d20 416c 001a9193 [ 14.176177] 3fc0: 00201208 0080 00208c20 001a9193 bee09e98 [ 14.183197] 3fe0: b6f742b4 bee09ae4 000153f0 93e4 6010 001f8d20 72757463 69665f65 [ 14.190277] [c02bd3ac] (omap2_mcspi_set_cs) from [c02baecc] (spi_set_cs+0x5c/0x60) [ 14.197479] [c02baecc] (spi_set_cs) from [c02bafa4] (spi_setup+0xd4/0x10c) [ 14.204833] [c02bafa4] (spi_setup) from [bf01254c] (tsc2005_probe+0x104/0x484 [tsc2005]) [ 14.212249] [bf01254c] (tsc2005_probe [tsc2005]) from [c02bb5c0] (spi_drv_probe+0x50/0x6c) [ 14.219818] [c02bb5c0] (spi_drv_probe) from [c027a2f4] (really_probe+0xd4/0x230) [ 14.227478] [c027a2f4] (really_probe) from [c027a594] (driver_probe_device+0x30/0x48) [ 14.235290] [c027a594] (driver_probe_device) from [c027a60c] (__driver_attach+0x60/0x84) [ 14.243286] [c027a60c] (__driver_attach) from [c0278ec8] (bus_for_each_dev+0x50/0x84) [ 14.251281] [c0278ec8] (bus_for_each_dev) from [c0279c84] (bus_add_driver+0xcc/0x1e0) [ 14.259246] [c0279c84] (bus_add_driver) from [c027b0c8] (driver_register+0x9c/0xe0) [ 14.267272] [c027b0c8] (driver_register) from [c00095b0] (do_one_initcall+0x100/0x1b0) [ 14.275421] [c00095b0] (do_one_initcall) from [c0089f68] (do_init_module+0x58/0x1bc) [ 14.283477] [c0089f68] (do_init_module) from [c008ab30] (SyS_init_module+0x54/0x64) [ 14.291412] [c008ab30] (SyS_init_module) from [c000ea60] (ret_fast_syscall+0x0/0x3c) [ 14.299407] Code: e5823018 e5902188 e5922000 e582302c (e592302c) [ 14.307403] ---[ end trace d21553dcaefcb5ac ]--- Reported-By: Pali Rohár pali.ro...@gmail.com Fixes: ddcad7e9068eb (spi: omap2-mcspi: Fix native cs with new set_cs) Tested-By: Pavel Machek pa...@ucw.cz Signed-off-by: Sebastian Reichel s...@kernel.org --- Hi Mark, Previous discussion about this patch happened in the following thread:
