Re: [PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

2017-11-16 Thread arvindY 

hi,

On Thursday 16 November 2017 07:27 PM, Ian Abbott wrote:

On 16/11/17 04:32, Arvind Yadav wrote:

pnp_irq() and pnp_port_start() can fail here and we must check
its return value.

Signed-off-by: Arvind Yadav 
---
  drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
b/drivers/staging/comedi/drivers/ni_atmio.c

index 2d62a8c..dead159 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -308,6 +308,9 @@ static int ni_atmio_attach(struct comedi_device 
*dev,

iobase = pnp_port_start(isapnp_dev, 0);
  irq = pnp_irq(isapnp_dev, 0);
+if (irq == -1 || !iobase)
+return -ENOMEM;
+
  comedi_set_hw_dev(dev, _dev->dev);
  }



Can they fail here?  ni_isapnp_find_board() has already checked they 
are valid.

Yes, you are right. It will not fail.

~arvind

Re: [PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

2017-11-16 Thread arvindY 

hi,

On Thursday 16 November 2017 07:27 PM, Ian Abbott wrote:

On 16/11/17 04:32, Arvind Yadav wrote:

pnp_irq() and pnp_port_start() can fail here and we must check
its return value.

Signed-off-by: Arvind Yadav 
---
  drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
b/drivers/staging/comedi/drivers/ni_atmio.c

index 2d62a8c..dead159 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -308,6 +308,9 @@ static int ni_atmio_attach(struct comedi_device 
*dev,

iobase = pnp_port_start(isapnp_dev, 0);
  irq = pnp_irq(isapnp_dev, 0);
+if (irq == -1 || !iobase)
+return -ENOMEM;
+
  comedi_set_hw_dev(dev, _dev->dev);
  }



Can they fail here?  ni_isapnp_find_board() has already checked they 
are valid.

Yes, you are right. It will not fail.

~arvind

Re: [PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

2017-11-16 Thread Ian Abbott 

On 16/11/17 04:32, Arvind Yadav wrote:

pnp_irq() and pnp_port_start() can fail here and we must check
its return value.

Signed-off-by: Arvind Yadav 
---
  drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
b/drivers/staging/comedi/drivers/ni_atmio.c
index 2d62a8c..dead159 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -308,6 +308,9 @@ static int ni_atmio_attach(struct comedi_device *dev,
  
  		iobase = pnp_port_start(isapnp_dev, 0);

irq = pnp_irq(isapnp_dev, 0);
+   if (irq == -1 || !iobase)
+   return -ENOMEM;
+
comedi_set_hw_dev(dev, _dev->dev);
}
  



Can they fail here?  ni_isapnp_find_board() has already checked they are 
valid.


--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-

Re: [PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

2017-11-16 Thread Ian Abbott 

On 16/11/17 04:32, Arvind Yadav wrote:

pnp_irq() and pnp_port_start() can fail here and we must check
its return value.

Signed-off-by: Arvind Yadav 
---
  drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
b/drivers/staging/comedi/drivers/ni_atmio.c
index 2d62a8c..dead159 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -308,6 +308,9 @@ static int ni_atmio_attach(struct comedi_device *dev,
  
  		iobase = pnp_port_start(isapnp_dev, 0);

irq = pnp_irq(isapnp_dev, 0);
+   if (irq == -1 || !iobase)
+   return -ENOMEM;
+
comedi_set_hw_dev(dev, _dev->dev);
}
  



Can they fail here?  ni_isapnp_find_board() has already checked they are 
valid.


--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-

[PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

2017-11-15 Thread Arvind Yadav 
pnp_irq() and pnp_port_start() can fail here and we must check
its return value.

Signed-off-by: Arvind Yadav 
---
 drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
b/drivers/staging/comedi/drivers/ni_atmio.c
index 2d62a8c..dead159 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -308,6 +308,9 @@ static int ni_atmio_attach(struct comedi_device *dev,
 
iobase = pnp_port_start(isapnp_dev, 0);
irq = pnp_irq(isapnp_dev, 0);
+   if (irq == -1 || !iobase)
+   return -ENOMEM;
+
comedi_set_hw_dev(dev, _dev->dev);
}
 
-- 
1.9.1

[PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

2017-11-15 Thread Arvind Yadav 
pnp_irq() and pnp_port_start() can fail here and we must check
its return value.

Signed-off-by: Arvind Yadav 
---
 drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
b/drivers/staging/comedi/drivers/ni_atmio.c
index 2d62a8c..dead159 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -308,6 +308,9 @@ static int ni_atmio_attach(struct comedi_device *dev,
 
iobase = pnp_port_start(isapnp_dev, 0);
irq = pnp_irq(isapnp_dev, 0);
+   if (irq == -1 || !iobase)
+   return -ENOMEM;
+
comedi_set_hw_dev(dev, _dev->dev);
}
 
-- 
1.9.1